PCL armhf FTBFS

[Kyle Fazzari]

[Impact]

 * PCL fails to build on armhf in Xenial due to https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=835292

 * The patch fixes this issue by backporting the fix from Debian: https://salsa.debian.org/science-team/pcl/-/commit/f559d014ee8960f84100d6b6cd8e7372de15fbb4 (with a slight tweak to keep things safer)

[Test Case]

 * Build PCL on armhf, note that it fails to build with opengl-related errors (see this build log as an example: https://launchpadlibrarian.net/508382337/buildlog_ubuntu-xenial-armhf.pcl_1.7.2-14build1.1_BUILDING.txt.gz)

 * Apply this patch and build PCL again, note that it succeeds because Qt (the package that is including gles on armhf only) is not installed

[Where problems could occur]

 * This is fixing a failure to build on armhf: no one can possibly be currently using it, and the fix is armhf-specific. Regression potential is low unless a typo is made in the patch.

[Kyle Fazzari (kyrofa)]

Here is a patch for Xenial. It's mostly a backport of the upstream Debian patch (https://salsa.debian.org/science-team/pcl/-/commit/f559d014ee8960f84100d6b6cd8e7372de15fbb4), but opts not to completely remove the dependency on Qt4 to ensure no changes on other architectures.

[Marc Deslauriers (mdeslaur)]

ACK on the debdiff in comment #1, I've done a test rebuild and it built on armhf.

I've uploaded it for processing by the SRU team.

[Kyle Fazzari (kyrofa)]

Thank you, Marc!

[Brian Murray (brian-murray)]

Hello Kyle, or anyone else affected,

Accepted pcl into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pcl/1.7.2-14ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kyle Fazzari (kyrofa)]

Verified: I can actually install pcl-dev on armhf now. I tested it using https://github.com/kyrofa/pcl-sru-test which is (mostly) taken from https://pcl.readthedocs.io/en/latest/using_pcl_pcl_config.html#using-pcl-pcl-config:

$ git clone https://github.com/kyrofa/pcl-sru-test.git
$ cd pcl-sru-test
$ mkdir build
$ cd build
$ cmake .. && make
$ ./pcd_write_test
Saved 5 data points to test_pcd.pcd.
    0.352222 -0.151883 -0.106395
    -0.397406 -0.473106 0.292602
    -0.731898 0.667105 0.441304
    -0.734766 0.854581 -0.0361733
    -0.4607 -0.277468 -0.916762

Looks good!

[Kyle Fazzari (kyrofa)]

Note that this failed to build on ppc64el:

powerpc64le-linux-gnu-g++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-5/README.Bugs> for instructions.
recognition/CMakeFiles/pcl_recognition.dir/build.make:281: recipe for target 'recognition/CMakeFiles/pcl_recognition.dir/src/cg/geometric_consistency.cpp.o' failed

That actually looks like it ran out of RAM. This patch should have made this effectively a no-change rebuild for ppc64el. It looks like it needs to be built again.

[Marc Deslauriers (mdeslaur)]

I've clicked the retry button for ppc64el, let's see.

[Marc Deslauriers (mdeslaur)]

Looks like ppc64el built now.

[Kyle Fazzari (kyrofa)]

Phew, thanks Marc.

[Launchpad Janitor (janitor)]

This bug was fixed in the package pcl - 1.7.2-14ubuntu0.1

---------------
pcl (1.7.2-14ubuntu0.1) xenial; urgency=medium

  * Don't depend upon Qt for armhf or armel (LP: #1906277)

 -- Kyle Fazzari <email address hidden> Mon, 30 Nov 2020 08:35:10 -0800

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for pcl has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.