Registration email to admin has mixed English and other language if admin wants messages in another language

Bug #1905624 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned

Bug Description

The problem is we translate the $expirystring before adding it to the email we send to the admin and we translate the second part for the person receiving it but the first part as person sending it.

Revision history for this message
Robert Lyon (robertl-9) wrote :

So to test:

1) Have an institution set with register + confirm set to Yes
and have the institution language set to German

2) Logout and then go to 'Register' page and switch the language selector at top of page to French
Fill in the form and submit it.

In the email that is sent to the admin it will have a line similar to:

Die Bestätigung oder Ablehnung muss innerhalb von Pas de date d'échéance erfolgen.

Where the 'Pas de date d'échéance' part is French but the rest is German

Changed in mahara:
milestone: none → 21.04.0
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11471

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11471
Committed: https://git.mahara.org/mahara/mahara/commit/aaf4b0f1879de2053bf0d86f246e28f4bc5f4d56
Submitter: Lisa Seeto (<email address hidden>)
Branch: master

commit aaf4b0f1879de2053bf0d86f246e28f4bc5f4d56
Author: Robert Lyon <email address hidden>
Date: Thu Nov 26 10:15:10 2020 +1300

Bug 1905624: Make sure expiry part of message is in correct language

Change-Id: I748929f5889f5a94a9eddeaf7d332b17b1ecddb6
Signed-off-by: Robert Lyon <email address hidden>

Lisa Seeto (lisaseeto)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.