Mahara

Need to fix hardcoded strings in the view access messages

  1. Series 20.10
  2. Bug #1905086
Bug #1905086 reported by Robert Lyon
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
20.10
Fix Released
Medium
Unassigned
Mahara 20.10.1
21.04
Fix Released
Medium
Lisa Seeto
Mahara 21.04.0

Bug Description

There are hardcoded strings in
 htdocs/theme/raw/templates/account/activity/accessemail.tpl
 htdocs/theme/raw/templates/account/activity/accessinternal.tpl

They need to be language strings
See patch https://reviews.mahara.org/#/c/11160/ for when they were added

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Lisa Seeto (lisaseeto)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11464

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/11466

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11464
Committed: https://git.mahara.org/mahara/mahara/commit/35da77ca7798ee5eb1faded613373d63a9acf841
Submitter: Lisa Seeto (<email address hidden>)
Branch: master

commit 35da77ca7798ee5eb1faded613373d63a9acf841
Author: Lisa Seeto <email address hidden>
Date: Mon Nov 23 10:02:38 2020 +1300

Bug 1905086: Need to fix hardcoded strings in the view access messages

- added new lang string, amended the tpl files

Change-Id: I5d462897dc762ea2af636bd9c00871f5154ce7fa
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11469

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11469
Committed: https://git.mahara.org/mahara/mahara/commit/046ec77a744a5b02c1dcd5282c9373d7e663f34d
Submitter: Lisa Seeto (<email address hidden>)
Branch: 20.10_STABLE

commit 046ec77a744a5b02c1dcd5282c9373d7e663f34d
Author: Lisa Seeto <email address hidden>
Date: Mon Nov 23 10:02:38 2020 +1300

Bug 1905086: Need to fix hardcoded strings in the view access messages

- added new lang string, amended the tpl files

Change-Id: I5d462897dc762ea2af636bd9c00871f5154ce7fa
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 35da77ca7798ee5eb1faded613373d63a9acf841)

Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.