focal:linux-hwe-5.8 evdi-dkms build failure

[Khaled El Mously]

Impact: evdi-dkms fail to build on Focal with the linux-hwe-5.8 kernel.

Fix: Use version 1.7.0+dfsg-1ubuntu1 instead of 1.6.0+dfsg. That would bring it in line with the version used in groovy.

Testcase: Attempt to build 1.6.0+dfsg - observe that it fails (drm/drmP.h: no such file or directory). Create a new package using the groovy source package, confirm that it builds and installs successfully. Furthermore, confirmed that I was able to successfully manually insmod all the .ko files that were built.

Regression potential: Technically this doesn't work on the 5.8 hwe kernel in focal right now, so it cannot be any more broken than it currently is. The 1.7.0+dfsg-1ubuntu1 version is identical to the one currently used in groovy.

For this updated source, package, I have compiled it for the 5.4 kernel on Focal, and confirmed that:
 a) The module now builds properly on 5.4
 b) The module is loadable into the 5.4 kernel (without errors or warnings)

The upstream evdi project itself is compatible up to kernel 5.9:

https://github.com/DisplayLink/evdi/commit/83046d3e6e55de2069bada70894c633c090f7ddc

So I suppose there is a potential for regression on the 5.4 kernel, and that would likely indicate an upstream bug in evdi.

[Khaled El Mously (kmously)]

Source package:

https://kernel.ubuntu.com/~kmously/evdi-1.7/

[Khaled El Mously (kmously)]

Debdiff between 1.7.0+dfsg-1ubuntu1 and 1.7.0+dfsg-1ubuntu1~20.04.1

[Khaled El Mously (kmously)]

debdiff between 1.6.0+dfsg-1 and 1.7.0+dfsg-1ubuntu1~20.04.1

[Robie Basak (racb)]

> Regression potential: Technically this doesn't work on the 5.8 hwe kernel in focal right now, so it cannot be any more broken than it currently is.

What about the 5.4 kernel that shipped with Focal? Wouldn't users who originally installed 20.04 at the time of release have this one? Is this package completely broken for this set of users, or is it possible that they are using it, and thus we have to consider the risk of regression them with your proposed bump of 1.6.0 to 1.7.0?

[Khaled El Mously (kmously)]

@Robie,

For this updated source, package, I have compiled it for the 5.4 kernel on Focal, and confirmed that:
 a) The module now builds properly on 5.4
 b) The module is loadable into the 5.4 kernel (without errors or warnings)

The upstream evdi project itself is compatible up to kernel 5.9:

https://github.com/DisplayLink/evdi/commit/83046d3e6e55de2069bada70894c633c090f7ddc

So I suppose there is a potential for regression on the 5.4 kernel, and that would likely indicate an upstream bug in evdi.

[Khaled El Mously (kmously)]

..however, since the upstream project still supports 5.4 I expect potential for regression to be on the low side

[Łukasz Zemczak (sil2100)]

I think this is fine, but please be sure to test this on both the 5.8 and 5.4 focal kernel as part of verification. We don't want to accidentally regress existing users, as per Robie's comment.

[Łukasz Zemczak (sil2100)]

Actually, hm, the package in the queue seems to have one issue: I see that the in debian/control the debhelper-compat dep is set to 13. From what I know focal only provides debhelper 12 right now. I think we'll need this to be bumped down to debhelper-compat (= 12).
Let me reject the package for now.

[Łukasz Zemczak (sil2100)]

An upload of evdi to focal-proposed has been rejected from the upload queue for the following reason: "See bug comment, debhelper-compat level might need to be decreased to upload for focal.".

[Kleber Sacilotto de Souza (kleber-souza)]

I have fixed the debhelper-compat dependency and prepared a new package for upload.

The source files are at:
https://kernel.ubuntu.com/~ksouza/lp1904654/

I have built the packages on a PPA:
https://launchpad.net/~kleber-souza/+archive/ubuntu/snap-test/+sourcepub/11932653/+listing-archive-extra

Will attach the debdiff's next.

[Kleber Sacilotto de Souza (kleber-souza)]

This is the debdiff between the current version in focal-updates (1.6.0+dfsg-1ubuntu3) and the new proposed version (1.7.0+dfsg-1ubuntu1~20.04.2).

[Kleber Sacilotto de Souza (kleber-souza)]

This is the debdiff between the previous proposed upload (1.7.0+dfsg-1ubuntu1~20.04.1) and the new version with the fix (1.7.0+dfsg-1ubuntu1~20.04.2).

[Brian Murray (brian-murray)]

Hello Khaled, or anyone else affected,

Accepted evdi into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/evdi/1.7.0+dfsg-1ubuntu1~20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted evdi (1.7.0+dfsg-1ubuntu1~20.04.2) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

evdi/unknown (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#evdi

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Kleber Sacilotto de Souza (kleber-souza)]

Hi,

I can confirm that evdi 1.7.0+dfsg-1ubuntu1~20.04.2 in focal-proposed fixes the reported issue. The evdi module can be compiled and loaded on Focal with both 5.4 and 5.8 kernels.

$ dkms status
evdi, 1.7.0+dfsg, 5.4.0-59-generic, x86_64: installed
evdi, 1.7.0+dfsg, 5.8.0-34-generic, x86_64: installed

The autopkgtest tests were also successful with linux-hwe-5.8 kernel:

amd64 - https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/e/evdi/20210105_115522_7e0f6@/log.gz
arm64 - http://autopkgtest.ubuntu.com/packages/e/evdi/focal/arm64/
ppc64el - https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/ppc64el/e/evdi/20210105_115721_b934a@/log.gz
s390x - https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/s390x/e/evdi/20210105_115329_7e0f6@/log.gz

[Launchpad Janitor (janitor)]

This bug was fixed in the package evdi - 1.7.0+dfsg-1ubuntu1~20.04.2

---------------
evdi (1.7.0+dfsg-1ubuntu1~20.04.2) focal; urgency=medium

  * Fixed debhelper-compat dependency for focal (LP: #1904654)

 -- Kleber Sacilotto de Souza <email address hidden> Thu, 17 Dec 2020 10:17:41 +0100

[Andy Whitcroft (apw)]

The verification of the Stable Release Update for evdi has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.