SmartEvidence framework Institution "All" option cannot be saved in non-english

Bug #1902146 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
19.10
Fix Released
High
Unassigned
20.04
Fix Released
High
Unassigned
20.10
Fix Released
High
Unassigned
21.04
Fix Released
High
Robert Lyon

Bug Description

Currently the saving and populating of the Institution field via json is only set up to handle it in English, eg 'all' but not other languages.

Will need to do the checking / saving of institution value translated from what the form provides to English
And then do the returning of data to form have the field from English to set language again

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11411

Revision history for this message
Robert Lyon (robertl-9) wrote :

To test:

1) Have an institution with their language set to something like German or Japanese

2) Check that the language pack has translated the 'all' by going to Admin -> Extensions -> Smart Evidence page and selecting the Editor tab

3) You should see the Institution field set to 'all' but in the language chosen

4) Try saving the form

Before patch an error

After patch it should save fine and that the value saved in framework table in db should have 'all' for institution

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11411
Committed: https://git.mahara.org/mahara/mahara/commit/6a917afde154770d44536dd1344b466cab0ba3d6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6a917afde154770d44536dd1344b466cab0ba3d6
Author: Robert Lyon <email address hidden>
Date: Fri Oct 30 10:53:35 2020 +1300

Bug 1902146: Handling translated 'all' for institution in smart evidence editor

Currently we only handle English on the backend. We need to handle
other languages too

Change-Id: Ic3a82b683b2184b93404a7a7cd3744ed421278f1
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11416

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11417

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11418

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11418
Committed: https://git.mahara.org/mahara/mahara/commit/4045714e0523af24eef27b34f2257b419eecf715
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 4045714e0523af24eef27b34f2257b419eecf715
Author: Robert Lyon <email address hidden>
Date: Fri Oct 30 10:53:35 2020 +1300

Bug 1902146: Handling translated 'all' for institution in smart evidence editor

Currently we only handle English on the backend. We need to handle
other languages too

Change-Id: Ic3a82b683b2184b93404a7a7cd3744ed421278f1
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6a917afde154770d44536dd1344b466cab0ba3d6)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11417
Committed: https://git.mahara.org/mahara/mahara/commit/a5e94559094326fb5af943004c934512286bf37d
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit a5e94559094326fb5af943004c934512286bf37d
Author: Robert Lyon <email address hidden>
Date: Fri Oct 30 10:53:35 2020 +1300

Bug 1902146: Handling translated 'all' for institution in smart evidence editor

Currently we only handle English on the backend. We need to handle
other languages too

Change-Id: Ic3a82b683b2184b93404a7a7cd3744ed421278f1
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6a917afde154770d44536dd1344b466cab0ba3d6)

no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.