signond causes qprocess crash

Bug #1901609 reported by Sandro
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
signon (Ubuntu)
Fix Released
Undecided
Rik Mills
Focal
Fix Released
Undecided
Rik Mills
Groovy
Fix Released
Undecided
Rik Mills
Hirsute
Fix Released
Undecided
Rik Mills

Bug Description

[Impact]

Without the patch users are unable to add google accounts because signond crashes.
This prevents users from using KDE's online accounts feature for google.
The fix for this is to drop the no-rtti compile flag as qprocess relies on type info. This has no real downside for the user as it simply brings in type info.

[Test Case]

- in a plasma session
- install kio-gdrive
- run `systemsettings5 kcm_kaccounts`
- add a new account
- click on google
- wait for login window to appear
- signond shouldn't be crashing

[Where problems could occur]

Cannot think of any. It simply adds type info to the objects. Also upstream has rtti disabled for months and I'm not aware of any problems.

[Other Info]

This is a fairly grave issue as far as user experience is concerned.

----

I'm reporting this bug upstream from where I found it, since I've learned that the signond package in KDE Neon is sourced from Ubuntu focal.

This was found in signon (signond_8.59+17.10.20170606-0ubuntu2_amd64) from Focal Fossa

Steps to reproduce:

1. Install KDE Plasma and qt 5.15.0 on Ubuntu focal base (IE: KDE Neon)
2. Install the kaccounts integration and kio-gdrive packages.
3. Open System settings and navigate to "Online Accounts"
4. Press "+ Add New Account"
5. Select "Google"

Observed behaviour:

- Window that would ask for authentication fails to load, and Online Accounts goes back to overview
- system logs show a segfault in libqt5core.so which can be traced to a failure in qporcess, casued by signond (see links for further details)

Expected behaviour:
- New window opens with a webview where Google authentication credentials can be posted.
- When qprocess runs it does not crash.

Further reference information at the following links:

1. Bug in KDE Neon: https://bugs.kde.org/show_bug.cgi?id=426034

3. Relevant MR (Since merged) in signond: https://gitlab.com/accounts-sso/signond/-/merge_requests/27

Revision history for this message
Zaileion (zaileion) wrote :

I have simply concluded this will never be fixed and telepathy should simply be removed from KDE entirely. Its currently useless and has had the same or similar issues going back to 2015. Further no one wants to assume responsibility for fixing it. There are dozens or more bug reports from here, to reddit, to debian forums to manjaro forums to arch forums to ubuntu forums and on and on. Its never been fixed and now these bugs are closed as fixed in upstream. Which honestly may never actually reach end users. This issue is effecting almost all services including Lync, Google, telegram, Skype, etc. etc. Its also the same in all aur, deb, and rpm based distros

Revision history for this message
Zaileion (zaileion) wrote :

I have posted on debian bug reports and manjaro and arch. Manjaro didn't respond even when I followed up, arch did the same thing simply not responding even with multiple posts and follow ups and debian pointed me to kde bug forums thats why I posted my initial bug report here... seems everyone is passing the buck. Also, the patch in arch did not fix the issue. It is improved as it allows for the Google account to be added but does not allow for messages to be sent, it never connects it says connecting... and never actually connects. The patch also fixed kio-gdrive but didn't fix Skype but I think thats a different package something about "haze". So unless telepathy was actually tried completely one may assume its fixed because the fixed signond allows for a google account to be added and appears at first glance to be working but actual messaging does not work and other accounts still can't be added. So if someone tried it and went as far as to add a Google account and then called it a day without actually trying to send messages and also trying other accounts like Skype and lync and telegram and then after adding the accounts actually sending messages it may appear to that person as fixed but in truth is only slightly improved..

Revision history for this message
Zaileion (zaileion) wrote :

Seriously. Wtf is the reason for a 5 year bug in Ububtu... you guys aren't making enough money to fix stuff? If this was a volunteer system I would be a little less frustrated but Ubuntu gets a pile of dough from many sources and its still not fixed. Unbelieveable!!

description: updated
Changed in signon (Ubuntu Focal):
assignee: nobody → Rik Mills (rikmills)
Changed in signon (Ubuntu Groovy):
assignee: nobody → Rik Mills (rikmills)
Changed in signon (Ubuntu Hirsute):
assignee: nobody → Rik Mills (rikmills)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in signon (Ubuntu Focal):
status: New → Confirmed
Changed in signon (Ubuntu Groovy):
status: New → Confirmed
Changed in signon (Ubuntu):
status: New → Confirmed
Revision history for this message
Rik Mills (rikmills) wrote :

I have tested with the patch applied in this upload to hirsute:

https://launchpad.net/ubuntu/+source/signon/8.59+17.10.20170606-0ubuntu3

That fixes the crash for me.

Changed in signon (Ubuntu Hirsute):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package signon - 8.59+17.10.20170606-0ubuntu3

---------------
signon (8.59+17.10.20170606-0ubuntu3) hirsute; urgency=medium

  * Add ubuntu_01_rtti.diff to remove the no rtti flags as they'd
    break compatibility with QProcess (LP: #1901609)
  * Build depend on quilt and integrate into debian/rules. Since this
    this source uses the legacy v1 format we need to manually wire up
    patching instead of having dpkg-source handle it

 -- Harald Sitter <email address hidden> Mon, 23 Nov 2020 13:24:59 +0100

Changed in signon (Ubuntu Hirsute):
status: Fix Committed → Fix Released
Revision history for this message
Harald Sitter (apachelogger) wrote :

Also uploaded to groovy and focal as 8.59+17.10.20170606-0ubuntu2.20.10.1 and 8.59+17.10.20170606-0ubuntu2.20.04.1 respectively

Changed in signon (Ubuntu Focal):
status: Confirmed → In Progress
Changed in signon (Ubuntu Groovy):
status: Confirmed → In Progress
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Sandro, or anyone else affected,

Accepted signon into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/signon/8.59+17.10.20170606-0ubuntu2.20.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in signon (Ubuntu Groovy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-groovy
Changed in signon (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Sandro, or anyone else affected,

Accepted signon into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/signon/8.59+17.10.20170606-0ubuntu2.20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Sandro (sandroid) wrote :

I can confirm that the updated packages work for me. After adding them to my system using -proposed as suggested, I am now able to get the window to open asking for my google credentials when selecting to add a new Google account.

As far as I'm concerned this fixes it for me. Thanks to all for taking the time to fix this :)

Please note, in case people come back here and start conflating issues again - the scope of this fix is *only* to get the web view window where you can enter your Google credentials. It is well known that there were other issues that may come along *after* that, but they are not related to this bug at all. As long as you get the window where you can enter your email address, this bug is fixed.

Revision history for this message
Sandro (sandroid) wrote :

Sorry read the message only partially on my phone at the time. Here is the requisite info:

Tested on Ubuntu 20.04 (KDE Neon, the only way this bug manifests currently, as it only affects systems running Qt >= 5.19.0)

Updated the package and it successfully fixes the bug, using package in proposed channel: 8.59+17.10.20170606-0ubuntu2.20.04.1

Opening SystemSettings/Online Accounts and adding a new Google account now works: A window appears with a web view asking user to submit authentication credentials. I added two accounts, and all worked fine. Removing and re-adding an account also worked. Closing the window without completing workflow and trying again also works. I couldn't think of any other reasonable scenario.

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Harald Sitter (apachelogger) wrote :

Tested 8.59+17.10.20170606-0ubuntu2.20.10.1 on groovy and the test scenario outlined in the description is working now. The auth dialog no longer crashes singond.

tags: added: verification-done verification-done-groovy
removed: verification-needed verification-needed-groovy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package signon - 8.59+17.10.20170606-0ubuntu2.20.10.1

---------------
signon (8.59+17.10.20170606-0ubuntu2.20.10.1) groovy; urgency=medium

  * Add ubuntu_01_rtti.diff to remove the no rtti flags as they'd
    break compatibility with QProcess (LP: #1901609)
  * Build depend on quilt and integrate into debian/rules. Since this
    this source uses the legacy v1 format we need to manually wire up
    patching instead of having dpkg-source handle it

 -- Harald Sitter <email address hidden> Mon, 23 Nov 2020 13:24:59 +0100

Changed in signon (Ubuntu Groovy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for signon has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Sadly I cannot release the focal SRU as it seems that the signon package FTBFS on ppc64el there:

https://launchpad.net/ubuntu/+source/signon/8.59+17.10.20170606-0ubuntu2.20.04.1/+build/20365793

It seems to have built fine previously. Can someone take a look?

Changed in signon (Ubuntu Focal):
status: Fix Committed → Incomplete
Revision history for this message
Rik Mills (rikmills) wrote : Re: [Bug 1901609] Re: signond causes qprocess crash

On 14/12/2020 18:48, Łukasz Zemczak wrote:
> Sadly I cannot release the focal SRU as it seems that the signon package
> FTBFS on ppc64el there:
>
> https://launchpad.net/ubuntu/+source/signon/8.59+17.10.20170606-0ubuntu2.20.04.1/+build/20365793
>
> It seems to have built fine previously. Can someone take a look?
>
> ** Changed in: signon (Ubuntu Focal)
> Status: Fix Committed => Incomplete
>

seems that failed to build without a log, so likely a launchpad 'burp'.
a retry made it build ok

Changed in signon (Ubuntu Focal):
status: Incomplete → Opinion
status: Opinion → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package signon - 8.59+17.10.20170606-0ubuntu2.20.04.1

---------------
signon (8.59+17.10.20170606-0ubuntu2.20.04.1) focal; urgency=medium

  * Add ubuntu_01_rtti.diff to remove the no rtti flags as they'd
    break compatibility with QProcess (LP: #1901609)
  * Build depend on quilt and integrate into debian/rules. Since this
    this source uses the legacy v1 format we need to manually wire up
    patching instead of having dpkg-source handle it

 -- Harald Sitter <email address hidden> Mon, 23 Nov 2020 13:24:59 +0100

Changed in signon (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Kuta Bid (kutabid) wrote :

April 9, 2023

Operating System: Ubuntu 22.04
KDE Plasma Version: 5.27.3
KDE Frameworks Version: 5.104.0
Qt Version: 5.15.8
Kernel Version: 6.2.0-10005-tuxedo (64-bit)
Graphics Platform: X11
Processors: 4 × Intel® Core™ i7-6600U CPU @ 2.60GHz
Memory: 7.5 GiB of RAM
Graphics Processor: Mesa Intel® HD Graphics 520
Manufacturer: Dell Inc.
Product Name: Latitude E7470

- Bug still exists

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.