needs to depend on tcl (not just tcl8.6)

Bug #1901318 reported by cmeerw
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
usb-modeswitch (Ubuntu)
Fix Released
High
Sebastien Bacher
Groovy
Fix Released
Undecided
Unassigned

Bug Description

* Impact

the usb-modeswitch dispatcher script fails to start on the default installation because it uses tclsh unversioned while we depends on tcl8.6

* Test Case

$ /usr/sbin/usb_modeswitch_dispatcher

shouldn't bail out on an interpreter error

(or better, test that plugging an usb modem is correctly handled)

* Regression potential

The script was bailing out due to a missing intepreter before so the code wasn't tested, it's possible that it triggers errors or could interact with the system in some way. The dispatcher reacts to udev events when an usb modem is connected, so try to use one of those and make sure that there is no negative effect (and if possible that the modem gets correctly handled)

--------------------------

the package currently depends on tcl8.6, but /usr/sbin/usb_modeswitch_dispatcher actually requires /usr/bin/tclsh which isn't provided by tcl8.6, so it likely would need to depend on something like tcl (= 8.6)

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report

Changed in usb-modeswitch (Ubuntu):
importance: Undecided → High
status: New → Fix Committed
Changed in usb-modeswitch (Ubuntu):
assignee: nobody → Sebastien Bacher (seb128)
description: updated
Revision history for this message
Josua Dietze (digidietze) wrote :

ALL distributions that I'm familiar with are adding a symlink "/usr/bin/tclsh" to whatever specific version of the shell is included when tcl is installed.

Update: just checked, and the symlink "tclsh" is included with the current tcl package of Debian Sid as well as with the package of Debian Stretch.

@cmeerw, can you try to re-install the tcl package?

Revision history for this message
cmeerw (cmeerw) wrote :

@digidietze you might have misunderstood the report.

It's all working fine if the tcl package is installed, as that package includes the /usr/bin/tclsh symlink. But the usb-modeswitch package does not depend on the tcl package, it only depends on the tcl8.6 package (which doesn't contain a /usr/bin/tclsh symlink).

Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello cmeerw, or anyone else affected,

Accepted usb-modeswitch into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/usb-modeswitch/2.6.1-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in usb-modeswitch (Ubuntu Groovy):
status: New → Fix Committed
tags: added: verification-needed verification-needed-groovy
Revision history for this message
cmeerw (cmeerw) wrote :

tested by uninstalling "tcl" and then installing "usb-modeswitch 2.6.1-1ubuntu2".

usb-modeswitch is working fine now with just "tcl8.6" installed (which is listed as a dependency of usb-modeswitch), but no "tcl" package.

tags: added: verification-done-groovy
removed: verification-needed-groovy
tags: added: verification-done
removed: verification-needed
Revision history for this message
Brian Murray (brian-murray) wrote :

See LP: #1903331 for a possible regression.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for pointing that out Brian, it seems not likely to be a regression but just incorrect tagging, the user reported problems on discourse before the SRU was uploaded but we will check to make sure to do no error

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

By looking at the comments (and comment #20 especially) it looks like this is not caused by this upload. Releasing.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package usb-modeswitch - 2.6.1-1ubuntu2

---------------
usb-modeswitch (2.6.1-1ubuntu2) groovy; urgency=medium

  * debian/patches/0006-versioned-tcl.patch:
    - use the versioned tclsh8.6 interpreter matching the depends
      (lp: #1901318)

 -- Sebastien Bacher <email address hidden> Wed, 28 Oct 2020 17:17:25 +0100

Changed in usb-modeswitch (Ubuntu Groovy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for usb-modeswitch has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package usb-modeswitch - 2.6.1-1ubuntu3

---------------
usb-modeswitch (2.6.1-1ubuntu3) hirsute; urgency=medium

  * debian/control:
    - Depends on tcl rather than tcl8.6 since the unversioned tclsh is the
      one being called (lp: #1901318)

 -- Sebastien Bacher <email address hidden> Wed, 28 Oct 2020 17:10:31 +0100

Changed in usb-modeswitch (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.