Please build the package as upstream does

[Balint Reczey]

[Impact]

 * Upstream would like Ubuntu packages to use the build options closest to upstream's practice.

[Test Case]

 * Check the build logs if the following options are used (-mod=readonly is not needed because the build does not use go mod):
  -ldflags="-s -w -X main.version=$(shell dpkg-parsechangelog -S Version)"

[Where problems could occur]

 * The build options just strip the binary and set the current version. None of those should cause any problem.

[Original Bug Text]

Upstream's build parameters;

override_dh_auto_build:
       dh_auto_build -O--buildsystem=golang -- -ldflags="-s -w -X main.version=$(VERSION)-$(RELEASE)" -mod=readonly

 - Strip the binary
 - Set main.version

(Upstream asked for that.)

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-osconfig-agent - 20200625.00-0ubuntu3

---------------
google-osconfig-agent (20200625.00-0ubuntu3) groovy; urgency=medium

  * debian/patches/: Drop skipping DeepEqual check
  * debian/rules: Build the package as preferred by upstream (LP: #1900897)
    - Strip the binary
    - Set main.version

 -- Balint Reczey <email address hidden> Wed, 21 Oct 2020 21:34:05 +0200

[Liam Hopkins (liamh-google)]

Please also apply this change to the google-guest-agent package

[Balint Reczey (rbalint)]

Committed to the git packaging repository.

[Balint Reczey (rbalint)]

I'd like to land this fix with LP: #1905986 (if the change is needed) and these together would unblock the stable release updates of the package.
@liamh-google Could you please comment on the other bug's open question?

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20200617.00-0ubuntu8

---------------
google-guest-agent (20200617.00-0ubuntu8) hirsute; urgency=medium

  * debian/rules: Build the package as preferred by upstream
    - Strip the binary
    - Set main.version (LP: #1900897)
  * Declare Breaks: on python3-google-compute-engine
    to force conscious removal of the Python libraries that are not maintained
    and this package make obsolete. (LP: #1905986)

 -- Balint Reczey <email address hidden> Wed, 13 Jan 2021 13:24:40 +0100

[Łukasz Zemczak (sil2100)]

Hello Balint, or anyone else affected,

Accepted google-guest-agent into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/google-guest-agent/20201217.02-0ubuntu1~20.10.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Joshua Powers (powersj)]

Build logs from Groovy package in proposed:
https://launchpadlibrarian.net/517240236/buildlog_ubuntu-groovy-amd64.google-osconfig-agent_20210112.00-0ubuntu1~20.10.0_BUILDING.txt.gz

Verify the build flags:

dh_auto_build -O--buildsystem=golang -- -ldflags="-s -w -X main.version=20210112.00-0ubuntu1~20.10.0"

Which matches the test case above. Marking verification-done.

[Launchpad Janitor (janitor)]

This bug was fixed in the package google-guest-agent - 20201217.02-0ubuntu1~20.10.0

---------------
google-guest-agent (20201217.02-0ubuntu1~20.10.0) groovy; urgency=medium

  * Backport to Groovy

google-guest-agent (20201217.02-0ubuntu1) hirsute; urgency=medium

  * New upstream release (LP: #1911448)
  * debian/watch: Fix version handing in the download URL
  * Update vendored files

google-guest-agent (20200617.00-0ubuntu8) hirsute; urgency=medium

  * debian/rules: Build the package as preferred by upstream
    - Strip the binary
    - Set main.version (LP: #1900897)
  * Declare Breaks: on python3-google-compute-engine
    to force conscious removal of the Python libraries that are not maintained
    and this package make obsolete. (LP: #1905986)

google-guest-agent (20200617.00-0ubuntu7) hirsute; urgency=medium

  * No-change rebuild using new golang

 -- Balint Reczey <email address hidden> Wed, 13 Jan 2021 20:43:31 +0100

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for google-guest-agent has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.