rtl8812au-dkms 4.3.8.12175.20140902+dfsg-0ubuntu12: rtl8812au kernel module failed to build

[Nezar Tarek]

[Impact]
Ubuntu constantly tell me that there is an error in this package

ProblemType: Package
DistroRelease: Ubuntu 20.04
Package: rtl8812au-dkms 4.3.8.12175.20140902+dfsg-0ubuntu12
Uname: Linux 5.8.0-050800-generic x86_64
ApportVersion: 2.20.11-0ubuntu27.8
Architecture: amd64
CasperMD5CheckResult: skip
DKMSKernelVersion: 5.4.0-51-generic
Date: Fri Oct 16 20:49:10 2020
DuplicateSignature: dkms:rtl8812au-dkms:4.3.8.12175.20140902+dfsg-0ubuntu12:/var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build/include/rtw_security.h:238:8: error: redefinition of ‘struct sha256_state’
InstallationDate: Installed on 2020-08-02 (75 days ago)
InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
PackageArchitecture: all
PackageVersion: 4.3.8.12175.20140902+dfsg-0ubuntu12
Python3Details: /usr/bin/python3.8, Python 3.8.5, python3-minimal, 3.8.2-0ubuntu2
PythonDetails: N/A
RelatedPackageVersions:
 dpkg 1.19.7ubuntu3
 apt 2.0.2ubuntu0.1
SourcePackage: rtl8812au
Title: rtl8812au-dkms 4.3.8.12175.20140902+dfsg-0ubuntu12: rtl8812au kernel module failed to build
UpgradeStatus: No upgrade log present (probably fresh install)

[Test Case]
Build rtl8812au-dkms package and load module

Verified builds and loads on focal 5.4 and 5.8

[Build Errors]
#1

 CC [M] /var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build/os_dep/linux/ioctl_cfg80211.o
/var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build/os_dep/linux/ioctl_cfg80211.c:6230:3: error: ‘struct cfg80211_ops’ has no member named ‘mgmt_frame_register’
 6230 | #elif (LINUX_VERSION_CODE>=KERNEL_VERSION(2,6,34) && LINUX_VERSION_CODE<=KERNEL_VERSION(2,6,35))
      g| ^~~~~~~~~~~~~~~~~~~
/var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build/os_dep/linux/ioctl_cfg80211.c:6230:25: error: initialization of ‘int (*)(struct wiphy *, struct wireless_dev *, u64)’ {aka ‘int (*)(struct wiphy *, struct wireless_dev *, long long unsigned int)’} from incompatible pointer type ‘void (*)(struct wiphy *, struct wireless_dev *, u16, bool)’ {aka ‘void (*)(struct wiphy *, struct wireless_dev *, short unsigned int, _Bool)’} [-Werror=incompatible-pointer-types]
 6230 | #elif (LINUX_VERSION_CODE>=KERNEL_VERSION(2,6,34) && LINUX_VERSION_CODE<=KERNEL_VERSION(2,6,35))
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build/os_dep/linux/ioctl_cfg80211.c:6230:25: note: (near initialization for ‘rtw_cfg80211_ops.mgmt_tx_cancel_wait’)
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:290: /var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build/os_dep/linux/ioctl_cfg80211.o] Error 1
make[1]: *** [Makefile:1780: /var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.8.0-25-generic'
make: *** [Makefile:1457: modules] Error 2
                                                                                       161,1 Bot

#2
  |
In file included from /var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build/include/drv_types.h:82,
                 from /var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build/core/rtw_br_ext.c:32:
/var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build/include/rtw_security.h:238:8: error: redefinition of ‘struct sha256_state’
  238 | struct sha256_state {
      | ^~~~~~~~~~~~
In file included from ./include/linux/filter.h:23,
                 from ./include/net/sock.h:59,
                 from ./include/net/inet_sock.h:22,
                 from ./include/net/ip.h:27,
                 from /var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build/core/rtw_br_ext.c:24:
./include/crypto/sha.h:84:8: note: originally defined here
   84 | struct sha256_state {
      | ^~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:290: /var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build/core/rtw_br_ext.o] Error 1
make[1]: *** [Makefile:1780: /var/lib/dkms/rtl8812au/4.3.8.12175.20140902+dfsg/build] Error 2
make[1]: Leaving directory '/usr/src/linux-headers-5.8.0-25-generic'
make: *** [Makefile:1457: modules] Error 2
                                                                                       329,1 Bot

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Kelsey Steele (kelsey-steele)]

Updated debdiff. debdiff now updates the focal rtl8812au-dkms package to match version 4.3.8.12175.20140902+dfsg-0ubuntu13. Patches are unchanged. Version name updated to 4.3.8.12175.20140902+dfsg-0ubuntu13~20.04.1

[Łukasz Zemczak (sil2100)]

Hello Nezar, or anyone else affected,

Accepted rtl8812au into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/rtl8812au/4.3.8.12175.20140902+dfsg-0ubuntu13~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

Hi,

I confirm that rtl8812au-dkms kernel modules can be built and loaded in Focal with both linux 5.4 and linux-hwe 5.8 kernels:

$ dkms status
rtl8812au, 4.3.8.12175.20140902+dfsg, 5.4.0-58-generic, x86_64: installed
rtl8812au, 4.3.8.12175.20140902+dfsg, 5.8.0-34-generic, x86_64: installed

I have also triggered ADT tests with linux-hwe-5.8 and they completed successfully:

amd64 - https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/r/rtl8812au/20201216_104722_ed159@/log.gz
arm64 - https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/arm64/r/rtl8812au/20201216_105925_ed159@/log.gz

[Launchpad Janitor (janitor)]

This bug was fixed in the package rtl8812au - 4.3.8.12175.20140902+dfsg-0ubuntu13~20.04.1

---------------
rtl8812au (4.3.8.12175.20140902+dfsg-0ubuntu13~20.04.1) focal; urgency=medium

  * Linux 5.8 compatibility. (LP: #1900180)
    - debian/patches/5.8-kernel-compatibility.patch
    - debian/patches/LINUX-5.8-rename-struct-sha256-to-rtl_sha256-and-ret.patch

 -- Kelsey Skunberg <email address hidden> Sun, 15 Nov 2020 22:18:57 +0000

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for rtl8812au has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.