lime-forensics-dkms: build error in focal with new kernel linux-hwe.5.8

[Andrea Righi]

[Impact]

Building this module against the new linux-hwe-5.8 returns the following error:

/var/lib/dkms/lime-forensics/1.9-1/build/tcp.c: In function ‘setup_tcp’:
/var/lib/dkms/lime-forensics/1.9-1/build/tcp.c:82:9: error: implicit declaration of function ‘kernel_setsockopt’; did you mean ‘kernel_getsockname’? [-Werror=implicit-function-declaration]
   82 | r = kernel_setsockopt(control, SOL_SOCKET, SO_REUSEADDR, (char *)&opt, sizeof (opt));
      | ^~~~~~~~~~~~~~~~~
      | kernel_getsockname

[Test case]

$ sudo apt install lime-forensics-dkms

Build error(s) is(are) reported in make.log.

[Fix]

Fix by importing a patch from the same dkms module in groovy to use sock_set_reuseaddr() with kernel 5.8 (and keep using kernel_setsockopt() with kernels < 5.8).

[Regression potential]

The source code for the 5.4 kernel remains the same, so there is no regression potential. The new changes are all conditionals and they are all applied to the 5.8 kernel.

[Andrea Righi (arighi)]

debdiff reported in attach seems to fix all the build errors with linux-5.8.

[Andy Whitcroft (apw)]

Hello Andrea, or anyone else affected,

Accepted lime-forensics into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/lime-forensics/1.9-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

I can confirm that XXX VVV fixes the build issues with linux 5.8 on Focal while still working with linux 5.4.

$ dkms status
lime-forensics, 1.9-1ubuntu0.1, 5.4.0-55-generic, x86_64: installed
lime-forensics, 1.9-1ubuntu0.1, 5.8.0-30-generic, x86_64: installed

The module can also be successfully loaded on those kernels. I also performed a smoke test with the module, creating a dump of the whole VM memory.

ADT also completed successfully for both linux-generic 5.4 and linux-hwe 5.8:

* linux 5.4:
- amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/l/lime-forensics/20201119_104532_86b93@/log.gz
- arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/arm64/l/lime-forensics/20201119_105125_86b93@/log.gz
- armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/armhf/l/lime-forensics/20201119_111133_05392@/log.gz
- ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/ppc64el/l/lime-forensics/20201119_105323_663d2@/log.gz
- s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/s390x/l/lime-forensics/20201119_104122_663d2@/log.gz

* linux-hwe 5.8:
- amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/l/lime-forensics/20201119_104402_c12ca@/log.gz
- arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/arm64/l/lime-forensics/20201119_104942_692df@/log.gz
- armhf: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/armhf/l/lime-forensics/20201119_105941_692df@/log.gz
- ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/ppc64el/l/lime-forensics/20201119_104450_c12ca@/log.gz
- s390x: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/s390x/l/lime-forensics/20201119_104028_c12ca@/log.gz

[Launchpad Janitor (janitor)]

This bug was fixed in the package lime-forensics - 1.9-1ubuntu0.1

---------------
lime-forensics (1.9-1ubuntu0.1) focal; urgency=medium

  * Linux 5.8 compatibility (LP: #1899742)
    - debian/patches/001_Linux-5.8-Replace-kernel_setsockopt.patch

 -- Andrea Righi <email address hidden> Wed, 14 Oct 2020 07:39:48 +0000

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for lime-forensics has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.