[SRU] Backport button metric changes from groovy to focal

[Frederik Feichtmeier]

[Impact]

 * Focal users will soon have their yaru themes mismatched in snaps and debs

 * yaru-theme-gtk includes changes for button sizes in groovy, gtk-common-themes will be updated with the updated yaru-theme-gtk so groovies debs and snaps look consistent but this will leave focal deb and snaps incosistent, so focals debs also need an update.

 * Backporting the yaru gtk theme from groovy to focal will fix this, the SHELL theme (yaru-theme-gnome-shell) however should NOT be backported, because the gnome shell version is different and thus the JavaScript components of gnome-shell would then not match the theme any more. The icon theme however, can also be backported if wanted

[Test Case]

 * Update gtk-common-themes from https://gitlab.gnome.org/Community/Ubuntu/gtk-common-themes/-/jobs/951794/artifacts/browse in focal and see how gtk debs like nautilus look different in button sizing than snap-store aka ubuntu software

[Regression Potential]

 * no regression potential unless the gnome shell theme is also backported which should NOT happen

[Other Info]

 * The updates were necessary for groovy, because having gtk3 themes with different button sizes than adwaita creates issues with sizes, see https://github.com/ubuntu/yaru/pull/2361 for further issues linked

[Frederik Feichtmeier (feichtmeier)]

Correspongind PR: https://github.com/ubuntu/yaru/pull/2456

[Sebastien Bacher (seb128)]

Marking as fix released since it's not impacting the current serie, a target for focal is going to be added once the SRU is accepted

[Łukasz Zemczak (sil2100)]

Hello Frederik, or anyone else affected,

Accepted yaru-theme into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/yaru-theme/20.04.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Frederik Feichtmeier (feichtmeier)]

Hello Łukasz!
Testing the yaru packages from this pocket right now from proposed in my VM
I can confirm that this "fixes" this "bug" and now

- all buttons in the ubuntu desktop are as big as the upstream, unmodified gnome buttons, so there are no more stretched elements anymore
- there is no difference between the buttons in gtk applications installed from .debs and buttons in gtk applications installed from snaps anymore (currently using gtk-common-themes from edge, I will inform Ken when this SRU is in focal then he will push gtk-common-themes to stable)

dpkg -l | grep yaru
ii yaru-theme-gnome-shell 20.04.10.1 all Yaru GNOME Shell desktop theme from the Ubuntu Community
ii yaru-theme-gtk 20.04.10.1 all Yaru GTK theme from the Ubuntu Community
ii yaru-theme-icon 20.04.10.1 all Yaru icon theme from the Ubuntu Community
ii yaru-theme-sound 20.04.10.1 all Yaru sound theme from the Ubuntu Community

Ataching a screenshot which shows that the issues are fixed

[Launchpad Janitor (janitor)]

This bug was fixed in the package yaru-theme - 20.04.10.1

---------------
yaru-theme (20.04.10.1) focal; urgency=medium

  [ Feichtmeier ]
  * Focal Gtk3: sync button shadows with groovy.
    Reduce button shadow in all states by 0.05

yaru-theme (20.04.10) focal; urgency=medium

  [ Feichtmeier ]
  * Sync gtk3 button metrics with upstream & groovy (LP: #1899731)
    - in groovy we moved away from altering the upstream button sizes, because
      those sizes are sometimes hardcoded in gtk apps, which ends in
      inconsistent button sizes in the desktop (slim beneath big, or vice versa)
      and because it can cause newer gtk3 apps to have a stretched headerbar
    - additionally because gtk-common-themes will receive the updated yaru
      version from groovy this change destroys the chance gtk3 snaps using
      yaru have different button sizes than gtk3 debs using yaru

yaru-theme (20.04.9) focal; urgency=medium

  * debian: Update gbp.conf and control references to ubuntu/focal branch
  * debian/README.sources: add documentation to explain gnome-shell/upstream
  * gnome-shell, Sync with 3.36.6 fixes (LP: #1896334):
    - Use proper path for upstream files
    - Sync with upstream 3.36 branch
    - Sync yaru theme with upstream 3.36.6
    - Sync yaru gresource with gnome 3.36.6
    - Make world clock times tabular

 -- Marco Trevisan (Treviño) <email address hidden> Thu, 05 Nov 2020 16:08:58 +0100

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for yaru-theme has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.