fails to rebuild from source

[dann frazier]

The debian packaging for curtin fails to completely clean the build directory, causing repeated builds to fail:

ubuntu@maas-6-2-3rd-admin-nodes:~/test$ dpkg-source -x curtin_20.1-29-g81144052-0ubuntu1.dsc
gpgv: Signature made Mon Sep 14 16:34:42 2020 UTC
gpgv: using RSA key 0E7290610D2F6DC4D65EA9219A314EC5F470A0AC
gpgv: Can't check signature: No public key
dpkg-source: warning: failed to verify signature on ./curtin_20.1-29-g81144052-0ubuntu1.dsc
dpkg-source: info: extracting curtin in curtin-20.1-29-g81144052
dpkg-source: info: unpacking curtin_20.1-29-g81144052.orig.tar.gz
dpkg-source: info: unpacking curtin_20.1-29-g81144052-0ubuntu1.debian.tar.xz
ubuntu@maas-6-2-3rd-admin-nodes:~/test$ cd curtin-20.1-29-g81144052/
ubuntu@maas-6-2-3rd-admin-nodes:~/test/curtin-20.1-29-g81144052$ dpkg-buildpackage -rfakeroot -uc -us -b > /dev/null 2>&1
ubuntu@maas-6-2-3rd-admin-nodes:~/test/curtin-20.1-29-g81144052$ echo $?
0
ubuntu@maas-6-2-3rd-admin-nodes:~/test/curtin-20.1-29-g81144052$ dpkg-buildpackage -rfakeroot -uc -us -S
dpkg-buildpackage: info: source package curtin
dpkg-buildpackage: info: source version 20.1-29-g81144052-0ubuntu1
dpkg-buildpackage: info: source distribution groovy
dpkg-buildpackage: info: source changed by Paride Legovini <email address hidden>
 dpkg-source --before-build curtin-20.1-29-g81144052
 fakeroot debian/rules clean
dh clean --with=python3
dh: Compatibility levels before 9 are deprecated (level 7 in use)
   dh_auto_clean
dh_auto_clean: Compatibility levels before 9 are deprecated (level 7 in use)
 make -j1 clean
make[1]: Entering directory '/home/ubuntu/test/curtin-20.1-29-g81144052'
rm -rf doc/_build
make[1]: Leaving directory '/home/ubuntu/test/curtin-20.1-29-g81144052'
   dh_clean
dh_clean: Compatibility levels before 9 are deprecated (level 7 in use)
 dpkg-source -b curtin-20.1-29-g81144052
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: warning: Version number suggests Ubuntu changes, but there is no XSBC-Original-Maintainer field
dpkg-source: info: building curtin using existing ./curtin_20.1-29-g81144052.orig.tar.gz
dpkg-source: warning: file curtin-20.1-29-g81144052/.coverage has no final newline (either original or modified version)
dpkg-source: warning: executable mode 0775 of 'build/scripts-3.6/curtin' will not be represented in diff
dpkg-source: error: cannot represent change to curtin/__pycache__/__init__.cpython-36.pyc: binary file contents changed
dpkg-source: error: add curtin/__pycache__/__init__.cpython-36.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to curtin/__pycache__/config.cpython-36.pyc: binary file contents changed
dpkg-source: error: add curtin/__pycache__/config.cpython-36.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to curtin/__pycache__/distro.cpython-36.pyc: binary file contents changed
dpkg-source: error: add curtin/__pycache__/distro.cpython-36.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to curtin/__pycache__/futil.cpython-36.pyc: binary file contents changed
dpkg-source: error: add curtin/__pycache__/futil.cpython-36.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to curtin/__pycache__/gpg.cpython-36.pyc: binary file contents changed
dpkg-source: error: add curtin/__pycache__/gpg.cpython-36.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to curtin/__pycache__/log.cpython-36.pyc: binary file contents changed
dpkg-source: error: add curtin/__pycache__/log.cpython-36.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to curtin/__pycache__/pack.cpython-36.pyc: binary file contents changed
dpkg-source: error: add curtin/__pycache__/pack.cpython-36.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to curtin/__pycache__/paths.cpython-36.pyc: binary file contents changed
dpkg-source: error: add curtin/__pycache__/paths.cpython-36.pyc in debian/source/include-binaries if you want to store the modified binary in the debian tarball
dpkg-source: error: cannot represent change to curtin/__pycache__/storage_config.cpython-36.pyc: binary file contents changed
[...]

[dann frazier (dannf)]

This worked for me:

diff -Nru curtin-20.1-29-g81144052/debian/rules curtin-20.1-29-g81144052/debian/rules
--- curtin-20.1-29-g81144052/debian/rules 2020-09-14 15:53:15.000000000 +0000
+++ curtin-20.1-29-g81144052/debian/rules 2020-10-09 14:16:31.000000000 +0000
@@ -20,3 +20,9 @@

 override_dh_auto_test:
  make unittest3
+
+override_dh_auto_clean:
+ -find . -name __pycache__ -exec rm -rf {} \;
+ rm -rf .coverage
+ rm -rf build
+ dh_auto_clean

[Server Team CI bot (server-team-bot)]

This bug is fixed with commit 392c05dd to curtin on branch master.
To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=392c05dd

[Launchpad Janitor (janitor)]

This bug was fixed in the package curtin - 21.1-0ubuntu1

---------------
curtin (21.1-0ubuntu1) hirsute; urgency=medium

  * New upstream release.
    - Release 21.1 [Michael Hudson-Doyle] (LP: #1911841)
    - This adds arm64 compatibility for RH installations [Mark Klein]
    - vmtest: add Hirsute release classes, tool to add vmtest class
      [Ryan Harper]
    - vmtest: fix image-sync after maas URL stream rename
      [Ryan Harper] (LP: #1908543)
    - storage_config: set ptable to vtoc for 'virt' dasds as well as 'ECKD'
      [Michael Hudson-Doyle]
    - install_grub: Fix bootloader-id for RHEL systems, must be redhat
      [Ryan Harper] (LP: #1906543)
    - vmtests: remove LP: #1888726 skip_by_date decorators
    - storage_config: only produce type: dasd actions for ECKD dasds
      [Michael Hudson-Doyle]
    - storage_config: handle some FBA dasd oddities [Michael Hudson-Doyle]
    - apt_config: stop using the deprecated apt-key command
      [Nishanth Aravamudan] (LP: #1892494)
    - allow adding a vtoc partition without a device id [Michael Hudson-Doyle]
    - simplify dasdview parsing code [Michael Hudson-Doyle]
    - fix construction of DasdPartitionTable from fdasd output
      [Michael Hudson-Doyle]
    - Don't install grub if it is already found on CentOS/RHEL
      [Lee Trager] (LP: #1895067)
    - vmtests: Replace newly added Eoan test with Groovy [Ryan Harper]
    - vmtests: test using a disk with RAID partition on it directly in a RAID
      [Michael Hudson-Doyle]
    - fix verification of vtoc partitions [Michael Hudson-Doyle] (LP: #1899471)
    - create an empty vtoc in disk_handler [Michael Hudson-Doyle]
    - remove unused parameters from dasd code [Michael Hudson-Doyle]
    - remove support for calling get_path_to_storage_volume on a dasd action
      [Michael Hudson-Doyle]
    - clear-holders: fix identification of multipath partitions
      [Ryan Harper] (LP: #1900900)
    - vmtests: remove skip_by_dates for now-fixed bcache issue
    - debian/rules: drop PKG_VERSION and UPSTREAM_VERSION [Paride Legovini]
    - deb packaging: fully cleanup directory tree after build
      [Paride Legovini] (LP: #1899698)
    - udevadm_info should use maxsplit=1 instead of maxsplit=2
      [Sergey Bykov] (LP: #1895021)
    - vmtests/multipath-lvm: dont assume device-mapper block names
      [Ryan Harper] (LP: #1898758)
    - vmtest: fix the groovy arm64 subarch [Paride Legovini] (LP: #1898757)
    - tools/curtainer: dearmor gpg key and use apt-key add
      [Ryan Harper] (LP: #1898609)
    - Support imsm external metadata RAID containers
      [Gyorgy Szombathelyi] (LP: #1893661)
    - Drop tools/new-upstream-snapshot [Paride Legovini]

 -- Michael Hudson-Doyle <email address hidden> Fri, 15 Jan 2021 17:07:35 +1300