acpi-call-dkms: proc_create() broken with linux-hwe-5.8

[Andrea Righi]

[Impact]

acpi-call-dkms declares a struct proc_ops that is not compatible with the new 5.8 kernel, causing a build failure with proc_create().

[Test case]

$ sudo apt install acpi-call-dkms

The install fails reporting a build error in the log.

[Fix]

Fix by adding a proper #ifdef block to support also kernels >= 5.8.

[Regression potential]

The code for the 5.4 kernel remains the same, so there is no regression potential. This change is required to properly support the new linux-hwe-5.8 kernel in focal.

[Raphaël Halimi (raph)]

Hi Andrea,

Thanks for spotting the bug and providing a patch. I'm going to prepare a new upload in Debian to include it.

However, I have a question: you say that the incompatibility was introduced in 5.8, but in your patch, the #ifdef block mentions (5, 6, 0) as a condition. Is it a mistake or is it intentional ?

Regards,

--
Raphaël Halimi

[Raphaël Halimi (raph)]

Well, scratch that, the patch is the same as the previous one, it's only intended for focal.

Another question then, why don't you just backport the current version (1.1.0-6) to focal, instead of creating a new patch ?

Regards,

--
Raphaël Halimi

[Andrea Righi (arighi)]

Hi Raphaël,

the 5.8 vs 5.6 is a mistake (or better, the right kernel version to check if 5.6, in the patch description I'm referring to 5.8, because it's the next Ubuntu kernel version >= 5.6). But it would be more correct to always refer to 5.6.

About backporting 1.1.0-6, I was trying to minimize the changes to this module, since I don't want to introduce potential regressions with the 5.4 kernel. I'll do a quick test with 1.1.0-6 w/ the 5.4 kernel, if everything works we can simply update the version of this module to 1.1.0-6 also in focal and avoid re-applying the same patch.

Thanks!

[Andy Whitcroft (apw)]

Hello Andrea, or anyone else affected,

Accepted acpi-call into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/acpi-call/1.1.0-5ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Kleber Sacilotto de Souza (kleber-souza)]

I have verified acpi-call 1.1.0-5ubuntu0.1 from focal-proposed and I can confirm it fixes the compilation issue with hwe-5.8 kernel.

Testcase: installed acpi-call-dkms 1.1.0-5ubuntu0.1 on a Focal system, built and loaded the dkms module with linux-image-5.4.0-52-generic and linux-image-5.8.0-25-generic.

Also re-run ADT tests on amd64/arm64 with linux-meta-hwe-5.8:

amd64:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/amd64/a/acpi-call/20201110_134040_06a34@/log.gz

arm64:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-focal/focal/arm64/a/acpi-call/20201110_134313_a0cc6@/log.gz

[Launchpad Janitor (janitor)]

This bug was fixed in the package acpi-call - 1.1.0-5ubuntu0.1

---------------
acpi-call (1.1.0-5ubuntu0.1) focal; urgency=medium

  * fix proc_ops declaration with linux 5.8 (LP: #1899591)

 -- Andrea Righi <email address hidden> Tue, 13 Oct 2020 08:20:49 +0000

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for acpi-call has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.