Add collection process missing button styles

Bug #1898955 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned

Bug Description

This not a problem in 20.10+

But is a problem in 20.04
See attached image

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11348

Revision history for this message
Robert Lyon (robertl-9) wrote :
Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 20.04.2
importance: Undecided → High
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11348
Committed: https://git.mahara.org/mahara/mahara/commit/c4c8acb531ba665d8c94be1fba6a3dbd063dc66c
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit c4c8acb531ba665d8c94be1fba6a3dbd063dc66c
Author: Robert Lyon <email address hidden>
Date: Thu Oct 8 13:18:51 2020 +1300

Bug 1898955: Collection creation process have correct button styles

Change-Id: Ia8279f236e727e7401dc3746be478cfca5637b1a
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Rebecca Blundell (rjb-dev) wrote :

The above patch fixes this instance of the bug, however there are others.

Tested on Ubuntu 18.04
Firefox
Postgres 10.14
PHP 7.4
Raw and Primary School themes
Mahara 20.04_STABLE

Test steps:
1. Create a collection
2. On the 'Edit collection pages' page (collection/views.php) the 'Next: Edit access/ Cancel' button group has incorrect styling.
(It has "btn-primary submitcancel" classes, but is missing "btn" class.)
3. Load a second instance of Mahara with the fix.
Results:
✔ On the collection/views.php page the styling is correct.
✔ Checking the inspect window shows "btn" class is now present.
PASSED.

4. Load 'Primary school' theme.
5. Click on 'Manage' for collection from P&C page.
Results:
✔ Styling is correct.

6. Look for other instances of "btn-primary submitcancel" without "btn" class
7. Check those for incorrect styling.
Results:
More incorrect styling found. See bug #tbc

Revision history for this message
Rebecca Blundell (rjb-dev) wrote :

Bug report for other incorrect button styling: https://bugs.launchpad.net/mahara/+bug/1899120

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.