Regression memcached servers

[Octavio Jr]

Analising mahara 20.04.1 I see and regression on here : https://github.com/MaharaProject/mahara/blob/20.04_STABLE/htdocs/auth/lib.php#L681

Instead of this

                if (empty($server_version[$host . ':' . $port])) {
                    $is_configured = false;
                }

It should be this :
                if (!empty($server_version[$host . ':' . $port])) {
                    $is_configured = true;
                }

I tried to configured a memcached server and had an erreur as settings memcacheservers weren't set.

In the code since $is_configured is already false, we have to invert the logic to see if a server is configured or not.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11363

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11363
Committed: https://git.mahara.org/mahara/mahara/commit/c6d9850f1915c390126f768c7cd6f65f9ad844c9
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c6d9850f1915c390126f768c7cd6f65f9ad844c9
Author: Octavio Jr <unknown>
Date: Wed Oct 14 12:15:55 2020 +1300

Bug 1898762: Adjusting test for memcached servers

Change-Id: I8a363b1da74f136533584a87178aab38371a910b
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11364

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11364
Committed: https://git.mahara.org/mahara/mahara/commit/f1d45474d2315f3a74f04dde474561851a861e24
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit f1d45474d2315f3a74f04dde474561851a861e24
Author: Octavio Jr <unknown>
Date: Wed Oct 14 12:15:55 2020 +1300

Bug 1898762: Adjusting test for memcached servers

Change-Id: I8a363b1da74f136533584a87178aab38371a910b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c6d9850f1915c390126f768c7cd6f65f9ad844c9)

[Mahara Bot (dev-mahara)]

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11365

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11365
Committed: https://git.mahara.org/mahara/mahara/commit/b1cb3b3b726904496eb049131e5629fa25ea379f
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit b1cb3b3b726904496eb049131e5629fa25ea379f
Author: Octavio Jr <unknown>
Date: Wed Oct 14 12:15:55 2020 +1300

Bug 1898762: Adjusting test for memcached servers

Change-Id: I8a363b1da74f136533584a87178aab38371a910b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c6d9850f1915c390126f768c7cd6f65f9ad844c9)
(cherry picked from commit f1d45474d2315f3a74f04dde474561851a861e24)

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11366

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11366
Committed: https://git.mahara.org/mahara/mahara/commit/40f8911ea175db6fdae896e6847b29d449658b92
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 40f8911ea175db6fdae896e6847b29d449658b92
Author: Octavio Jr <unknown>
Date: Wed Oct 14 12:15:55 2020 +1300

Bug 1898762: Adjusting test for memcached servers

Change-Id: I8a363b1da74f136533584a87178aab38371a910b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c6d9850f1915c390126f768c7cd6f65f9ad844c9)
(cherry picked from commit f1d45474d2315f3a74f04dde474561851a861e24)
(cherry picked from commit b1cb3b3b726904496eb049131e5629fa25ea379f)

[Robert Lyon (robertl-9)]

Thank you Octavio Jr for this report the change has been added to the related branches and will be available in next release