Bulk export not working correctly when doing PDF export

[Robert Lyon]

When the code was first written the PDF export put the .pdf files in the HTML subdir next to the .html pages

But now we separate the HTML and PDF sections so we need to make sure the PDF files are added to the zip files.

To test:

1) Have a few users with a few pages each
2) Go to admin/users/bulkexport.php and select 'PDF' export type
3) Put in the usernames for the three users, 1 per line

Export

Problem 1: the export progress bar doesn't tick up correctly
Problem 2: eventually the zip file is made but only contains the HTML section and not the PDF and export_info directories

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11349

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11350

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11351

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11351
Committed: https://git.mahara.org/mahara/mahara/commit/d6781e3f1afd33cbdc5fd71f609bdf0e257d4c8d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d6781e3f1afd33cbdc5fd71f609bdf0e257d4c8d
Author: Robert Lyon <email address hidden>
Date: Fri Oct 9 09:03:31 2020 +1300

Bug 1898652: Avoid sending pdf browser check in response payload

The download serving for pdf export also sends back the buffer info
for the chrome browser check and therefore errors out the json with
parse error

We can avoid this by clearing the buffer after making the pdfs

Change-Id: I74991a3f80198f4f15e547b7b12c8ee68fd4ec36
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11371

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11371
Committed: https://git.mahara.org/mahara/mahara/commit/00688e774c93feaf4666bc2d1a8bad7420007aa7
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 00688e774c93feaf4666bc2d1a8bad7420007aa7
Author: Robert Lyon <email address hidden>
Date: Fri Oct 9 09:03:31 2020 +1300

Bug 1898652: Avoid sending pdf browser check in response payload

The download serving for pdf export also sends back the buffer info
for the chrome browser check and therefore errors out the json with
parse error

We can avoid this by clearing the buffer after making the pdfs

Change-Id: I74991a3f80198f4f15e547b7b12c8ee68fd4ec36
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit d6781e3f1afd33cbdc5fd71f609bdf0e257d4c8d)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11350
Committed: https://git.mahara.org/mahara/mahara/commit/383039ad13af534588a4fc74ca85b7bf9ce4f8bc
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 383039ad13af534588a4fc74ca85b7bf9ce4f8bc
Author: Robert Lyon <email address hidden>
Date: Fri Oct 9 07:43:37 2020 +1300

Bug 1898652: Only loop over zipping up export files if dir is not empty

Change-Id: I488a8be73fb224ba0677d0e07bd193818cf198f5
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11372

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11372
Committed: https://git.mahara.org/mahara/mahara/commit/371cdb6ff36de642e49a2caccca1fb48b0685388
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 371cdb6ff36de642e49a2caccca1fb48b0685388
Author: Robert Lyon <email address hidden>
Date: Fri Oct 9 07:43:37 2020 +1300

Bug 1898652: Only loop over zipping up export files if dir is not empty

Change-Id: I488a8be73fb224ba0677d0e07bd193818cf198f5
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 383039ad13af534588a4fc74ca85b7bf9ce4f8bc)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11349
Committed: https://git.mahara.org/mahara/mahara/commit/6cacb309ebcd40009fb276b035d29784933dc646
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6cacb309ebcd40009fb276b035d29784933dc646
Author: Robert Lyon <email address hidden>
Date: Thu Oct 8 16:29:45 2020 +1300

Bug 1898652: Getting bulk export to include th PDF directory correctly

Before when doing bulk export for PDF it was generating the HTML first
and zipping it up then making the PDFs

Now it waits to do the zipping up after the PDFs are made and includes
the PDF directory as well

Change-Id: I1850765609b9d5fb6e2c59d18afc04cfd437ae43
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11373

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11373
Committed: https://git.mahara.org/mahara/mahara/commit/6c2f039d4a71e26b20857baf00192d0b412d9437
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 6c2f039d4a71e26b20857baf00192d0b412d9437
Author: Robert Lyon <email address hidden>
Date: Thu Oct 8 16:29:45 2020 +1300

Bug 1898652: Getting bulk export to include th PDF directory correctly

Before when doing bulk export for PDF it was generating the HTML first
and zipping it up then making the PDFs

Now it waits to do the zipping up after the PDFs are made and includes
the PDF directory as well

Change-Id: I1850765609b9d5fb6e2c59d18afc04cfd437ae43
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6cacb309ebcd40009fb276b035d29784933dc646)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11359
Committed: https://git.mahara.org/mahara/mahara/commit/fe307bfa980f71ae66c380881c4ecc7fd4e6e2c0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit fe307bfa980f71ae66c380881c4ecc7fd4e6e2c0
Author: Robert Lyon <email address hidden>
Date: Mon Oct 12 14:42:37 2020 +1300

Bug 1898652: Show progress for bulk exports better

Currently we were only showing the progress for every fifth person
being bulk exported rather than the actual progress of each user being
returned by the export class

These adjustments allow for the exporter itself to return the progress
(like we do on personal export) so we can keep a better track of
progress

Also means we use the same functions / flow as well

Change-Id: I11478ae4e29bf2177b31e14e6c7019babc5fe995
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11374

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11374
Committed: https://git.mahara.org/mahara/mahara/commit/b13d0ba4ad66526e4f796e4b8bc1efdf62f50e17
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit b13d0ba4ad66526e4f796e4b8bc1efdf62f50e17
Author: Robert Lyon <email address hidden>
Date: Mon Oct 12 14:42:37 2020 +1300

Bug 1898652: Show progress for bulk exports better

Currently we were only showing the progress for every fifth person
being bulk exported rather than the actual progress of each user being
returned by the export class

These adjustments allow for the exporter itself to return the progress
(like we do on personal export) so we can keep a better track of
progress

Also means we use the same functions / flow as well

Change-Id: I11478ae4e29bf2177b31e14e6c7019babc5fe995
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit fe307bfa980f71ae66c380881c4ecc7fd4e6e2c0)