Padding in all buttons regressed and is much bigger

[Adolfo Jayme Barrientos]

What it says on the tin.

[Carlo Lobrano (c-lobrano)]

Hi, this is a design decision, please see https://github.com/ubuntu/yaru/pull/2361

[Adolfo Jayme Barrientos (fitojb)]

Nowhere in there says it's design-driven, rather than not wanting anymore
to maintain a conscious small difference with Adwaita, which any good
package maintainer can do indefiniely.

It looks all disproportionate and padded out now. It exacerbates problems
with any GTK-based app that is not a toy with two features, like
LibreOffice. And the rationale in that PR is at best vague. It has no
concrete examples of any UI that the previous version of the theme broke.

El dv., 2 d’oct. 2020, 2:55, Carlo Lobrano <email address hidden> va
escriure:

> Hi, this is a design decision, please see
> https://github.com/ubuntu/yaru/pull/2361
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1898141
>
> Title:
> Padding in all buttons regressed and is much bigger
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/yaru-theme/+bug/1898141/+subscriptions
>

[Frederik Feichtmeier (feichtmeier)]

Hello everyone, this is not a design decision but a fix for many padding issues in apps across the desktop we've had with the slimmer padding.

A design decision was to use the small padding in the beginning of yaru. Which sadly doesn't work even after we've put the metric vars into adwaita, because noone is using them.
We can't fix the padding from our side. Because apps use the upstream padding for custom widgets which we can not theme.
They literally look it up in adwaita, then reapply it in their in app CSS which we cannot always overwrite.
But the pr Carlo linked links to the issues which have pictures in it.

[Frederik Feichtmeier (feichtmeier)]

To be concrete

1) there is the "button" widget in gtk. You can style it in your global css like Adwaita or Yaru by styling button { padding: ... ; }
Sometimes gtk apps use custom widgets that are either not buttons, or their styling is styled in the IN-APP css. This means that often we are locked out. The gtk devs can decide if their styling can be overwritten by the global css theme or not. Sadly, often you can NOT overwrite it in the global css. So gtk app devs use a custom widget and LOOK up the exact padding (in pixels or em) in the Adwaita upstream gtk, because this is their reference. Then they put this exact padding in their in-app css and stuff like this is happening:
https://github.com/ubuntu/yaru/issues/2360
https://github.com/ubuntu/yaru/issues/2357

This also means, that everytime a gtk app introduces a new widget that is not covered by the global upstream CSS theme (which yaru copies 90%, except colors and the dark headerbar), a different padding than the upstream padding automatically breaks the app (and only if the app devs allows it, you can overwrite it).

2) I hope you do not misunderstand the current problem with gnome-clocks and gnome-web having a completely stretched headerbar, this happens with and without slim or adwaita padding.

Also please open such discussion issues on github. This is the wrong place.

[Adolfo Jayme Barrientos (fitojb)]

Then how is the Arc theme able to do it correctly?

[Carlo Lobrano (c-lobrano)]

Could you pleas add some more information?

> It looks all disproportionate and padded out now.

What's the system and application versions?

- gnome gtk
- yaru
- libhandy

Could you also add pictures of both the issue and how Arc handles it?

[Frederik Feichtmeier (feichtmeier)]

As described, this is also not only a problem of libhandy, but also all buttons that have a hardcoded (adwaita) padding anywhere in the system. Screenshots are attached here: https://github.com/ubuntu/yaru/issues/2360