Choosing details in image gallery opens a blank modal

[Rebecca Blundell]

Using QA Mahara with the following settings on Windows:
PHP 7.4
Postgres 10.9
Skins enabled
Individual themes enabled
Pre-populated data
Maroon theme

Also exists in master on Ubuntu 18.10 and postgres with Ocean theme

Steps:
As a person with a page, add an image gallery with 5 images.
Save the page and display it.
Click the magnifying glass icon and the resulting details icon

Expected:
A modal appears with details of the image gallery block

Actual:
A blank modal appears

[Rebecca Blundell (rjb-dev)]

I have done some more investigation and confirmed this as a regression:
In 20.04_STABLE the modal opens with the images and download links (see screenshot).

Inspecting the html shows no difference, but the request repsonse from opening the modal shows the following console error in 20.10:

1 request
277 B / 789 B transferred
Finish: 38 ms

error true
error_number 400
error_name "ParameterException"
error_class "ParameterException"
error_message "The 'artefactid' parameter is not an integer"
error_rendered "A required parameter is missing or malformed\n\nThe 'artefactid' parameter is not an integer"

compared with a working response below:

1 request
8.74 KB / 9.30 KB transferred
Finish: 77 ms

error false
message Object { title: "Placeholder", html: "\n\n\n\n<div id=\"commentfiles\" class=\"folder-card\">\n \n <h4 class=\"sr-only\">\n Folder contents:\n </h4>\n\n <div class=\"fullwidth file-download-list\">\n <ul class=\"list-group\">\n \n <li class=\"filedownload-item list-group-item\">\n <a class=\"modal_link\" title=\"405078_tumannost_krasnaya_xabbl_teleskop_1680x1050_(www.GdeFon.ru).jpg\" data-toggle=\"modal-docked\" data-target=\"#configureblock\" href=\"#\" data-blockid=\"83\" data-ar…itle=\"Download image [www.imagesplitter.net](1).jpeg [19.2K]\"></span>\n <span class=\"sr-only\">Download image [www.imagesplitter.net](1).jpeg [19.2K]</span>\n </a>\n \n </li>\n \n </ul>\n </div>\n \n \n</div>\n\n<script>\n jQuery('#configureblock .modal_link').off('click');\n jQuery('#configureblock .modal_link').on('click', function(e) {\n open_modal(e);\n toggleDetailsBtn();\n });\n</script>\n", message: "" }
message ""
title "Placeholder"
html "\n\n\n\n<div id=\"commentfiles\" class=\"folder-card\">\n \n <h4 class=\"sr-only\">\n Folder contents:\n </h4>\n\n <div class=\"fullwidth file-download-list\">\n <ul class=\"list-group\">\n \n <li class=\"filedownload-item list-group-item\">\n <a class=\"modal_link\" title=\"405078_tumannost_krasnaya_xabbl_teleskop_1680x1050_(www.GdeFon.ru).jpg\" data-toggle=\"modal-docked\" data-target=\"#configureblock\" href=\"#\" data-blockid=\"83\" data-ar…itle=\"Download image [www.imagesplitter.net](1).jpeg [19.2K]\"></span>\n <span class=\"sr-only\">Download image [www.imagesplitter.net](1).jpeg [19.2K]</span>\n </a>\n \n </li>\n \n </ul>\n </div>\n \n \n</div>\n\n<script>\n jQuery('#configureblock .modal_link').off('click');\n jQuery('#configureblock .modal_link').on('click', function(e) {\n open_modal(e);\n toggleDetailsBtn();\n });\n</script>\n"
returnCode 0

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11315

[Rangi Daymond (rangid)]

Catalyst QA Tested - PASSED
Environment: local Mahara instance - master plus patch set 1
Platform: Win10-Chrome with Themes: Maroon, Primary school & Raw

Steps as above however, used an imported folder that has 12 differently sized images in it.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11315
Committed: https://git.mahara.org/mahara/mahara/commit/e5ef210e101275ff154ec69374063fa18018736b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e5ef210e101275ff154ec69374063fa18018736b
Author: Lisa Seeto <email address hidden>
Date: Thu Oct 1 15:13:50 2020 +1300

Bug 1897829: Choosing details in image gallery opens a blank modal

- check if artefact isset
- only pass through artefactid if it exists

Change-Id: I65f70a7fffffd938646bac257cc0a461514115a2
Signed-off-by: Lisa Seeto <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11340

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11340
Committed: https://git.mahara.org/mahara/mahara/commit/5d1639dc14d9e786c081a82aae12bb1a5e723333
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit 5d1639dc14d9e786c081a82aae12bb1a5e723333
Author: Lisa Seeto <email address hidden>
Date: Thu Oct 1 15:13:50 2020 +1300

Bug 1897829: Choosing details in image gallery opens a blank modal

- check if artefact isset
- only pass through artefactid if it exists

Change-Id: I65f70a7fffffd938646bac257cc0a461514115a2
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit e5ef210e101275ff154ec69374063fa18018736b)