[SRU] Persistent dataset print strangely

Bug #1897565 reported by Didier Roche-Tolomelli
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
zsys (Ubuntu)
Fix Released
Medium
Didier Roche-Tolomelli
Focal
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
 * When running When I run zsysctl show --full, the output of persistent datasets is garbagled, like:
Persistent Datasets:
                        - &{rpool/usr/local %!!(MISSING)s(bool=false) {/usr/local on %!!(MISSING)s(bool=true) %!!(MISSING)s(bool=false) %!!(MISSING)s(int=0) {inherited }} [] {%!!(MISSING)s(*zfs.Dataset=&{0x1fab700 1 map[1:{1594525151 none} 6:{yes none} 13:{/usr/local inherited} 27:{rpool/usr/local none} 28:{on default}] []})}}
                        - &{rpool/var/games %!!(MISSING)s(bool=false) {/var/games on %!!(MISSING)s(bool=true) %!!(MISSING)s(bool=false) %!!(MISSING)s(int=0) {inherited }} [] {%!!(MISSING)s(*zfs.Dataset=&{0x1b96680 1 map[1:{1594525151 none} 6:{yes none} 13:{/var/games inherited} 27:{rpool/var/games none} 28:{on default}] []})}}
                        - &{rpool/var/mail %!!(MISSING)s(bool=false) {/var/mail on %!!(MISSING)s(bool=true) %!!(MISSING)s(bool=false) %!!(MISSING)s(int=0) {inherited }} [] {%!!(MISSING)s(*zfs.Dataset=&{0x1beff10 1 map[1:{1594525151 none} 6:{yes none} 13:{/var/mail inherited} 27:{rpool/var/mail none} 28:{on default}] []})}}

[Test Case]
 * After installing new version, run zsysctl show --full and check the output of persistent datasets
Those should be of the form:
Persistent Datasets:
  - rpool/boot/grub

[Regression Potential]
 * The code impact is on the output formatting, which then can be less readable than today.
 * Note that i18n is impacted (due to the \t which was invalid here), but in practice, this string isn’t translated.

Changed in zsys (Ubuntu Bionic):
importance: Undecided → Medium
Changed in zsys (Ubuntu):
importance: Undecided → Medium
assignee: nobody → Didier Roche (didrocks)
Changed in zsys (Ubuntu Bionic):
assignee: nobody → Didier Roche (didrocks)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zsys - 0.5.2

---------------
zsys (0.5.2) groovy; urgency=medium

  * Fix /boot/subdataset now being considered as persistent datasets
    (LP: #1897563)
  * Fix persistent dataset printing (LP: #1897565)

 -- Didier Roche <email address hidden> Mon, 28 Sep 2020 14:39:07 +0200

Changed in zsys (Ubuntu):
status: New → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Didier, or anyone else affected,

Accepted zsys into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zsys/0.4.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in zsys (Ubuntu Focal):
status: New → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Domizio Demichelis (domizio) wrote :

0.4.8 works for me. Thanks.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in zsys (Ubuntu Bionic):
status: New → Confirmed
tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for zsys has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package zsys - 0.4.8

---------------
zsys (0.4.8) focal; urgency=medium

  * Fix /boot/subdataset now being considered as persistent datasets
    (LP: #1897563)
  * Fix persistent dataset printing (LP: #1897565)

 -- Didier Roche <email address hidden> Mon, 28 Sep 2020 14:39:07 +0200

Changed in zsys (Ubuntu Focal):
status: Fix Committed → Fix Released
no longer affects: zsys (Ubuntu Bionic)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.