authentication method not assigned properly

[Cecilia Vela Gurovic]

Have 2 institutions "Primary School" and "University" with only one webservices auth instance each

Have one user account and add to "Primary School" institution

Check the Primary school settings, a new internal auth instance was created (is it expected?)

Add user to "University" institution
Check the "University" institution settings, there still is only one auth instance and is a webservice one
Go back to user settings and set Authentication method to "university: webservice"
save changes

Expected results: after the page refreshes, University institution has only one authentication instance "university: webservice" and the user account is linked to it

Actual result: after the page refreshes, a new authentication instance has been created "university: internal" and the user account has been linked to it

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11266
Committed: https://git.mahara.org/mahara/mahara/commit/a00ddfe1550f0caf1f3df1b10cdeb1595fdcaea0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a00ddfe1550f0caf1f3df1b10cdeb1595fdcaea0
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Sep 14 17:07:56 2020 +1200

Bug 1896564: need to tidy up the user auth instance saving

When a user is switch from 'No institution' to an institution,
the auth instance needs to be updated in the usr table
to be linked to an authentication method from this new institution

Also we should allocate the person with the same type of auth method
if possible, otherwise allocate the top priority auth method

behatnotneeded

Change-Id: I9431c1a5c3f6e6b44972ac14ad644abcb076023e