Comet Lake CPUID family:model:stepping 0x6:a5:2 (6:165:2) is not included

Bug #1896419 reported by Kai-Chuan Hsieh
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
Undecided
Kai-Chuan Hsieh
thermald (Ubuntu)
Fix Released
High
Colin Ian King
Focal
Fix Released
High
Colin Ian King
Groovy
Fix Released
High
Colin Ian King

Bug Description

[Impact]

 * The CPUID is not included, which cause the thermald starts failed.
   Sep 15 17:07:00 ubuntu thermald[1089]: [WARN]Unsupported cpu model, use thermal-conf.xml file or run with --ignore-cpuid-check
   Sep 15 17:07:00 ubuntu thermald[1089]: [ERR]THD engine start failed
   Sep 15 17:07:00 ubuntu systemd[1]: thermald.service: Succeeded.

 * A upstream commit added missing CPUID

https://github.com/intel/thermal_daemon/commit/7f2003ee911dd1c97ff74d2b84c62e10950bc9e0

[Test Case]

On an affected system (Comet Lake):

 * $ systemctl is-active thermald
   active

[Regression Potential]

 * Only new id added, no process or logic adjustment, so no regression risk.

[Other Info]

 * The upstream bug: https://github.com/intel/thermal_daemon/issues/275

Changed in thermald (Ubuntu):
assignee: nobody → Kai-Chuan Hsieh (kchsieh)
no longer affects: groovy
tags: added: oem-priority originate-from-1895776 somerville
description: updated
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

Upload the debdiff for the patch.

description: updated
Changed in oem-priority:
status: New → Incomplete
status: Incomplete → New
Changed in thermald (Ubuntu):
status: New → In Progress
Changed in oem-priority:
assignee: nobody → Kai-Chuan Hsieh (kchsieh)
status: New → In Progress
description: updated
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

The debdiff looks sane, the package seems to be good for SRU upload under the HWE criteria. One question though: this change seems to be missing from groovy. We could, of course, just upload the same change on top of groovy's 2.3-2, but I would prefer not to introduce an Ubuntu delta if not needed. Currently in groovy the package is in sync with Debian - did anyone try getting this change accepted in Debian then and only then later synced to Ubuntu?

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

@sil2100

I'll create MP to Debian.
I'll notify you once my MP is ready.

Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :
Revision history for this message
Colin Ian King (colin-king) wrote :

I'm the maintainer for thermald, I'll upload the fix to groovy and SRU this for focal today.

Revision history for this message
Colin Ian King (colin-king) wrote :

I've uploaded the update for Groovy to debian, it will get sync'd into Ubuntu in the next 24 hours. I've uploaded the fix for Focal to Ubuntu for SRU.

Changed in thermald (Ubuntu Focal):
assignee: nobody → Colin Ian King (colin-king)
status: New → In Progress
status: In Progress → Fix Committed
Changed in thermald (Ubuntu Groovy):
status: In Progress → Fix Committed
Changed in thermald (Ubuntu Focal):
importance: Undecided → High
Changed in thermald (Ubuntu Groovy):
importance: Undecided → High
assignee: Kai-Chuan Hsieh (kchsieh) → Colin Ian King (colin-king)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thermald - 2.3-3

---------------
thermald (2.3-3) unstable; urgency=medium

  * Add Cometlake and Rocketlake CPU models (LP: #1896419)
    [Srinivas Pandruvada]
    - 7f2003ee911d Added Cometlake and Rocketlake CPU models

 -- Colin King <email address hidden> Mon, 21 Sep 2020 16:04:11 +0100

Changed in thermald (Ubuntu Groovy):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Kai-Chuan, or anyone else affected,

Accepted thermald into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/thermald/1.9.1-1ubuntu0.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-focal
Revision history for this message
Leon Liao (lihow731) wrote :

I verified this bug on Dell G5-5500.

$ systemctl is-active thermald
active

$ sudo dpkg -l | grep thermald
ii thermald 1.9.1-1ubuntu0.3 [..skip..]

tags: added: verification-done-focal
removed: verification-needed-focal
Changed in oem-priority:
status: In Progress → Fix Committed
tags: added: verification-done
removed: verification-needed
Revision history for this message
Colin Ian King (colin-king) wrote :

Thanks for verify this.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thermald - 1.9.1-1ubuntu0.3

---------------
thermald (1.9.1-1ubuntu0.3) focal; urgency=medium

  * Add Cometlake and Rocketlake CPU models (LP: #1896419)
    [Srinivas Pandruvada]
    - 7f2003ee911d Added Cometlake and Rocketlake CPU models

 -- Colin King <email address hidden> Mon, 21 Sep 2020 16:04:11 +0100

Changed in thermald (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for thermald has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in oem-priority:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.