Fix problem with sign-off and verification when portfolio is submitted

[Robert Lyon]

These things happen with a submitted collection but maybe they shouldn't
- Owner submits their collection but can still signoff on pages after submission locking.
- Verifier can verify page after submission locking
- Peer/manager can leave draft peer assessment when submitted but can't edit it to make public

[Kristina Hoeppner (kris-hoeppner)]

My preference would be when portfolios have been submitted:

- Owner cannot sign off any more.
- Verifier can still verify the page as in some cases they may only want to do that once the portfolio has been locked for assessment and they know all conditions have been met. The verifier is usually also the formal assessor and thus could combine the two.

Lisa and I had another, deeper look at this in particular along with the sign-off for the peer assessment and decided on the following:

The peer shall not be able to make any changes to their assessment when a page has been submitted. That is along the lines of the current functionality where the peer cannot add, edit, or delete a peer assessment when a portfolio owner signed off on their portfolio.

The sign-off can be regarded as visual queue for 'This portfolio is done, and I am - as portfolio owner - happy as it is.' That includes the peer assessment. We already have this functionality for the combo sign-off and peer assessment. Therefore, when a page is submitted, we shouldn't change that behaviour and allow editing or making public. The peer assessment is part of the portfolio that is to be formally assessed, and therefore shouldn't be changeable.

If a peer needs to be able to make changes, the portfolio can be released -> (sign-off removed ->) peer assessment changed -> (sign-off added -> ) -> submitted.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11215

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11215
Committed: https://git.mahara.org/mahara/mahara/commit/85e04c3462600726c838a076baa9f08d18b6db10
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 85e04c3462600726c838a076baa9f08d18b6db10
Author: Lisa Seeto <email address hidden>
Date: Wed Sep 2 16:53:54 2020 +1200

Bug 1893605: Fix problems with sign-off & verification for submitted portfolio

Added an additional check to see if a portfolio has been submitted
to conditionally restrict peer assessments

Change-Id: Ifef7116805bd8bbe6e9de5d9ee85fca2a4c49a45
Signed-off-by: Lisa Seeto <email address hidden>