libkdynamicwallpaper1-dev doesn't install any header files

[Vlad Zahorodnii]

libkdynamicwallpaper1-dev should come with the following header files

/usr/include/KDynamicWallpaper/KDynamicWallpaperMetaData
/usr/include/KDynamicWallpaper/KDynamicWallpaperReader
/usr/include/KDynamicWallpaper/KDynamicWallpaperWriter
/usr/include/KDynamicWallpaper/KSunPath
/usr/include/KDynamicWallpaper/KSunPosition
/usr/include/KDynamicWallpaper/KSystemClockMonitor
/usr/include/KDynamicWallpaper/kdynamicwallpapermetadata.h
/usr/include/KDynamicWallpaper/kdynamicwallpaperreader.h
/usr/include/KDynamicWallpaper/kdynamicwallpaperwriter.h
/usr/include/KDynamicWallpaper/ksunpath.h
/usr/include/KDynamicWallpaper/ksunposition.h
/usr/include/KDynamicWallpaper/ksystemclockmonitor.h
/usr/include/KDynamicWallpaper/kdynamicwallpaper_export.h

[Vlad Zahorodnii (vladzzag)]

I used https://packages.ubuntu.com/groovy/amd64/libkdynamicwallpaper1-dev/filelist to check the list of files in libkdynamicwallpaper1-dev package.

[Erich Eickmeyer (eeickmeyer)]

Considering you just released a new version and I was planning on upgrading it, I can definitely work on this. This was my first stab at packaging a development library of any kind, so I appreciate this.

[Erich Eickmeyer (eeickmeyer)]

Rather, this was my first stab at packaging a development library that existed as part of a regular application.

[Vlad Zahorodnii (vladzzag)]

The wallpaper plugin project can be viewed as a library and the plugin itself. The library provides an API to read and write dynamic wallpapers.

[Vlad Zahorodnii (vladzzag)]

It looks like libkdynamicwallpaper1 includes files that belong to plasma-wallpaper-dynamic package. Should I file another bug report?

[Erich Eickmeyer (eeickmeyer)]

No, feel free to list those here as well. Your instructions on the github page aren't clear on which files belong where. Debian (and Ubuntu) policy is that all development files must be a separate binary package, even if the source is the same.

While I understand you're an Arch developer and that Arch policies aren't the same, you must know that the KDE organization does target Ubuntu and Debian quite a bit, so I highly recommend documenting these things to avoid this kind of issue in the future.

[Vlad Zahorodnii (vladzzag)]

In comment #5, I was talking about these three files

/usr/lib/x86_64-linux-gnu/qt5/plugins/kpackage/packagestructure/packagestructure_dynamicwallpaper.so
/usr/lib/x86_64-linux-gnu/qt5/qml/com/github/zzag/plasma/wallpapers/dynamic/libplasma_wallpaper_dynamicplugin.so
/usr/lib/x86_64-linux-gnu/qt5/qml/com/github/zzag/plasma/wallpapers/dynamic/qmldir

they belong to plasma-wallpaper-dynamic rather than libkdynamicwallpaper1

[Erich Eickmeyer (eeickmeyer)]

This is now fixed, I'm just waiting on some upload permissions to get sorted before I can get this out the door.

[Vlad Zahorodnii (vladzzag)]

As for documentation, I'm not sure what kind of information should be provided. I've listed all components that can be found in the project [1]. I hope this helps.

[1] https://github.com/zzag/plasma5-wallpapers-dynamic/#components

[Erich Eickmeyer (eeickmeyer)]

Not exactly. Looking at that, it's rather vague, and for someone like me that's not a coder/programmer by any stretch of the imagination and is merely a packager, that doesn't help a whole lot at all. It really needs to be that, and which files belong to which component.

Either way, I just pushed the fix, so this bug will close as soon as it migrates to groovy's repo from proposed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package plasma-wallpaper-dynamic - 3.3.4-0ubuntu1

---------------
plasma-wallpaper-dynamic (3.3.4-0ubuntu1) groovy; urgency=medium

  * New upstream release 3.3.4
    - Minor CMakeLists fixes
  * d/copyright: Correct MIT license to Expat
  * Fix binary packages containing incorrect files (LP: #1893467)

 -- Erich Eickmeyer <email address hidden> Fri, 28 Aug 2020 11:40:56 -0700