Pep8 job fails due to "No value for argument" failures

[Slawek Kaplonski]

It's not failing 100% of times but I saw if few times on various patches, like e.g. https://d89caec807a881ad03df-15f9cb421d13274d63db86bb4c9dc3bd.ssl.cf5.rackcdn.com/748530/1/check/openstack-tox-pep8/5c71270/job-output.txt

Error is like:

2020-08-27 20:29:11.947277 | ubuntu-bionic | pep8 installed: alembic==1.4.2,amqp==2.6.1,appdirs==1.4.4,astroid==2.3.3,attrs==20.1.0,Babel==2.8.0,bandit==1.6.2,bashate==2.0.0,bcrypt==3.2.0,beautifulsoup4==4.9.1,cachetools==4.1.1,certifi==2020.6.20,cffi==1.14.2,chardet==3.0.4,cliff==3.4.0,cmd2==1.3.5,colorama==0.4.3,coverage==5.2.1,cryptography==3.1,ddt==1.4.1,debtcollector==2.2.0,decorator==4.4.2,dnspython==1.16.0,dogpile.cache==1.0.2,dulwich==0.20.5,entrypoints==0.3,eventlet==0.26.1,extras==1.0.0,fasteners==0.14.1,fixtures==3.0.0,flake8==3.7.9,flake8-import-order==0.12,future==0.18.2,futurist==2.2.0,gitdb==4.0.5,GitPython==3.1.7,greenlet==0.4.16,hacking==3.0.1,httplib2==0.18.1,idna==2.10,importlib-metadata==1.7.0,importlib-resources==3.0.0,iso8601==0.1.12,isort==4.3.21,Jinja2==2.11.2,jmespath==0.10.0,jsonpatch==1.26,jsonpointer==2.0,jsonschema==3.2.0,keystoneauth1==4.2.1,keystonemiddleware==9.1.0,kombu==5.0.1,lazy-object-proxy==1.4.3,linecache2==1.0.0,logutils==0.3.5,Mako==1.1.3,MarkupSafe==1.1.1,mccabe==0.6.1,monotonic==1.5,msgpack==1.0.0,munch==2.5.0,netaddr==0.8.0,netifaces==0.10.9,-e git+file:///dev/null@25d104461c3b4a68e752d946bec18a8c9bacc9e7#egg=neutron,neutron-lib==2.5.0,openstacksdk==0.48.0,os-client-config==2.1.0,os-ken==1.1.0,os-service-types==1.7.0,os-traits==2.4.0,os-vif==2.1.0,os-xenapi==0.3.4,osc-lib==2.2.0,oslo.cache==2.5.0,oslo.concurrency==4.2.0,oslo.config==8.3.1,oslo.context==3.1.0,oslo.db==8.3.0,oslo.i18n==5.0.0,oslo.log==4.3.0,oslo.messaging==12.3.0,oslo.middleware==4.1.0,oslo.policy==3.3.2,oslo.privsep==2.3.0,oslo.reports==2.1.0,oslo.rootwrap==6.1.0,oslo.serialization==4.0.0,oslo.service==2.3.2,oslo.upgradecheck==1.1.0,oslo.utils==4.4.0,oslo.versionedobjects==2.2.0,oslotest==4.4.0,osprofiler==3.3.0,ovs==2.13.0,ovsdbapp==1.4.0,packaging==20.4,paramiko==2.7.1,Paste==3.4.3,PasteDeploy==2.1.0,pbr==5.4.5,pecan==1.4.0,prettytable==0.7.2,psutil==5.7.2,pycadf==3.1.0,pycodestyle==2.6.0,pycparser==2.20,pyflakes==2.1.1,pyinotify==0.9.6,pylint==2.4.4,PyMySQL==0.10.0,PyNaCl==1.4.0,pyOpenSSL==19.1.0,pyparsing==2.4.7,pyperclip==1.8.0,pyroute2==0.5.13,pyrsistent==0.16.0,python-dateutil==2.8.1,python-designateclient==4.1.0,python-editor==1.0.4,python-keystoneclient==4.1.0,python-mimeparse==1.6.0,python-neutronclient==7.2.0,python-novaclient==17.2.0,python-subunit==1.4.0,pytz==2020.1,PyYAML==5.3.1,reno==3.1.0,repoze.lru==0.7,requests==2.23.0,requestsexceptions==1.4.0,rfc3986==1.4.0,Routes==2.4.1,setproctitle==1.1.10,simplejson==3.17.2,six==1.15.0,smmap==3.0.4,sortedcontainers==2.2.2,soupsieve==2.0.1,SQLAlchemy==1.3.19,sqlalchemy-migrate==0.13.0,sqlparse==0.3.1,statsd==3.3.0,stestr==3.0.1,stevedore==3.2.0,Tempita==0.5.2,tenacity==6.2.0,testresources==2.0.1,testscenarios==0.5.0,testtools==2.4.0,tinyrpc==1.0.4,tooz==2.7.1,traceback2==1.4.0,typed-ast==1.4.1,unittest2==1.1.0,urllib3==1.25.10,vine==1.3.0,voluptuous==0.11.7,waitress==1.4.4,wcwidth==0.2.5,WebOb==1.8.6,WebTest==2.0.35,wrapt==1.12.1,yappi==1.2.5,zipp==3.1.0
2020-08-27 20:29:11.948067 | ubuntu-bionic | pep8 start: run-test-pre
2020-08-27 20:29:11.948352 | ubuntu-bionic | pep8 run-test-pre: PYTHONHASHSEED='141212376'
2020-08-27 20:29:11.948429 | ubuntu-bionic | pep8 finish: run-test-pre after 0.00 seconds
2020-08-27 20:29:11.948631 | ubuntu-bionic | pep8 start: run-test
2020-08-27 20:29:11.948731 | ubuntu-bionic | pep8 run-test: commands[0] | sh ./tools/misc-sanity-checks.sh
2020-08-27 20:29:11.948975 | ubuntu-bionic | setting PATH=/home/zuul/src/opendev.org/openstack/neutron/.tox/shared/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
2020-08-27 20:29:11.952268 | ubuntu-bionic | [3628] /home/zuul/src/opendev.org/openstack/neutron$ /bin/sh ./tools/misc-sanity-checks.sh
2020-08-27 20:29:12.220062 | ubuntu-bionic | pep8 run-test: commands[1] | /home/zuul/src/opendev.org/openstack/neutron/tools/check_unit_test_structure.sh
2020-08-27 20:29:12.220300 | ubuntu-bionic | setting PATH=/home/zuul/src/opendev.org/openstack/neutron/.tox/shared/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
2020-08-27 20:29:12.222279 | ubuntu-bionic | [3647] /home/zuul/src/opendev.org/openstack/neutron$ /home/zuul/src/opendev.org/openstack/neutron/tools/check_unit_test_structure.sh
2020-08-27 20:29:13.165687 | ubuntu-bionic | 9 unmatched test modules were ignored
2020-08-27 20:29:13.165801 | ubuntu-bionic | Success! All test modules match targets in the code tree.
2020-08-27 20:29:13.166329 | ubuntu-bionic | pep8 run-test: commands[2] | flake8
2020-08-27 20:29:13.166735 | ubuntu-bionic | setting PATH=/home/zuul/src/opendev.org/openstack/neutron/.tox/shared/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
2020-08-27 20:29:13.169010 | ubuntu-bionic | [4330] /home/zuul/src/opendev.org/openstack/neutron$ /home/zuul/src/opendev.org/openstack/neutron/.tox/shared/bin/flake8
2020-08-27 20:29:17.352468 | ubuntu-bionic | /home/zuul/src/opendev.org/openstack/neutron/.tox/shared/lib/python3.6/site-packages/eventlet/patcher.py:1: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
2020-08-27 20:29:17.352550 | ubuntu-bionic | import imp
2020-08-27 20:29:17.352568 | ubuntu-bionic | /home/zuul/src/opendev.org/openstack/neutron/.tox/shared/lib/python3.6/site-packages/dns/hash.py:25: DeprecationWarning: dns.hash module will be removed in future versions. Please use hashlib instead.
2020-08-27 20:29:17.352582 | ubuntu-bionic | DeprecationWarning)
2020-08-27 20:31:04.004668 | ubuntu-bionic | :581: DeprecationWarning: invalid escape sequence \u
2020-08-27 20:31:04.302610 | ubuntu-bionic | pep8 run-test: commands[3] | sh ./tools/coding-checks.sh --pylint ''
2020-08-27 20:31:04.303524 | ubuntu-bionic | setting PATH=/home/zuul/src/opendev.org/openstack/neutron/.tox/shared/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
2020-08-27 20:31:04.306502 | ubuntu-bionic | [4348] /home/zuul/src/opendev.org/openstack/neutron$ /bin/sh ./tools/coding-checks.sh --pylint ''
2020-08-27 20:31:04.306975 | ubuntu-bionic | Running pylint...
2020-08-27 20:31:04.307030 | ubuntu-bionic | You can speed this up by running it on 'HEAD~[0-9]' (e.g. HEAD~1, this change only)...
2020-08-27 20:35:26.078788 | ubuntu-bionic | /home/zuul/src/opendev.org/openstack/neutron/.tox/shared/lib/python3.6/site-packages/astroid/interpreter/_import/spec.py:13: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
2020-08-27 20:35:26.078901 | ubuntu-bionic | import imp
2020-08-27 20:35:26.078925 | ubuntu-bionic | <unknown>:74: DeprecationWarning: invalid escape sequence \[
2020-08-27 20:35:26.078942 | ubuntu-bionic | <unknown>:800: DeprecationWarning: invalid escape sequence \{
2020-08-27 20:35:26.078956 | ubuntu-bionic | <unknown>:801: DeprecationWarning: invalid escape sequence \{
2020-08-27 20:35:26.078967 | ubuntu-bionic | <unknown>:802: DeprecationWarning: invalid escape sequence \{
2020-08-27 20:35:26.078978 | ubuntu-bionic | <unknown>:337: DeprecationWarning: invalid escape sequence \*
2020-08-27 20:35:26.078989 | ubuntu-bionic | <unknown>:410: DeprecationWarning: invalid escape sequence \.
2020-08-27 20:35:26.079000 | ubuntu-bionic | <unknown>:521: DeprecationWarning: invalid escape sequence \d
2020-08-27 20:35:26.079011 | ubuntu-bionic | <unknown>:1063: DeprecationWarning: invalid escape sequence \d
2020-08-27 20:35:26.079022 | ubuntu-bionic | <unknown>:1180: DeprecationWarning: invalid escape sequence \/
2020-08-27 20:35:26.079033 | ubuntu-bionic | <unknown>:48: DeprecationWarning: invalid escape sequence \d
2020-08-27 20:35:26.079044 | ubuntu-bionic | <unknown>:330: DeprecationWarning: invalid escape sequence \.
2020-08-27 20:35:26.079055 | ubuntu-bionic | <unknown>:396: DeprecationWarning: invalid escape sequence \.
2020-08-27 20:35:26.079067 | ubuntu-bionic | <unknown>:373: DeprecationWarning: invalid escape sequence \.
2020-08-27 20:35:26.079080 | ubuntu-bionic | <unknown>:536: DeprecationWarning: invalid escape sequence \.
2020-08-27 20:35:26.079092 | ubuntu-bionic | ************* Module neutron.agent.linux.dhcp
2020-08-27 20:35:26.079104 | ubuntu-bionic | neutron/agent/linux/dhcp.py:141:17: E1120: No value for argument 'bases' in classmethod call (no-value-for-parameter)
2020-08-27 20:35:26.079116 | ubuntu-bionic | neutron/agent/linux/dhcp.py:141:17: E1120: No value for argument 'namespace' in classmethod call (no-value-for-parameter)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/748594

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/748594
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3ae3c080db1bf84dbca77f72e4382de7f0e90ddf
Submitter: Zuul
Branch: master

commit 3ae3c080db1bf84dbca77f72e4382de7f0e90ddf
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Aug 28 09:40:39 2020 +0000

    Disable "no-value-for-parameter" pep8 error in DictModel

    This pep8 error ocurrs sporadically, as reported in related bug.
    The creation of a new DictModel class empty object during the
    deepcopy process only needs the class type only.

    Change-Id: Iba4f2ea700f01fd153104741614eec4855d0f387
    Closes-Bug: #1893316

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/749320

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/749320
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=72b3fc57456568b463593795a4907b9d4bac131e
Submitter: Zuul
Branch: master

commit 72b3fc57456568b463593795a4907b9d4bac131e
Author: Bence Romsics <email address hidden>
Date: Tue Sep 1 16:50:40 2020 +0200

    Move pylint disable comment to an effective place

    Bug #1893316 still occurs, e.g.:
    https://zuul.opendev.org/t/openstack/build/94dc9db2fee049b38926827e97bbec09

    after the attempted fix:
    https://review.opendev.org/748594

    I believe the attempted fix was basically good, but in order to disable
    the pylint warning for the whole method the comment must be placed
    in the method body, not on the signature line.

    Change-Id: I55c6daf976c62252aca403358b824d4d3aaa495c
    Closes-Bug: #1893316
    Related-Change: Iba4f2ea700f01fd153104741614eec4855d0f387