[SRU] Rhythmbox: Cannot add more music after a collection has been created

[crvi]

Impact]

 * After a music collection has been first initialised with music
   tracks, the user loses the ability to add more tracks at a later
   date with the modern headerbar interface that is the default for
   Ubuntu and Ubuntu Budgie
 * Currently the workaround is unintuitive - they have to disable
   the plugin or change to the traditional interface. They
   can then add more tracks using Rhythmbox's "Import" button on the
   main view source toolbar.
 * With the headerbar modern interface, Rhythmbox's "Import" button is
   hidden. Previously the option was accessible via the menu
   which was a Ubuntu specific patch which was dropped at 20.04
 * The fix is not to manipulate the main view source toolbar buttons
   i.e. to leave all buttons such as the Import button visible

[Test Case]

 * Ensure that the plugin is enabled in preferences and that the
   "modern" tickbox is enabled
 * Use "View - Show Source Toolbar" examine the source toolbar
   shown on the main Music source.
 * Using software-properties-gtk, enable the developer proposed
   repository and install the package
   rhythmbox-plugins-alternative-toolbar
 * Restart rhythmbox. Check the buttons in the Music Source Toolbar
 * The import button should be visible. Click the button and import
   more tracks as normal.

[Regression Potential]

 * I suppose the worse-case scenario is that there is some hidden
   code in the headerbar interface that was expecting one or more
   buttons in the source toolbar to be hidden. If such code existed
   unexpected functionality might be affected causing the plugin
   to malfunction
 * I've done a code-review and have found no evidence of such function.
 * This has been uploaded to Debian and has been available for a couple
   of weeks - by the time of this SRU release there should be more
   than enough time for both communities to verify that there are no
   adverse affects.
 * The plugin can easily be disabled by the user or swapped to the alternative
   interfaces available if necessary.

[Other Info]
 N/A

---

Original description

Please refer:

https://gitlab.gnome.org/GNOME/rhythmbox/-/issues/1790

[fossfreedom (fossfreedom)]

suspect that this is a specific v3.4.4 rhythmbox change.

[fossfreedom (fossfreedom)]

Tracking the resolution here https://github.com/fossfreedom/alternative-toolbar/issues/158

[crvi (crvi)]

works.

[crvi (crvi)]

Please double check if anything else is broken due to 3.4.4 changes, before ubuntu makes a release.

Thanks !

[fossfreedom (fossfreedom)]

Raise individual bug reports. You don't lump lots of issues under one banner.

On Thu, 27 Aug 2020 at 09:00, crvi <email address hidden> wrote:
>
> Please double check if anything else is broken due to 3.4.4 changes,
> before ubuntu makes a release.
>
> Thanks !
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1893113
>
> Title:
> Cannot add music
>
> Status in rhythmbox-plugin-alternative-toolbar package in Ubuntu:
> Fix Committed
> Status in rhythmbox-plugin-alternative-toolbar source package in Focal:
> Triaged
> Status in rhythmbox-plugin-alternative-toolbar source package in Groovy:
> Fix Committed
>
> Bug description:
> Please refer:
>
> https://gitlab.gnome.org/GNOME/rhythmbox/-/issues/1790
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/rhythmbox-plugin-alternative-toolbar/+bug/1893113/+subscriptions

[Launchpad Janitor (janitor)]

This bug was fixed in the package rhythmbox-plugin-alternative-toolbar - 0.19.3-2

---------------
rhythmbox-plugin-alternative-toolbar (0.19.3-2) unstable; urgency=medium

  * Bug-fix release
    - 0001-No-longer-explicitly-hide-the-Import-button-Closes-1.patch
      Don't try to hide the Import button which is no longer accessible
      by other means in rhythmbox v3.4.4 (LP: #1893113)

 -- David Mohammed <email address hidden> Wed, 26 Aug 2020 20:06:17 +0100

[Brian Murray (brian-murray)]

Hello crvi, or anyone else affected,

Accepted rhythmbox-plugin-alternative-toolbar into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/rhythmbox-plugin-alternative-toolbar/0.19.3-1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[fossfreedom (fossfreedom)]

Enabled the proposed repo and confirmed that v0.19.3-1.1 of the package installed without issues.

Running through the test case I can confirm that the import button is now visible and can be used to import music.

Ran through a few regression tests to confirm that other sources toolbar options were unaffected.

[Launchpad Janitor (janitor)]

This bug was fixed in the package rhythmbox-plugin-alternative-toolbar - 0.19.3-1.1

---------------
rhythmbox-plugin-alternative-toolbar (0.19.3-1.1) focal; urgency=medium

  * Bug-fix release
    - 0001-No-longer-explicitly-hide-the-Import-button-Closes-1.patch
      Don't try to hide the Import button which is no longer accessible
      by other means in rhythmbox v3.4.4 (LP: #1893113)

 -- David Mohammed <email address hidden> Wed, 26 Aug 2020 20:06:17 +0100

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for rhythmbox-plugin-alternative-toolbar has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.