r8168-dkms 8.048.00-1: r8168 kernel module failed to build
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
r8168 (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Medium
|
Stefan Bader |
Bug Description
[SRU Justification]
Impact: In kernel 5.6 there was a rename of a structure and change of arguments to a kernel interface function. The driver version in 20.04/Focal will fail to compile for the 5.8 HWE kernel once this is available.
Fix: Additional compatibility code which adjusted for the modified interfaces on kernel versions 5.6 and later was picked from a later version of the driver.
Testcase: dkms install -m r8168 -v 8.048.00 -k <kvers>
Regression Potential: As the code is unchanged for the release version of the kernel there is no potential for regression there. However for newer kernels there might be unknown issues but right now the driver does not compile in those cases. So being able to find those issues already is an improvement.
--- Original description ---
DKMS make.log for r8168-8.048.00 for kernel 5.6.0-1021-oem (x86_64)
Tue 18 Aug 2020 12:49:54 PM PDT
make: Entering directory '/usr/src/
AR /var/lib/
CC [M] /var/lib/
CC [M] /var/lib/
CC [M] /var/lib/
CC [M] /var/lib/
/var/lib/
/var/lib/
1670 | &rtl8168_proc_fops, f->show)) {
| ^~~~~~~~~~~~~~~~~~
| |
| const struct file_operations *
In file included from /var/lib/
./include/
59 | extern struct proc_dir_entry *proc_create_
| ^~~~~~~~~~~~~~~~
/var/lib/
/var/lib/
25825 | .ndo_tx_timeout = rtl8168_tx_timeout,
| ^~~~~~~~~~~~~~~~~~
/var/lib/
cc1: some warnings being treated as errors
make[1]: *** [scripts/
make: *** [Makefile:1707: /var/lib/
make: Leaving directory '/usr/src/
ProblemType: Package
DistroRelease: Ubuntu 20.04
Package: r8168-dkms 8.048.00-1
ProcVersionSign
Uname: Linux 5.6.0-1020-oem x86_64
ApportVersion: 2.20.11-0ubuntu27.6
Architecture: amd64
CasperMD5CheckR
DKMSKernelVersion: 5.6.0-1020-oem
Date: Wed Aug 12 12:37:38 2020
DuplicateSignature: dkms:r8168-
InstallationDate: Installed on 2020-08-11 (6 days ago)
InstallationMedia: Ubuntu 20.04.1 LTS "Focal Fossa" - Release amd64 (20200731)
PackageArchitec
PackageVersion: 8.048.00-1
Python3Details: /usr/bin/python3.8, Python 3.8.2, python3-minimal, 3.8.2-0ubuntu2
PythonDetails: N/A
RelatedPackageV
dpkg 1.19.7ubuntu3
apt 2.0.2ubuntu0.1
SourcePackage: r8168
Title: r8168-dkms 8.048.00-1: r8168 kernel module failed to build
UpgradeStatus: No upgrade log present (probably fresh install)
tags: | removed: need-duplicate-check |
Changed in r8168 (Ubuntu): | |
status: | New → Fix Released |
Changed in r8168 (Ubuntu Focal): | |
assignee: | nobody → Stefan Bader (smb) |
importance: | Undecided → Medium |
status: | New → In Progress |
Proposed cherry pick into focal/r8168. Build test in VM:
# dkms status
r8168, 8.048.00, 5.4.0-52-generic, x86_64: installed
r8168, 8.048.00, 5.8.0-25-generic, x86_64: installed