Acq Search: select all checkbox persists on subsequent grid pages without actually selecting all items

[Andrea Neiman]

This is closely related to bug 1746574, but this is the angular version.

In the newly Angularized Acq Search (bug 1850547), the select all checkbox will select all items currently visible. If you move to the next page of results, the checkbox still shows as selected but no items are actually selected.

This occurs in all 4 subtabs of the new Acquisitions Search.

To reproduce (credit to Jane Sandberg, since I've pretty much lifted these wholesale from the original bug):

1) Go to Acquisitions > General Search in a system running the new Angular Acq Search
2) Search for Lineitem ID is NOT 0 (or some other query that you know will get you a lot of results).
3) Click the checkbox at the top-left of the search results grid. This should select all of the items on that page.
4) Click the arrow button at the top-right of the grid to move to the next page of results.
5) Observe that the select all checkbox is still selected, but none of the line items are selected.
6) Repeat step 3. This time, clicking the checkbox doesn't have any effect, and then clicking it a second time selects those items.

There is a legitimate question about desired behavior - should the select-all box clear on a new page, or should it (along with its actions of actually selecting all) persist? My preference is the former, i.e., select all = "select all visible on this page, not select all results across all pages" because my sense is that is what most select-all checkboxes do in EG, but I have not comprehensively looked into it.

[Tiffany Little (tslittle)]

My gut response is that Select All = select all visible on this page, so I agree there. However, I don't think that Select All should remain...selected...if you navigate to another page of results. Considering that no results on that page are indeed selected, it just looks confusing. So I agree, the checkbox should clear on a new page.

Even if I were working with a really large dataset, I'm happy to be constrained by the number of allowable rows on the page to make whatever batch action I'm trying to do. I'd probably do a Select All on page one, do my action, then navigate to Page 2, select all, then do an action. So I'd be working within the number of rows on one page.

I can't really think of a circumstance where I'd do otherwise, but there may be a workflow that I haven't thought of.

[Wanangwa Hartwell (whartwell)]

I agree. I think Select All should equal select all visible results. That's weird that the box is checked on the next page but the results aren't. I'm not really able to replicate this, but I would expect each page to be distinct from the others. Of course, with that in mind, it would be really nice to have an option to display all lines on one page, but that might be overwhelming in some cases.

[Tiffany Little (tslittle)]

Response from one of our member libraries: "When I select all I only expect it to mark the page I'm looking at, the next page I should again need to mark all if I want all of them selected."

[Jason Stephenson (jstephenson)]

Gmail has a feature where if you select all when there are multiple pages, it shows some text and a link to ask if you want to select all on this page or all of the results that match your search. If you click the link, the text of the link is on the all of the results matching your search part, then it selects all results, otherwise it just applies to the current page. I think that could be a useful way to implement it.

[Galen Charlton (gmc)]

I think that the enhancement that Jason proposes would be a good one, but would be a bit fiddly to implement in the general case. Worth a separate LP.

Unchecking the box upon navigating to a new page of results would be much easier in comparison, potentially even a one-line change.

[Christine Morgan (cmorgan-z)]

NOBLE is very much in favor of what Jason proposes. If that can't be implemented now, then unchecking the box upon navigating to a new page, along with a separate LP for Jason's enhancement, is OK.

[Irene Patrick (iepatrick)]

When you Select All, then move to the next page, if the items are not selected, then I would expect the Select All to not be checked. It's confusing to have the Select All box checked but the line items are not selected.