Language string broken in institution stats overview page

Bug #1891237 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
19.04
Fix Released
Medium
Unassigned
19.10
Fix Released
Medium
Unassigned
20.04
Fix Released
Medium
Unassigned
20.10
Fix Released
Medium
Unassigned

Bug Description

There is an issue with [[profile/view]] broken string on a View type graph.

Part of the problem is the graph's data is cached in the database and so the broken string is stored there.

The fix for this both replaces the missing string and adds a bit to the data fetching so that any cached graph data that has a broken string recorded gets it to be translated as expected.

To test:

Have a site that contains institutions that has some members that have logged in and have made some pages (this will work best if the database has had some time to run crons for a week or so)

1) Login as admin
2) Go to the Admin -> Reports page
3) Click configure report
4) Choose an institution and keep 'report type' as 'overview'
5) See 'Pages overview' graph with the broken language string

Revision history for this message
Robert Lyon (robertl-9) wrote :
Changed in mahara:
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11129
Committed: https://git.mahara.org/mahara/mahara/commit/7d877d27760df4f111eb80d54d5ef7329879e06d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7d877d27760df4f111eb80d54d5ef7329879e06d
Author: Robert Lyon <email address hidden>
Date: Tue Aug 11 19:56:37 2020 +1200

Bug 1891237: Adding back in a missing string for statistics

Change-Id: I4b20855666996d466931683e3a0414a1015e5c30
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11131

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11132

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11133

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11133
Committed: https://git.mahara.org/mahara/mahara/commit/dda340f02abb96f73e194732240fdcf91c754741
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit dda340f02abb96f73e194732240fdcf91c754741
Author: Robert Lyon <email address hidden>
Date: Tue Aug 11 19:56:37 2020 +1200

Bug 1891237: Adding back in a missing string for statistics

Change-Id: I4b20855666996d466931683e3a0414a1015e5c30
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 7d877d27760df4f111eb80d54d5ef7329879e06d)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11131
Committed: https://git.mahara.org/mahara/mahara/commit/4dbdab0bf5d493194dc1e1dc80672c765dea0be6
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 4dbdab0bf5d493194dc1e1dc80672c765dea0be6
Author: Robert Lyon <email address hidden>
Date: Tue Aug 11 19:56:37 2020 +1200

Bug 1891237: Adding back in a missing string for statistics

Change-Id: I4b20855666996d466931683e3a0414a1015e5c30
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 7d877d27760df4f111eb80d54d5ef7329879e06d)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11132
Committed: https://git.mahara.org/mahara/mahara/commit/252862c3e4a8620c612473fe22a0add9dcaedfc6
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 252862c3e4a8620c612473fe22a0add9dcaedfc6
Author: Robert Lyon <email address hidden>
Date: Tue Aug 11 19:56:37 2020 +1200

Bug 1891237: Adding back in a missing string for statistics

Change-Id: I4b20855666996d466931683e3a0414a1015e5c30
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 7d877d27760df4f111eb80d54d5ef7329879e06d)

summary: - Language string broken in instituion stats overview page
+ Language string broken in institution stats overview page
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.