Change zsys GC to only keep one month

[Didier Roche-Tolomelli]

[Impact]
* People start experiencing /boot and disk near being full due to our snapshot policy.
* Until we implement GC pressure based on disk space, mitigate the issue by only keeping last month.

[Test Case]
* Install new ZSys version
* zsysctl show
-> You should see history states that are older than one month
* Wait for a GC pass to be ran, or run directly zsysctl service gc
-> The history states older than a month should be gone (for states that don’t have dependencies)

[Regression Potential]
This change is a configuration tweak, which is already covered by a great number of test cases. Manual testing has been done on a system with a bunch of history states.

The regression would be too much or too few history states being removed, but as said, this scenario is already covered by other test cases.

[Launchpad Janitor (janitor)]

This bug was fixed in the package zsys - 0.5.1

---------------
zsys (0.5.1) groovy; urgency=medium

  * Fix ZSys package post-installation failed when boot pool is not imported
    (LP: #1886214)
  * Change ZSys GC to only keep one month (LP: #1889385)

 -- Didier Roche <email address hidden> Wed, 29 Jul 2020 11:32:33 +0200

[Chris Halse Rogers (raof)]

Hello Didier, or anyone else affected,

Accepted zsys into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/zsys/0.4.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Jean-Baptiste Lallement (jibel)]

SRU verification for Focal:
I have reproduced the problem with zsys 0.4.6 in focal-updates and have verified that the version of zsys 0.4.7 in -proposed fixes the issue.

Marking as verification-done

For reference this is the script I used to create the snapshots:
==========
#!/bin/sh

timedatectl set-ntp no

weeks=52
date -s "$weeks weeks ago"

for d in $(seq $weeks); do
        zsysctl state save --system --no-update-bootmenu
        date -s "+7 days"
done

timedatectl set-ntp yes
==========

[Mayk (mayk)]

Hi All,

As a user encountering this issue i pulled the 0.4.7 from the updates and can confirm it removed snapshots older then 1 month. Thank you.
Would it be possible to implement a user configurable setting for this, or an option to run gc with an option to remove everything older then x days ?

thank you for all the hard work on this.

Regards,
Mayk

[Launchpad Janitor (janitor)]

This bug was fixed in the package zsys - 0.4.7

---------------
zsys (0.4.7) focal; urgency=medium

  * Fix ZSys package post-installation failed when boot pool is not imported
    (LP: #1886214)
  * Change ZSys GC to only keep one month (LP: #1889385)

 -- Didier Roche <email address hidden> Wed, 29 Jul 2020 11:32:33 +0200

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for zsys has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.