neutron-sanity-check fails with NoSuchOptError: no such option vf_management

[Steven Webster]

High level description:

A critical error is thrown when running the neutron-sanity-check script

CRITICAL neutron [-] Unhandled error: oslo_config.cfg.NoSuchOptError: no such option vf_management in group [DEFAULT]

This was initially seen in a containerized environment configured by openstack-helm. The error causes the openstack_neutron-ovs-agent-init container to fail.

It can also be reproduced in devstack

Step-By-Step:

- Grab the latest devstack as of 2020-07-24.
- Run neutron-sanity-check --config-file /etc/neutron/neutron.conf --ovsdb_native --nokeepalived_ipv6_support

Analysis:

This line probably needs to be removed:

https://opendev.org/openstack/neutron/src/branch/master/neutron/cmd/sanity_check.py#L360

See related bug https://bugs.launchpad.net/neutron/+bug/1878042

Logs:

neutron-sanity-check --config-file /etc/neutron/neutron.conf --ovsdb_native --nokeepalived_ipv6_support
2020-07-25 03:34:41.484 21383 INFO neutron.common.config [-] Logging enabled!
2020-07-25 03:34:41.484 21383 INFO neutron.common.config [-] /usr/local/bin/neutron-sanity-check version 16.1.0.dev369
CRITICAL neutron [-] Unhandled error: oslo_config.cfg.NoSuchOptError: no such option vf_management in group [DEFAULT]
ERROR neutron Traceback (most recent call last):
ERROR neutron File "/usr/local/bin/neutron-sanity-check", line 10, in <module>
ERROR neutron sys.exit(main())
ERROR neutron File "/opt/stack/neutron/neutron/cmd/sanity_check.py", line 417, in main
ERROR neutron enable_tests_from_config()
ERROR neutron File "/opt/stack/neutron/neutron/cmd/sanity_check.py", line 360, in enable_tests_from_config
ERROR neutron cfg.CONF.set_default('vf_management', True)
ERROR neutron File "/usr/local/lib/python3.6/dist-packages/oslo_config/cfg.py", line 2055, in __inner
ERROR neutron result = f(self, *args, **kwargs)
ERROR neutron File "/usr/local/lib/python3.6/dist-packages/oslo_config/cfg.py", line 2459, in set_default
ERROR neutron opt_info = self._get_opt_info(name, group)
ERROR neutron File "/usr/local/lib/python3.6/dist-packages/oslo_config/cfg.py", line 2854, in _get_opt_info
ERROR neutron raise NoSuchOptError(opt_name, group)
ERROR neutron oslo_config.cfg.NoSuchOptError: no such option vf_management in group [DEFAULT]
ERROR neutron

[[e-mail] (r-sdmin-0)]

I have very similar issue when deploying openstack with starlingx(r3.0):

- https://bugs.launchpad.net/starlingx/+bug/1889023

Hope someone can figure out it is a bug or configuration mistake.

[[e-mail] (r-sdmin-0)]

I think this happens on those hardwares do not support sriov or you didn't enable sriov in bios.
So you should use --novf_management in neutron-sanity-check.

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Actually those checks where removed in [1]. We don't need to check "ip link" support anymore, this is done now by Pyroute2 and this support is guaranteed by the requested min version of this library.

I'll remove those references.

[1]https://review.opendev.org/#/c/727811/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/743190

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/743190
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6da99368141e9be53be9d013de9180a527bcbd90
Submitter: Zuul
Branch: master

commit 6da99368141e9be53be9d013de9180a527bcbd90
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jul 27 10:47:16 2020 +0000

    Remove "vf_management" and "vf_extended_management" checks

    Since [1], the SR-IOV commands are executed using Pyroute2. The
    support to execute those commands is guaranteed by the requested
    minimum version of this library.

    [1]https://review.opendev.org/#/c/727811/

    Change-Id: I53372524c9cdc75c4b24e1f3c973f8f87a73a8f9
    Closes-Bug: #1888920

[zhipeng liu (zhipengs)]

Hi all,

Since we have cherry picked 727811 to train branch.
We also need to cherry pick 743190 to train branch.
We have already see the same issue in train.

Thanks!
Zhipeng

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/752387

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/752388

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/752388
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ba65cdc817bd28df7cd0f67e3d40ed398bb0ada3
Submitter: Zuul
Branch: stable/train

commit ba65cdc817bd28df7cd0f67e3d40ed398bb0ada3
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jul 27 10:47:16 2020 +0000

    Remove "vf_management" and "vf_extended_management" checks

    Since [1], the SR-IOV commands are executed using Pyroute2. The
    support to execute those commands is guaranteed by the requested
    minimum version of this library.

    [1]https://review.opendev.org/#/c/727811/

    Change-Id: I53372524c9cdc75c4b24e1f3c973f8f87a73a8f9
    Closes-Bug: #1888920
    (cherry picked from commit 6da99368141e9be53be9d013de9180a527bcbd90)
    (cherry picked from commit addc31d5b1e5d589b5179e9c4ae44405eed65d13)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/752387
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=addc31d5b1e5d589b5179e9c4ae44405eed65d13
Submitter: Zuul
Branch: stable/ussuri

commit addc31d5b1e5d589b5179e9c4ae44405eed65d13
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jul 27 10:47:16 2020 +0000

    Remove "vf_management" and "vf_extended_management" checks

    Since [1], the SR-IOV commands are executed using Pyroute2. The
    support to execute those commands is guaranteed by the requested
    minimum version of this library.

    [1]https://review.opendev.org/#/c/727811/

    Change-Id: I53372524c9cdc75c4b24e1f3c973f8f87a73a8f9
    Closes-Bug: #1888920
    (cherry picked from commit 6da99368141e9be53be9d013de9180a527bcbd90)