SRIOV agent does not parse correctly "ip link show <dev>"

[Rodolfo Alonso]

In Red Hat 8.2, iproute2-ss190924, the output for "ip link show <dev>" is http://paste.openstack.org/show/793392/

The regex [1] used does not parse the VF information line and can't extract the MAC address and the state.

[1]https://github.com/openstack/neutron/blob/2ac52607c266e593700be0784ebadc77789070ff/neutron/plugins/ml2/drivers/mech_sriov/agent/pci_lib.py#L38-L44
[2]https://github.com/openstack/neutron/blob/2ac52607c266e593700be0784ebadc77789070ff/neutron/plugins/ml2/drivers/mech_sriov/agent/pci_lib.py#L178

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

NOTE: pyroute2 commit where some little support for SRIOV is added: https://github.com/svinota/pyroute2/commit/1318e3e146e1243a62202f4f1b64db6da65b3034

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/726918

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/727811

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/727829

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/726918
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c5d8fd6329e405d1d584f4fedd7d0ede7da278da
Submitter: Zuul
Branch: master

commit c5d8fd6329e405d1d584f4fedd7d0ede7da278da
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon May 11 17:59:48 2020 +0000

    Use pyroute2 for SRIOV VF commands

    Recent changes in some versions of iproute2 CLI output (v4.18),
    have invalidated the regular expression used to parse the
    "ip link" output.

    To solve this problem and avoid future ones, pyroute2 is used to
    retrieve the virtual functions information and set the VF attributes
    (spoofcheck, min_tx_rate, max_tx_rate and link_state).

    pyroute2 extended the "ip link" support to retrieve this information,
    adding "ext_mask=1" in the get command. If no virtual functions are
    present in this particular network interface, the added method,
    "get_link_vfs", will return an empty list.

    The set commands can return a "InterfaceOperationNotSupported" in
    case the operation is not supported. For min_tx_rate, if the driver
    does not support to set a minimum bandwidth, an "InvalidArgument"
    (from a pyroute2.NetlinkError(22)) exception will be raised.

    Change-Id: I680da4f64bd114f1caecaaeedbf8a4b1915a0849
    Closes-Bug: #1878042

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/727829
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=764ff2a70a53100a301a07832c4d9a3fed3fd0fb
Submitter: Zuul
Branch: stable/train

commit 764ff2a70a53100a301a07832c4d9a3fed3fd0fb
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon May 11 17:59:48 2020 +0000

    Use pyroute2 for SRIOV VF commands

    Recent changes in some versions of iproute2 CLI output (v4.18),
    have invalidated the regular expression used to parse the
    "ip link" output.

    To solve this problem and avoid future ones, pyroute2 is used to
    retrieve the virtual functions information and set the VF attributes
    (spoofcheck, min_tx_rate, max_tx_rate and link_state).

    pyroute2 extended the "ip link" support to retrieve this information,
    adding "ext_mask=1" in the get command. If no virtual functions are
    present in this particular network interface, the added method,
    "get_link_vfs", will return an empty list.

    The set commands can return a "InterfaceOperationNotSupported" in
    case the operation is not supported. For min_tx_rate, if the driver
    does not support to set a minimum bandwidth, an "InvalidArgument"
    (from a pyroute2.NetlinkError(22)) exception will be raised.

    Conflicts:
        neutron/tests/unit/agent/linux/test_ip_link_support.py

    Change-Id: I680da4f64bd114f1caecaaeedbf8a4b1915a0849
    Closes-Bug: #1878042
    (cherry picked from commit c5d8fd6329e405d1d584f4fedd7d0ede7da278da)
    (cherry picked from commit 5df65489dc64fc7ec305a3c711bbb6c41ffe488b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/727811
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2b2abfc76a4993f25624e10a1403cfabfa53abd9
Submitter: Zuul
Branch: stable/ussuri

commit 2b2abfc76a4993f25624e10a1403cfabfa53abd9
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon May 11 17:59:48 2020 +0000

    Use pyroute2 for SRIOV VF commands

    Recent changes in some versions of iproute2 CLI output (v4.18),
    have invalidated the regular expression used to parse the
    "ip link" output.

    To solve this problem and avoid future ones, pyroute2 is used to
    retrieve the virtual functions information and set the VF attributes
    (spoofcheck, min_tx_rate, max_tx_rate and link_state).

    pyroute2 extended the "ip link" support to retrieve this information,
    adding "ext_mask=1" in the get command. If no virtual functions are
    present in this particular network interface, the added method,
    "get_link_vfs", will return an empty list.

    The set commands can return a "InterfaceOperationNotSupported" in
    case the operation is not supported. For min_tx_rate, if the driver
    does not support to set a minimum bandwidth, an "InvalidArgument"
    (from a pyroute2.NetlinkError(22)) exception will be raised.

    Conflicts:
        neutron/tests/unit/agent/linux/test_ip_link_support.py

    Change-Id: I680da4f64bd114f1caecaaeedbf8a4b1915a0849
    Closes-Bug: #1878042
    (cherry picked from commit c5d8fd6329e405d1d584f4fedd7d0ede7da278da)