Mahara throws 'Badly formated SAML' error even though the metadata is valid

[Kristina Hoeppner]

It would be good to investigate what SAML metadata we allow. Recently, when we updated an IdP, the error for 'badly formatted SAML' was thrown even though the IdP metadata was valid.

The old metadata that worked. Displayed is only the pertinent part that needed to be retained to work:

---
<EntityDescriptor
  xmlns="urn:oasis:names:tc:SAML:2.0:metadata"
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xmlns:ds="http://www.w3.org/2000/09/xmldsig#"
  xmlns:shibmd="urn:mace:shibboleth:metadata:1.0"
  xmlns:mdrpi="urn:oasis:names:tc:SAML:metadata:rpi"
  xmlns:mdui="urn:oasis:names:tc:SAML:metadata:ui"
  xsi:schemaLocation="urn:oasis:names:tc:SAML:2.0:metadata saml-schema-metadata-2.0.xsd urn:mace:shibboleth:metadata:1.0 shibboleth-metadata-1.0.xsd http://www.w3.org/2000/09/xmldsig# xmldsig-core-schema.xsd"
  entityID="https://URLDISGUISDED">
<Extensions>
---

The equivalent of the new metadata that wouldn't work:

---
<EntityDescriptor entityID="https://URLDISGUISDED">
<Extensions>
---

The new metadat doesn't contain any of the xmlns values and the xsi value.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11264

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11264
Committed: https://git.mahara.org/mahara/mahara/commit/582e998a7bf5341a743b17ee9d6de168903cece8
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 582e998a7bf5341a743b17ee9d6de168903cece8
Author: Robert Lyon <email address hidden>
Date: Mon Sep 14 13:06:49 2020 +1200

Bug 1885957: Check SAML XML to see if namespace declarations are met

If the SAML metadata for the IdP contains namespaced content we need
to make sure that the declarations for those namespaces are met either
within the <EntityDescriptor> tag or within child content itself

Change-Id: I4de5f721fc81dc69238ee48d3b8563e78c710737
Signed-off-by: Robert Lyon <email address hidden>