Drop obsolete Unicode patch

Bug #1885914 reported by Gunnar Hjalmarsson
32
This bug affects 6 people
Affects Status Importance Assigned to Milestone
ibus (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Medium
Gunnar Hjalmarsson

Bug Description

[Impact]

The Ubuntu 20.04 IBus version includes a patch, which was necessary in 18.04 to make the Ctrl+Shift+u shortcut work, but which has become obsolete later. Currently it prevents users from replacing Ctrl+Shift+u with some other shortcut to avoid conflicts with other applications.

See also:
* Bug #1885749
* https://github.com/ibus/ibus/issues/2163

In the proposed upload that patch has been dropped.

[Test Case]

1. Launch ibus-setup and navigate to the Emoji tab.
2. Change the Unicode code point shortcut to something else.
3. Find that the original shortcut is still effective.
4. Install the ibus packages from focal-proposed.
5. Repeat 1. and 2.
6. Find that the new shortcut works while the original
   shortcut no longer works.

[Regression Potential]

Important to confirm that the default Ctrl+Shift+u shortcut works as intended without the patch. Otherwise the regression risk should be low.

Changed in ibus (Ubuntu):
status: New → Fix Released
Changed in ibus (Ubuntu Focal):
assignee: nobody → Gunnar Hjalmarsson (gunnarhj)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :
tags: added: patch
Changed in ibus (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Gunnar, or anyone else affected,

Accepted ibus into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ibus/1.5.22-2ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed verification-needed-focal
Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

I verified the test case using version 1.5.22-2ubuntu2.1 of the ibus packages from focal-proposed.

Also confirmed that Ctrl+Shift+u works as expected when the unicode-hotkey dconf value is set to default.

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ibus - 1.5.22-2ubuntu2.1

---------------
ibus (1.5.22-2ubuntu2.1) focal; urgency=medium

  * debian/patches/ubuntu-unicode-keybinding.patch:
    - Dropped (LP: #1885914)

 -- Gunnar Hjalmarsson <email address hidden> Wed, 01 Jul 2020 14:47:00 +0200

Changed in ibus (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for ibus has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.