Mahara

Need to update site options submit function to use alias

Bug #1885784 reported by Lisa Seeto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Lisa Seeto
19.04
Fix Released
High
Unassigned
Mahara 19.04.6
19.10
Fix Released
High
Unassigned
Mahara 19.10.4
20.04
Fix Released
High
Unassigned
Mahara 20.04.1
20.10
Fix Released
High
Lisa Seeto
Mahara 20.10.0

Bug Description

Currently our code base is using a database call with a query that contains a term inserted in escaped characters. It is more robust and safer to use an alias rather than rely that variables put into escaped quotes will always reliably work.

The DB query in question is in admin/site/options.php during the siteoptions_submit().

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11047

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11047
Committed: https://git.mahara.org/mahara/mahara/commit/f67ae229c7207cab5d057e56a01381195a75eff7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f67ae229c7207cab5d057e56a01381195a75eff7
Author: Lisa Seeto <email address hidden>
Date: Wed Jul 1 10:41:14 2020 +1200

Bug 1885784: Need to update site options submit function to use alias

- altered the \"admin\" to use an alias instead

Change-Id: I3fb3cc7374619dc68bc101ddd0fdbc743a3583ac
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11056

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11056
Committed: https://git.mahara.org/mahara/mahara/commit/951eab0685293ba9a47a41bc1f2f4a3e82efbafb
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 951eab0685293ba9a47a41bc1f2f4a3e82efbafb
Author: Lisa Seeto <email address hidden>
Date: Wed Jul 1 10:41:14 2020 +1200

Bug 1885784: Need to update site options submit function to use alias

- altered the \"admin\" to use an alias instead

Change-Id: I3fb3cc7374619dc68bc101ddd0fdbc743a3583ac
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit f67ae229c7207cab5d057e56a01381195a75eff7)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11057

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11057
Committed: https://git.mahara.org/mahara/mahara/commit/8fe9483308aeef93cd728decbdc16ce242f30701
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 8fe9483308aeef93cd728decbdc16ce242f30701
Author: Lisa Seeto <email address hidden>
Date: Wed Jul 1 10:41:14 2020 +1200

Bug 1885784: Need to update site options submit function to use alias

- altered the \"admin\" to use an alias instead

Change-Id: I3fb3cc7374619dc68bc101ddd0fdbc743a3583ac
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit f67ae229c7207cab5d057e56a01381195a75eff7)
(cherry picked from commit 951eab0685293ba9a47a41bc1f2f4a3e82efbafb)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11058

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11058
Committed: https://git.mahara.org/mahara/mahara/commit/974787e578fcdaa127ab42bd9ab3145483ac34f0
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 974787e578fcdaa127ab42bd9ab3145483ac34f0
Author: Lisa Seeto <email address hidden>
Date: Wed Jul 1 10:41:14 2020 +1200

Bug 1885784: Need to update site options submit function to use alias

- altered the \"admin\" to use an alias instead

Change-Id: I3fb3cc7374619dc68bc101ddd0fdbc743a3583ac
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit f67ae229c7207cab5d057e56a01381195a75eff7)
(cherry picked from commit 951eab0685293ba9a47a41bc1f2f4a3e82efbafb)
(cherry picked from commit 8fe9483308aeef93cd728decbdc16ce242f30701)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.