backport-iwlwifi-dkms 8324-0ubuntu3 ADT test failure with linux-5.8 5.8.0-1.2

[Seth Forshee]

[SRU Justifcation]

[Impact]
When compiled against linux-oem-5.6/linux-5.8 kernels on Focal, backport-iwlwifi-dkms gives numerous errors due to in kernel interface changes and fails the installation.

[Fix]
This backports several patches from upstream backport-iwlwifi, mainline kernel, and backports project.

[Test Case]
Tested build on 5.4.0-52-generic, 5.6.0-1032-oem and 5.8.0-25-generic on Focal. Since the current version 8324 has been marked obsoleted by 5.4 or newer in bug 1863583 and bug 1869587, built modules are not installed currently so no runtime tests are required.

[Regression Potential]
Low. So far backport-iwlwifi-dkms is still marked OBSOLETED_BY=5.4.0, so it has totally no effect in the runtime system. This will only change when future enablements based on LTS series Focal that relies on out-of-tree driver support from this package.

=== Original Bug Description ===

Testing failed on:
    amd64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy-canonical-kernel-team-bootstrap/groovy/amd64/b/backport-iwlwifi-dkms/20200619_205606_7a677@/log.gz
    arm64: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy-canonical-kernel-team-bootstrap/groovy/arm64/b/backport-iwlwifi-dkms/20200619_210720_cf76d@/log.gz
    ppc64el: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-groovy-canonical-kernel-team-bootstrap/groovy/ppc64el/b/backport-iwlwifi-dkms/20200619_205835_f474a@/log.gz

[You-Sheng Yang (vicamo)]

Since oem-5.6 also fails, I added Focal to affected series.

[You-Sheng Yang (vicamo)]

PPA: https://launchpad.net/~vicamo/+archive/ubuntu/ppa-1884634

[Launchpad Janitor (janitor)]

This bug was fixed in the package backport-iwlwifi-dkms - 8613-0ubuntu1

---------------
backport-iwlwifi-dkms (8613-0ubuntu1) groovy; urgency=low

  * New release
    - upstream version 8613 commit 7db018c8995975. (LP: #1884634)
    - update debian/backport-iwlwifi-dkms.modaliases.

  * debian/patches:
    - Update 0006-backport-address-interface-change-in-linux-skbuff.h-.patch
    - Add 0007-backport-netlink-remove-NLA_EXACT_LEN_WARN.patch

 -- You-Sheng Yang <email address hidden> Tue, 23 Jun 2020 18:54:42 +0800

[Łukasz Zemczak (sil2100)]

An upload of backport-iwlwifi-dkms to focal-proposed has been rejected from the upload queue for the following reason: "What is the test case for this SRU? How will it be verified if it's correct or not? The changeset is quite big so I do not feel comfortable accepting an big changeset without a testing scenario. I would also appreciate a bit more clarification regarding how obsolete it is - does it mean it cannot be user right now as-is? Thank you!".

[You-Sheng Yang (vicamo)]

Updated https://code.launchpad.net/~vicamo/ubuntu/+source/backport-iwlwifi-dkms/+git/backport-iwlwifi-dkms/+merge/387731 a bit. Need some more tests.

[You-Sheng Yang (vicamo)]

Updated commits to include only necessary changes backported from upstream backport-iwlwifi, mainline kernel, and backports project.

Need review & submit.

[Łukasz Zemczak (sil2100)]

Hello Seth, or anyone else affected,

Accepted backport-iwlwifi-dkms into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/backport-iwlwifi-dkms/8324-0ubuntu3~20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[You-Sheng Yang (vicamo)]

Tested backport-iwlwifi-dkms version 8324-0ubuntu3~20.04.2 from focal-proposed against kernels 5.4.0-57-generic, 5.6.0-1036-oem, and 5.8.0-32-generic.

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for backport-iwlwifi-dkms has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package backport-iwlwifi-dkms - 8324-0ubuntu3~20.04.2

---------------
backport-iwlwifi-dkms (8324-0ubuntu3~20.04.2) focal; urgency=medium

  * Fix build against v5.8 kernel (LP: #1884634)
    - backport: add genlmsg_parse()
    - backport: update include/uapi/linux/pci_regs.h
    - [NOUPSTREAM] iwlwifi: mvm: use 64-bit version of timespec
    - [NOUPSTREAM] cfg80211: use parallel_ops for genl
    - backports: netlink: fix nla_validate_nested()
    - netlink: rename nl80211_validate_nested() to nla_validate_nested()
    - ftrace: Rework event_create_dir()
    - nl80211: fix NL80211_ATTR_FTM_RESPONDER policy
    - [NOUPSTREAM] nl80211: pull in NLA_POLICY_EXACT_LEN_WARN() usage

 -- You-Sheng Yang <email address hidden> Mon, 02 Nov 2020 13:55:31 +0000

[Chris Halse Rogers (raof)]

An upload of backport-iwlwifi-dkms to focal-proposed has been rejected from the upload queue for the following reason: "Steve's question from 2022-05-07 on LP: #1962704 remains unanswered; rejecting from the queue in the hope that this either prompts someone to look at the bug, or that no-one cares about this anymore. Also: several of the bugs referenced in the changelog have subsequently been marked as Fix Released for focal, and don't seem to correspond to what the changelog describes as fixing anymore.".