[kvm] change check_enabled to /dev/kvm
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
sosreport (Ubuntu) |
Fix Released
|
Medium
|
Eric Desrochers | ||
Xenial |
Fix Released
|
Medium
|
Eric Desrochers | ||
Bionic |
Fix Released
|
Medium
|
Eric Desrochers | ||
Eoan |
Fix Released
|
Medium
|
Eric Desrochers | ||
Focal |
Fix Released
|
Medium
|
Eric Desrochers | ||
Groovy |
Fix Released
|
Medium
|
Eric Desrochers |
Bug Description
[Impact]
The KVM plugin get triggered in a container
(e.g lxd) because of "/sys/module/kvm"
inheritance from the kernel host.
Not only it's a waste of sosreport time,
but running it inside a container may
unintentionally reveal details from its
host. Which is a undesired behaviour.
Switching to /dev/kvm, is more appropriate
and follow current standard as used by tool
such as cpu-checker (kvm-ok) for instance.
And taking benefit of this change to get rid
of the check_enabled() overwrite in favour of
using "files=" trigger.
[Test Case]
* Run sosreport inside a LXD container
* The container will contain KVM information from its host (Iff its host as KVM installed)
[Regression Potential]
We only change the way the plugin gets triggered to use a most conventional way.
If /dev/kvm exist, then exercise the kvm plugin.
No regression expected, but worse case scenario, it will only be isolated and impact the KVM plugin to collect data properly as expected.
It won't cause any harm to others plugins nor sosreport core functionalities itself.
The commit went through some upstream Travis testing which used a shell script called "simple.sh" to verify sosreport collection.
BTW, this same exact script is part of the sosreport autopkgtest, and will be run as part of the SRU to push this change.
[Other Information]
* Upstream bug:
https:/
* Upstream commit:
https:/
tags: | added: seg sts |
Changed in sosreport (Ubuntu): | |
assignee: | nobody → Eric Desrochers (slashd) |
status: | New → In Progress |
description: | updated |
description: | updated |
Changed in sosreport (Ubuntu Bionic): | |
status: | New → In Progress |
Changed in sosreport (Ubuntu Eoan): | |
status: | New → In Progress |
assignee: | nobody → Eric Desrochers (slashd) |
Changed in sosreport (Ubuntu Bionic): | |
assignee: | nobody → Eric Desrochers (slashd) |
Changed in sosreport (Ubuntu Groovy): | |
importance: | Undecided → Medium |
Changed in sosreport (Ubuntu Eoan): | |
importance: | Undecided → Medium |
Changed in sosreport (Ubuntu Bionic): | |
importance: | Undecided → Medium |
Changed in sosreport (Ubuntu Xenial): | |
status: | New → In Progress |
assignee: | nobody → Eric Desrochers (slashd) |
Changed in sosreport (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Fixed in Groovy's sosreport (3.9.1-1ubuntu1) uploaded earlier today.
* New 3.9.1 upstream release. (LP: #1884293) backup, console, n_framework.
This maintenance release includes:
- New plugins: sos_extras, ovirt_engine_
validatio
- lxd plugin collections have been overhauled.
- Fixed handling of the namespace pattern for the networking
plugin.
- A basic path is now defined in Policy for all subclasses.
Plugin API Enhancements:
- Enablement checks have been extended to include architecture
constraints.
- SoSPredicate has been extended to include architecture constraints,
as well as negative constraints for all elements.
- Plugins will now capture service status information for all services
defined in the services class attr.
Further release information and tarballs are available at: /github. com/sosreport/ sos/releases/ tag/3.9. 1
- https:/
* Former patches now fixed upstream: unittest- py3-fix. patch lxd-drop- db-collection- and-introduce- lxd-buginfo. patch
- d/p/0001-
- d/p/0002-
* Other specific modifications: lshw-command. patch lds-substitute- oidc-conf. patch kvm-change- trigger- to-dev- kvm.patch <==
- d/p/0001-
- d/p/0002-
==> - d/p/0003-