[SRU] elisa crashed with SIGSEGV in libvlc_set_user_agent()

[eslam gadel rab radwan]

[ Impact ]

elisa is completely unusable as it will always segfault whenever any user tries to launch the application.

The trace from the coredump showed it was trying to call a vlc api.

[ Test Plan ]

 * Execute the command "elisa" from a terminal, which will segfault if its not fixed.
 * With the fixed package, the "elisa" window will be displayed.

[ Where problems could occur ]

 * It is not changing any part of the code, rather its just adding vlc-plugin-base as a runtime dependency. So, the chance of regression is very less for this.

[ Other Info ]

* It was already fixed in 23.04.3-0ubuntu2 of Mantic release.

[ Original Bug Description ]

crashed

ProblemType: Crash
DistroRelease: Ubuntu 20.10
Package: elisa 20.04.1-0ubuntu1
ProcVersionSignature: Ubuntu 5.4.0-33.37-generic 5.4.34
Uname: Linux 5.4.0-33-generic x86_64
ApportVersion: 2.20.11-0ubuntu36
Architecture: amd64
CasperMD5CheckResult: skip
CrashCounter: 1
CurrentDesktop: ubuntu:GNOME
Date: Tue Jun 2 12:54:14 2020
ExecutablePath: /usr/bin/elisa
InstallationDate: Installed on 2020-06-01 (0 days ago)
InstallationMedia: Ubuntu 20.10 "Groovy Gorilla" - Alpha amd64 (20200518)
ProcCmdline: elisa
ProcEnviron:
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SegvAnalysis:
 Segfault happened at: 0x7f9df6d5a7dd <libvlc_set_user_agent+29>: mov (%rdi),%rbp
 PC (0x7f9df6d5a7dd) ok
 source "(%rdi)" (0x00000000) not located in a known VMA region (needed readable region)!
 destination "%rbp" ok
SegvReason: reading NULL VMA
Signal: 11
SourcePackage: elisa-player
StacktraceTop:
 libvlc_set_user_agent () from /lib/x86_64-linux-gnu/libvlc.so.5
 AudioWrapper::AudioWrapper(QObject*) () from /usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0
 ElisaApplication::initializePlayer() () from /usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0
 ElisaApplication::initialize() () from /usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0
 ?? () from /usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0
Title: elisa crashed with SIGSEGV in libvlc_set_user_agent()
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm cdrom dip lpadmin lxd plugdev sambashare sudo
separator:

[Apport retracing service (apport)]

StacktraceTop:
 libvlc_set_user_agent (p_i=0x0, name=0x7f9df8f7f182 "elisa", http=0x7f9df8f7f160 "Elisa Music Player") at core.c:136
 AudioWrapper::AudioWrapper(QObject*) () from /tmp/apport_sandbox_ewhgiulk/usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0
 ElisaApplication::initializePlayer() () from /tmp/apport_sandbox_ewhgiulk/usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0
 ElisaApplication::initialize() () from /tmp/apport_sandbox_ewhgiulk/usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0
 ElisaApplication::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) () from /tmp/apport_sandbox_ewhgiulk/usr/lib/x86_64-linux-gnu/elisa/libelisaLib.so.0

[Leonidas S. Barbosa (leosilvab)]

Hi Eslam,

Thanks for report this issue. Do you have any steps in how to reproduce this issue?

[Marc Deslauriers (mdeslaur)]

Thanks for taking the time to report this bug and helping to make Ubuntu better. We appreciate the difficulties you are facing, but this appears to be a "regular" (non-security) bug. I have unmarked it as a security issue since this bug does not show evidence of allowing attackers to cross privilege boundaries nor directly cause loss of data/privacy. Please feel free to report any other bugs you may find.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Bruno Pitrus (wistful-woodpecker)]

Installing the package `phonon4qt5-backend-vlc` fixed the crash for me. It should be in Elisa dependencies.

[Mark (leyva-mark)]

This issue is still present in Kubuntu 22.10. Running strace on Elisa points to some possible missing dependencies.

Installing vlc-plugin-base allows Elisa to work properly.

It seems, while installing Elisa installs libvlc and libvlccore, it doesn't install the vlc-plugin-base needed for it to run properly.

Version affected: Kubuntu 22.10
Elisa version: 22.08.3-0ubuntu1~ubuntu22.10~ppa
Expected: Not to crash on startup
What happened: Crashed on startup

Steps to reproduce: Run Elisa.

[Ubuntu QA Website (ubuntuqa)]

This bug has been reported on the Ubuntu ISO testing tracker.

A list of all reports related to this bug can be found here:
https://iso.qa.ubuntu.com/qatracker/reports/bugs/1881741

[Sudip Mukherjee (sudipmuk)]

I can reproduce the crash on Focal, Jammy and Lunar. I have also tested and confirmed that it works on Mantic and Noble.

[Sudip Mukherjee (sudipmuk)]

Debdiff for Lunar attached.

[Sudip Mukherjee (sudipmuk)]

Debdiff for Jammy attached.

[Sudip Mukherjee (sudipmuk)]

Debdiff for Focal attached.

[Benjamin Drung (bdrung)]

Thanks for contributing to Ubuntu. Sponsored the uploads:

* elisa-player 22.12.3-0ubuntu1.1 to lunar
* elisa-player 21.12.3-0ubuntu1.1 to jammy
* elisa-player 19.12.3-1ubuntu1.1 to focal

Next steps: An archive admin needs to accept the uploads in the archive.

[Timo Aaltonen (tjaalton)]

Hello eslam, or anyone else affected,

Accepted elisa-player into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/elisa-player/21.12.3-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello eslam, or anyone else affected,

Accepted elisa-player into lunar-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/elisa-player/22.12.3-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-lunar to verification-done-lunar. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-lunar. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello eslam, or anyone else affected,

Accepted elisa-player into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/elisa-player/19.12.3-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Sudip Mukherjee (sudipmuk)]

I can confirm that elisa from focal-proposed has been fixed.

test done:
1. install elisa
2. Try to open elisa and confirm it fails
3. Add focal-proposed to apt sources
4. Upgrade elisa
5. Open elisa and confirm it opens

Test result: The bug is fixed and elisa can be used again.

Package tested:
$ dpkg -l | grep elisa
ii elisa 19.12.3-1ubuntu1.1 amd64 Simple music player with a focus on Plasma desktop integration and privacy

[Sudip Mukherjee (sudipmuk)]

I can confirm that elisa from jammy-proposed has been fixed.

test done:
1. install elisa
2. Try to open elisa and confirm it fails
3. Add jammy-proposed to apt sources
4. Upgrade elisa
5. Open elisa and confirm it opens

Test result: The bug is fixed and elisa can be used again.

Package tested:
$ dpkg -l | grep elisa
ii elisa 21.12.3-0ubuntu1.1 amd64 Simple music player with a focus on Plasma desktop integration and privacy

[Sudip Mukherjee (sudipmuk)]

I am not verifying Lunar as its now EOL.

[Launchpad Janitor (janitor)]

This bug was fixed in the package elisa-player - 19.12.3-1ubuntu1.1

---------------
elisa-player (19.12.3-1ubuntu1.1) focal; urgency=medium

  * Add vlc-plugin-base as runtime depend. (LP: #1881741)

 -- Sudip Mukherjee <email address hidden> Thu, 11 Jan 2024 13:29:13 +0100

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for elisa-player has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package elisa-player - 21.12.3-0ubuntu1.1

---------------
elisa-player (21.12.3-0ubuntu1.1) jammy; urgency=medium

  * Add vlc-plugin-base as runtime depend. (LP: #1881741)

 -- Sudip Mukherjee <email address hidden> Thu, 11 Jan 2024 13:21:05 +0100