Mahara

When adjusting group membership via the Engage -> People page the modal doesn't close on submit

  1. Series 20.04
  2. Bug #1880771
Bug #1880771 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
19.04
Fix Released
Low
Unassigned
Mahara 19.04.6
19.10
Fix Released
Low
Unassigned
Mahara 19.10.4
20.04
Fix Released
Low
Unassigned
Mahara 20.04.1
20.10
Fix Released
Low
Robert Lyon
Mahara 20.10.0

Bug Description

This is because the js is expecting .modal.in when it actually has .modal.show

To test:
Make sure you have a site with some users and groups

Login in as admin and go to Engage -> People
Click on 'Edit group membership' for a user
Select a group either in the Add member or Invite parts and click on 'Apply changes'

The modal should close on saving

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 20.10.0
assignee: nobody → Robert Lyon (robertl-9)
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10990

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10990
Committed: https://git.mahara.org/mahara/mahara/commit/74704ecc1a964d9839b4e5b4a7a634524979c38c
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 74704ecc1a964d9839b4e5b4a7a634524979c38c
Author: Robert Lyon <email address hidden>
Date: Wed May 27 11:01:16 2020 +1200

Bug 1880771: Closing the 'add group membership' modal on saving

Fixing up the css selector in the js

Change-Id: I2efa1d69e06694cd3eb09ad17d40e835077c7d9e
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10994

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10994
Committed: https://git.mahara.org/mahara/mahara/commit/b5b818c8f342978354e6f118d23f6bd52cab16b0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 20.04_STABLE

commit b5b818c8f342978354e6f118d23f6bd52cab16b0
Author: Robert Lyon <email address hidden>
Date: Wed May 27 11:01:16 2020 +1200

Bug 1880771: Closing the 'add group membership' modal on saving

Fixing up the css selector in the js

Change-Id: I2efa1d69e06694cd3eb09ad17d40e835077c7d9e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 74704ecc1a964d9839b4e5b4a7a634524979c38c)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10995

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10995
Committed: https://git.mahara.org/mahara/mahara/commit/19256304042dff7fb9760d81262894b50f4ab19f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 19256304042dff7fb9760d81262894b50f4ab19f
Author: Robert Lyon <email address hidden>
Date: Wed May 27 11:01:16 2020 +1200

Bug 1880771: Closing the 'add group membership' modal on saving

Fixing up the css selector in the js

Change-Id: I2efa1d69e06694cd3eb09ad17d40e835077c7d9e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 74704ecc1a964d9839b4e5b4a7a634524979c38c)
(cherry picked from commit b5b818c8f342978354e6f118d23f6bd52cab16b0)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10996

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10996
Committed: https://git.mahara.org/mahara/mahara/commit/9d0172495296e88975643a0667f7e04666a85a74
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 9d0172495296e88975643a0667f7e04666a85a74
Author: Robert Lyon <email address hidden>
Date: Wed May 27 11:01:16 2020 +1200

Bug 1880771: Closing the 'add group membership' modal on saving

Fixing up the css selector in the js

Change-Id: I2efa1d69e06694cd3eb09ad17d40e835077c7d9e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 74704ecc1a964d9839b4e5b4a7a634524979c38c)
(cherry picked from commit b5b818c8f342978354e6f118d23f6bd52cab16b0)
(cherry picked from commit 19256304042dff7fb9760d81262894b50f4ab19f)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.