Web Client - Survey End Time Can Come Before Start Time

[Jennifer Pringle]

Evergreen 3.5

The new angular survey interface (Administration -> Local Administration -> Surveys) allows you to enter an end time that comes before the start time for the survey. Ideally Evergreen should stop you from creating a survey that finished before it starts.

The Survey End Date/Time field comes before the Survey Start Date/Time when creating or editing a survey which lends itself to people entering the opposite dates by accident (https://bugs.launchpad.net/evergreen/+bug/1879514).

[Mike Risher (mrisher)]

The surveys have been modified so that the start date is listed before the end date. Also, if one enters an end date that comes before the start date an error is raised on the form and the save button is disabled.

Note that part of the changes involve adding a new "FmFieldOption" to fm-editor called "isDataValid"

Ready for testing. Branch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1879517-start-end-date-error

[Kyle Huckins (khuckins)]

This required a minor rebase for the latest master, I've pushed up a rebased branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/khuckins/lp1879517-start-end-date-error-rebase

[Dawn Dale (ddale)]

I have tested this code and consent to sign off with my name, Dawn Dale and email address ddale @georgialibraries.org.

[Jane Sandberg (sandbergja)]

Thank you for your code, Mike and Kyle! It works well, but I have a concern that the isDataValid structure is essentially duplicating the existing validation features in Angular.

I've been playing with an alternative patch that uses the existing validation features: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1879517_alternative_patch . It's not quite there (I tried to set a default end date in the future, but couldn't figure out how...), but hopefully it at least demonstrates the alternative approach.

[Jane Sandberg (sandbergja)]

My alternative patch is now ready for review -- let me know what you think!

[Susan Morrison (smorrison425)]

When adding an end date before a start date, an alert does pop up notifying of the error, but I could still save the survey and add questions and answers.

Also, a couple funny things happen when trying to edit the survey with the incorrect date range (end date before start date). These may be irrelevant since ideally a survey with the wrong date range would not be saved but:

When editing a survey with an incorrect date range (end before start), when pulling up the edit screen, the dates revert to the default instead of what was chosen upon saving the survey. I did confirm that if I didn't touch the dates, made some other changes, and then clicked Save, the dates stayed as I originally input them.

When I do update the dates, an alert will pop up if my new end date is before the original start date, even if it's after the updated start date. When I save, it autocorrects the end date to be before the original start date, even if it's incorrect/still before the end date. And the original start date did not change based on the edit. Attached a couple screenshots to show when I tried to edit and the resulting dates.

[Jennifer Pringle (jpringle-u)]

Testing for bug squashing week I cannot create a survey at all. No matter what I do I get "Failed to Create New Survey"

I also can't edit the existing survey. It tells me Update Succeeded but it doesn't actually save my changes.

I tried with a Local Administrator account as well as with the global admin account.

[Jane Sandberg (sandbergja)]

removing pullrequest, since I need to go back to the drawing board.

[Jane Sandberg (sandbergja)]

Should be ready for review again! Adding pullrequest back.

[Blake GH (bmagic)]

All,

This patch caused Evergreen to break. After applying the patch, the Evergreen database couldn't get new rows created. Postgres complains about having null values on non-null columns. The test I used was creating a new Org Unit. This is the Postgres log message:

ERROR: null value in column "shortname" violates not-null constraint

INSERT INTO actor.org_unit (billing_address,holds_address,id,ill_address,mailing_address,name,ou_type,parent_ou,shortname,email,phone,opac_visible,fiscal_calendar) VALUES (DEFAULT,DEFAULT,DEFAULT,DEFAULT,DEFAULT,DEFAULT,2,1,DEFAULT,DEFAULT,DEFAULT,'f',1);

I'm not exactly sure what part of this patch causes this cascading issue.

I'm using this patch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1879517_alternative_patch

[Jane Sandberg (sandbergja)]

Force pushed a fix so that it doesn't break all of Evergreen! Sorry, Blake!!!!! But thanks for the report.

[Susan Morrison (smorrison425)]

Looks great to me. I can no longer save/create a survey if the end date is before the start date, and the alert pops up as expected.

I have tested this code and consent to signing off on it with my name, Susan Morrison,
and my email address, <email address hidden>.

[Jason Boyer (jboyer)]

I'd like to see this have customizable error messages but it does the thing and that can be addressed later. Pushed to rel_3_9 and up. Thanks Jane and Susan!