netplan.io 0.98 introduced more strict parsing of bonding mode, causing failures at boot for existing systems
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
netplan.io (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
High
|
Lukas Märdian |
Bug Description
As noted in https:/
=== SRU ===
[Impact]
This release contains one regression bug-fix for the bionic stable release and we would like to make sure all of our supported customers have access to these improvements.
* Do not reject invalid bonding mode config (LP: #1877643)
- Print a warning instead on bionic
- Only affects the bionic series
See the changelog entry below for a full list of changes and bugs.
[Test Case]
The following development and SRU process was followed:
https:/
Netplan contains an extensive integration test suite that is ran using
the SRU package for each releases. This test suite's results are available here:
http://
A successful run is required before the proposed netplan package
can be let into -updates.
The netplan team will be in charge of attaching the artifacts and console
output of the appropriate run to the bug. Netplan team members will not
mark ‘verification-done’ until this has happened.
[Regression Potential]
In order to mitigate the regression potential, the results of the
aforementioned integration tests are attached to this bug.
Special attention is given to tests/generator
https:/
https:/
https:/
https:/
https:/
https:/
[Discussion]
It may be appropriate from an upstream POV to make the validation of input more strict over time, but it is never acceptable for an SRU to regress the interpretation of user config in this manner and cause config to fail to apply. This PR either needs to be reverted for bionic, or it needs to be modified to treat unknown modes as a warning instead of a failure.
[Changelog]
debian/
[PATCH] Fix invalid bond mode SRU regression (LP: #1877643)
Related branches
- Łukasz Zemczak: Approve
-
Diff: 80 lines (+59/-0)3 files modifieddebian/changelog (+8/-0)
debian/patches/Fix-invalid-bond-mode-SRU-regression-LP-1877643.patch (+50/-0)
debian/patches/series (+1/-0)
Changed in netplan.io (Ubuntu Bionic): | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: regression-update |
tags: | added: id-5eb5a516d9abc944cc31aaed |
Changed in netplan.io (Ubuntu Bionic): | |
status: | Triaged → In Progress |
assignee: | nobody → Lukas Märdian (slyon) |
Changed in netplan.io (Ubuntu): | |
status: | New → Invalid |
tags: | added: upgrade-software-version verification-needed verification-needed-bionic |
description: | updated |
Would love to see it become a warning for bionic rather than revert.
The previous (lack of) validation allowed invalid configs to silently be accepted, leading to unexpected behaviour when processed by the backend (e.g. networkd).
In our case, we had machines lose connectivity on reboot after a long period of up-time because we had listed the bonding mode number (4) instead of the valid name (802.3ad). IIRC, at the time, we eventually found that this made the bonding mode fall back to round-robin.