[SRU] Update to 3.36.3

[Alberts Muktupāvels]

[Impact]

This is bug fix release that includes:
- translation updates;
- few memory leak fixes;
- important fixes to screensaver;
- fix and improvement to desktop icons;
- restores ability to disable animations.

NEWS:
https://gitlab.gnome.org/GNOME/gnome-flashback/-/commit/5036ec999d9f9ad8772e863e4cee2b679beb569f
https://gitlab.gnome.org/GNOME/gnome-flashback/-/commit/d0be6f0aab1ac38fdde273a6984c070a82096dc1

Fixes:
- https://bugs.launchpad.net/bugs/1875703
- https://bugs.launchpad.net/bugs/1875317

Might fix:
- https://bugs.launchpad.net/bugs/1876668

Without fixes user might be unable to unlock screen:
https://gitlab.gnome.org/GNOME/gnome-flashback/-/issues/46

Or taking screenshots could dead lock gnome-flashback process:
https://gitlab.gnome.org/GNOME/gnome-flashback/-/issues/50

GNOME Settings Daemon no longer directly manages `enable-animations` setting from `org.gnome.desktop.interface` schema meaning GNOME Flashback users can not disable animations. This release includes necessary changes to restore functionality.

List of commits and full diff between 3.36.1 and 3.36.3:
https://gitlab.gnome.org/GNOME/gnome-flashback/-/compare/3.36.1...3.36.3

[Test Case]

Steps to reproduce screensaver problem:
https://gitlab.gnome.org/GNOME/gnome-flashback/-/issues/46

Steps to reproduce screenshot/clipboard problem:
https://gitlab.gnome.org/GNOME/gnome-flashback/-/issues/50

Steps to reproduce desktop icon rename problem:
https://bugs.launchpad.net/bugs/1875703

Steps to reproduce desktop icon launch problem:
https://bugs.launchpad.net/bugs/1875317

[Regression Potential]

Screenshot/clipboard fix should have low regression potential as fix mostly moves clipboard out to separate process. Without fix whole process can deadlock... Worst thing that could happen might be missing clipboard and/or screenshot functionality. Even in such case that is better than having whole process deadlocked losing other functionality.

Screensaver already has serious problem - inability to get back to desktop. I can not imagine any regression that would be worse then current situation.

Fix/improvement to desktop icon renaming with keybinding should not case any functional regression. It is small change that adds extra key handling to allow to initiate desktop icon rename with keyboard shortcut.

[Other Info]

None.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Timo Aaltonen (tjaalton)]

Hello Alberts, or anyone else affected,

Accepted gnome-flashback into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-flashback/3.36.3-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Moritz Heiber (mheiber)]

The version in proposed it fixing a lot of the existing bugs I've seen. Thanks!

[Patrick Menschel (menschel)]

Fixed https://bugs.launchpad.net/bugs/1876668
Thanks!

[Ellis Rahhal (ellis-rahhal)]

I had the issue with the screensaver, and the proposed package does indeed fix it. I'm seeing another similar problem that might have the same root cause, so reporting it here. When I first log in, gnome-panel is not visible (behind the desktop?). I have to kill it and restart it to see it. I no longer have to do this after unlocking the screensaver though which is great.

[Alberts Muktupāvels (muktupavels)]

That sounds like different issue to me. Please open new bug for that. And try to provide as much information as you can.

Can you try to disable desktop with `gsettings set org.gnome.gnome-flashback desktop false`? Does problem disappears? You should not have desktop icons and I think you should have no background too...

[Ellis Rahhal (ellis-rahhal)]

Thanks Alberts, that actually "solves" the problem. Interestingly, setting it back to true immediately reloads the desktop and occludes anything that is on screen. Do you still suggest opening a new bug?

[Alberts Muktupāvels (muktupavels)]

Yes, I think...

Do you use GNOME Flashback (Compiz) or GNOME Flashback (Metacity) session? If not it might be problem with your window manager...

[Ellis Rahhal (ellis-rahhal)]

I'm using GNOME Flashback (Metacity). I'll go ahead and open a bug. Thanks.

[Alberts Muktupāvels (muktupavels)]

Looks like only unverified/untested thing at this point is clipboard/screenshot problem. Tested this myself in VM. With 3.36.3-0ubuntu1 I can not reproduce problem. Also tested ability to disable animations.

[Felix Moreno (info-justdust)]

Happens to me to, lot of ubuntu 20.04 differente graphic cards,

"Screensaver already has serious problem - inability to get back to desktop. I can not imagine any regression that would be worse then current situation."

I hasd to disable screensaver in all the machines meanwhile because they never come back.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-flashback - 3.36.3-0ubuntu1

---------------
gnome-flashback (3.36.3-0ubuntu1) focal; urgency=medium

  * New upstream bugfix release (LP: #1876731).
    - Added desktop files are now properly recognized (LP: #1875317).
    - Files now can be renamed using F2 key (LP: #1875703).
  * Install the new gnome-flashback-clipboard executable in gnome-flashback
    package.
  * Bump gnome-session-flashback dependency on gnome-flashback to 3.36.3.
  * Update debian/copyright for clipboard code move.
  * Refresh debian/patches/load_indicators.diff.

 -- Dmitry Shachnev <email address hidden> Mon, 04 May 2020 16:59:18 +0300

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for gnome-flashback has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.