[UBUNTU 20.04] zfcpdump-kernel package has different name for dumpkernel image than zipl expects

[bugproxy]

[Impact]

 * Cannot perform ZFCP SCSI dump of LPAR instance

[Test Case]

 * install zfcdump-kernel package

 * Prepare zfcp dump with zipl -d

 * Use HMC to stop all processors and perform SCSI dump

 * Boot normally, verify that kernel dump is readable from the SCSI dump partition.

[Regression Potential]

 * This update corrects the name of the kernel image, but also bumps the zfcpdump kernel sources to v5.4 to match focal. Currently zfcpdump is unusable in focal. Bringing the kernel config to v5.4 may expose config changes that behave differently. Please note this kernel is only used when performing kernel dump and is not used for any regular operations.

[Other Info]

 * Original Bug report.

Under Ubuntu 20.04 I wanted to prepare a SCSI dump disk:

root@t35lp25:/~# apt install zfcpdump-kernel
Reading package lists... Done
Building dependency tree
Reading state information... Done
The following NEW packages will be installed:
  zfcpdump-kernel
0 upgraded, 1 newly installed, 0 to remove and 8 not upgraded.
Need to get 1655 kB of archives.
After this operation, 1757 kB of additional disk space will be used.
Get:1 http://de.ports.ubuntu.com/ubuntu-ports focal/universe s390x zfcpdump-kernel s390x 4.13-0ubuntu1 [1655 kB]
Fetched 1655 kB in 1s (1803 kB/s)
Selecting previously unselected package zfcpdump-kernel.
(Reading database ... 53866 files and directories currently installed.)
Preparing to unpack .../zfcpdump-kernel_4.13-0ubuntu1_s390x.deb ...
Unpacking zfcpdump-kernel (4.13-0ubuntu1) ...
Setting up zfcpdump-kernel (4.13-0ubuntu1) ...
root@t35lp25:/~# zipl -d /dev/disk/by-id/scsi-36005076303ffd3270000000000004609-part1
Error: Need external file '/lib/s390-tools/zfcpdump/zfcpdump-image' for partition dump: No such file or directory
root@t35lp25:~# ls /lib/s390-tools/zfcpdump/
zfcpdump-initrd zfcpdump_part.image
root@t35lp25:~#

As you can see, zipl expects "zfcpdump-image", but "zfcpdump_part.image" is available.
with paramater -d, zipl does NOT accept -i to override the image name. Thus I renamed zfcpdump_part.image to zfcpdump-image:

root@t35lp25:~# cd /lib/s390-tools/zfcpdump
root@t35lp25:/lib/s390-tools/zfcpdump# mv zfcpdump_part.image zfcpdump-image
root@t35lp25:/lib/s390-tools/zfcpdump# zipl -d /dev/disk/by-id/scsi-36005076303ffd3270000000000004609-part1
Building bootmap directly on partition '/dev/disk/by-id/scsi-36005076303ffd3270000000000004609-part1'
Adding dump section
  initial ramdisk...: /lib/s390-tools/zfcpdump/zfcpdump-initrd
  kernel image......: /lib/s390-tools/zfcpdump/zfcpdump-image
  kernel parmline...: 'root=/dev/ram0 dump_mem=1 possible_cpus=1 cgroup_disable=memory '
  component address:
    heap area.......: 0x00002000-0x00005fff
    stack area......: 0x0000f000-0x0000ffff
    internal loader.: 0x0000a000-0x0000dfff
    parameters......: 0x00009000-0x000091ff
    kernel image....: 0x00010000-0x001b9fff
    parmline........: 0x001ba000-0x001ba1ff
    initial ramdisk.: 0x001c0000-0x0020edff
Preparing boot device: sde.
Done.
root@t35lp25:/lib/s390-tools/zfcpdump#

===============================================
Hi,

zfcpdump_part.image got renamed to zfcpdump-image upstream with s390-tools v2.7.0. For me it looks like the old name is hard coded somewhere in the packaging/installation routines.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-05-06 08:35 EDT-------
From LTC bug 185720 - LP1877089:
> We can either revert the path change in s390-tools or rebuild the zfcpdump
> kernel flavour with the new name.

This should IMO be decided by the s390tools maintainer! (I personally prefer the latter.)

[Frank Heimes (fheimes)]

Hi, were the s390-tools maintainer able to dive deeper into this?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-07-23 10:08 EDT-------
(In reply to comment #10)
> Hi, were the s390-tools maintainer able to dive deeper into this?

Hi,
I'm no s390-tools maintainer but I guess in the long run it's easiest when you rebuild the zfcpdump kernel with the new names otherwise ubuntu will be decoupled from upstream.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-07-23 11:48 EDT-------
(In reply to comment #11)
> (In reply to comment #10)
> > Hi, were the s390-tools maintainer able to dive deeper into this?
>
> Hi,
> I'm no s390-tools maintainer but I guess in the long run it's easiest when
> you rebuild the zfcpdump kernel with the new names otherwise ubuntu will be
> decoupled from upstream.

Hi,

I have to agree with Philipp and the decoupling from upstream. I'd also suggest to rebuild the zfcpdump kernel with the new name.

For reference, this is the upstream change that introduced the issue:
https://github.com/ibm-s390-tools/s390-tools/commit/724f1fea2c523831a300c71fc67a87f598701846

[Dimitri John Ledkov (xnox)]

@frank @ibm

this ticket is not helpful, and there is no need for any s390-tools maintainers to comment on.

this ticket has been resolved and new name is in use and has been uploaded 3 weeks ago.

However, it is not available as it is blocked on manual kernel team review to allow signing of the zfcpdump kernel as requested in a different ticket.

This is blocked on review & approval for secureboot signing.

[Frank Heimes (fheimes)]

@Dimitri Thx, that update is helpful (we briefly touched on that today).
Before that, the know status for me was like at the end of comment #1.
I wasn't aware of any activity, nor progress, since the status was still Triaged.
Glad to hear that you and/or the kernel team already pushed this.

[Dimitri John Ledkov (xnox)]

In unapproved queue, after dropping unsupported SIPL signing. https://launchpad.net/ubuntu/focal/+queue?queue_state=1&queue_text=zfcpdump-kernel

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-12-10 13:33 EDT-------
Still not fixed with focal updates as of 2020-12-10.
Then I updated to https://launchpad.net/ubuntu/focal/+queue?queue_state=3&queue_text=zfcpdump-kernel as of focal-proposed.
Found /lib/s390-tools/zfcpdump/zfcpdump-image with its correct name on the correct place.
Waiting for release into focal-updates.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-12-11 03:34 EDT-------
Version of zfcpdump-kernel is 5.4-0ubuntu1.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2021-01-13 09:54 EDT-------
IBM Bugzilla status-> closed , Fix Released by Canonical