20.4 - ssh/sftp - bookmark not working

[frank]

[Impact]

Users cannot open remote filesystems by clicking bookmarks in gnome-panel (Places menu or its "Recent documents" submenu).

This is fixed by calling g_file_mount_enclosing_volume if the volume is not mounted yet, instead of displaying an error.

[Test Case]

- install gnome-session-flashback and log into GNOME Flashback (Metacity) session
- open nautilus
- access a remote filesystem (e.g. ssh://192.168.0.x - server with sftp enabled in lan) by pressing Ctrl-L to show address bar and inserting the address
- create a bookmark for it by opening Nautilus context menu and clicking "Add to Bookmarks"
- unmount the share
- click on bookmark in gnome-panel Places menu

[Regression Potential]

This bug itself is a regression from previous releases, e.g. in Ubuntu 18.04 it worked fine.

Most of the new code is executed within the "if (g_error_matches (error, G_IO_ERROR, G_IO_ERROR_NOT_MOUNTED))" block, so it is executed only where previously there was an error.

The only change outside that block is factoring out the launch_uri_show_error_dialog function, but the logic is not changed.

In any case, the potential regressions would be limited to handling items in the Places menu.

[Other Info]

Upstream fix (in gnome-3-36 branch): <https://gitlab.gnome.org/GNOME/gnome-panel/-/commit/9fe1004685c0ed6c>.

[Sebastien Bacher (seb128)]

Thank you for your bug report.

To display the address bar you can simple do Ctrl-L

On the bookmark not working, does it make a difference if you try from a normal GNOME session? Could you nautilus -q and then start nautilus manually and see if it displays any error? Could you also include the journal log when trying?

[frank (frankwu)]

thanks for giving the shortcut...but it should be visible in GUI (afair was in 18.4)

tested in separate VM, it looks like in default ubuntu gnome-session it works (tested only with IP). IP was also not working in gnome-flashback giving the error "the name:1.373 was not provided by any .service files", but only from top-menu (seems to work from inside nautilus). Can't get the other mounting-error back (tried name from .ssh/config and IP) at the moment

[frank (frankwu)]

ok, after reboot i got again the not-mounted-error (umount seems not enough)...only in top-menu (gnome-flashback, have not found similar access in default ubuntu gnome-session), can mount via bookmark inside nautilus (also in flashback). looks more like a gnome-flashback-issue, can this be changed?

i have this in .config/gtk-3.0/bookmarks:

sftp://192.168.0.10/home/frank 192.168.0.10
sftp://r2/home/frank r2

both bring same error (not mounted after boot and now also after umount in nautilus, not able to get the .service error), "r2" is hostname defined in .ssh/config pointing to same remote device

HOST r2
  HostName 192.168.0.10
  Port 22
  User frank
  IdentityFile ~/.ssh/id_rsa

[Alberts Muktupāvels (muktupavels)]

Please open upstream issue here - https://gitlab.gnome.org/GNOME/gnome-panel/-/issues.

[frank (frankwu)]

https://gitlab.gnome.org/GNOME/gnome-panel/-/issues/27

[frank (frankwu)]

issue is fixed upstream, need to be transferred to ubuntus apt-repo

https://gitlab.gnome.org/GNOME/gnome-panel/-/issues/27#note_864668

[Alberts Muktupāvels (muktupavels)]

Fix is in 3.36.2 release, this bug needs to be updated to match SRU bug template - https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "gnome-panel-bookmark.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-panel - 1:3.36.2-1ubuntu1

---------------
gnome-panel (1:3.36.2-1ubuntu1) groovy; urgency=medium

  * Merge with Debian unstable, remaining changes:
    - debian/changelog:
      + Use an epoch in version number.
    - debian/control.in:
      + Recommend indicator-applet.
      + Use Ubuntu VCS fields.
    - debian/rules:
      + Explicitly build without -Bsymbolic-functions flag.
    - debian/patches/40_unset_menuproxy.patch:
      + Make sure panel and applets do not pick up menu proxies.
    - debian/ubuntu.layout, debian/gnome-panel-data.*:
      + Add the layout file for Ubuntu.
      + Make it default using a gsettings-override file.
  * gp_menu_utils_launch_uri now mounts volumes if needed (LP: #1876281).

 -- Dmitry Shachnev <email address hidden> Mon, 13 Jul 2020 13:33:34 +0300

[frank (frankwu)]

Will it be fixed in focal too?

[Dmitry Shachnev (mitya57)]

Yes, I am working on a fix for Focal.

[Brian Murray (brian-murray)]

Hello frank, or anyone else affected,

Accepted gnome-panel into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-panel/1:3.36.2-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Dmitry Shachnev (mitya57)]

Hi Frank! Can you please test the fixed package in focal-proposed?

[frank (frankwu)]

installed from focal-proposed

$ dpkg -s gnome-panel
Package: gnome-panel
Status: install ok installed
Priority: optional
Section: gnome
Installed-Size: 1450
Maintainer: Ubuntu Developers <email address hidden>
Architecture: amd64
Version: 1:3.36.2-0ubuntu1

seems to work well too

[Dmitry Shachnev (mitya57)]

Thanks for confirming!

Marking as verified per comment #19.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-panel - 1:3.36.2-0ubuntu1

---------------
gnome-panel (1:3.36.2-0ubuntu1) focal; urgency=medium

  * New upstream bugfix release (LP: #1887521).
    - gp_menu_utils_launch_uri now mounts volumes if needed (LP: #1876281).

 -- Dmitry Shachnev <email address hidden> Tue, 14 Jul 2020 15:53:51 +0300

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gnome-panel has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.