Support Intel TGL CPU on Focal

Bug #1876066 reported by Alex Tu
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
Critical
Alex Tu
thermald (Ubuntu)
Fix Released
Wishlist
Alex Tu
Focal
Fix Released
Wishlist
Alex Tu
Groovy
Fix Released
Wishlist
Alex Tu

Bug Description

[impact]

thermald doesn't support Tiger Lake cpus

[test case]

run thermald on Tiger Lake cpu

It can be checked by following command, and the patch works if it return "passed".
$ systemctl is-active --quiet thermald && echo passed

[regression potential]

because TGL is not supported by current thermald, so thermald always inactive on TGL platform. This patch is to activate it.
So, there's not potential regression.

[scope]

needed for F/G

[original description]

need the patch to support Intel TGL CPU on Focal

https://github.com/intel/thermal_daemon/blob/master/src/thd_engine.cpp#L666

Alex Tu (alextu)
Changed in oem-priority:
importance: Undecided → Critical
status: New → Confirmed
assignee: nobody → Alex Tu (alextu)
Revision history for this message
Alex Tu (alextu) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "thermald_1.9.1-1build1ubuntu0.1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Mathew Hodson (mhodson)
summary: - need the id for Intel TGL CPU on Focal
+ Support Intel TGL CPU on Focal
Changed in thermald (Ubuntu):
importance: Undecided → Wishlist
Revision history for this message
Dan Streetman (ddstreet) wrote :

Thanks @alextu, uploaded to f/g.

Note 3 requests for future patches:
1) please make sure your debian/patches/ patch includes lines for (at least) "Origin" and "Bug-Ubuntu". The full guidelines are https://dep-team.pages.debian.net/deps/dep3/ but in general those are the only 2 DEP3 fields that need to be added to patches generated with git format-patch (the fields Bug-Debian and Bug are also useful, if bugs exist for debian and/or upstream).
2) the version was slightly off, when a version is ...build1 you don't need to append ...ubuntu to that, just replace the 'build' with 'ubuntu' and use a new version after the 'ubuntu'. So the new focal version in the upload queue is '1.9.1-1ubuntu0.1' and groovy upload is '1.9.1-1ubuntu1'.
3) you need to fill out the SRU template for any patch going into a non-development Ubuntu release; you can find it here:
https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

description: updated
Changed in thermald (Ubuntu Focal):
assignee: nobody → Alex Tu (alextu)
Changed in thermald (Ubuntu Groovy):
assignee: nobody → Alex Tu (alextu)
Changed in thermald (Ubuntu Focal):
status: New → In Progress
Changed in thermald (Ubuntu Groovy):
status: New → In Progress
Changed in thermald (Ubuntu Focal):
importance: Undecided → Wishlist
Revision history for this message
Dan Streetman (ddstreet) wrote :

@alextu can you update the SRU template [test case] and [regression potential] sections with whatever info should be there please?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thermald - 1.9.1-1ubuntu1

---------------
thermald (1.9.1-1ubuntu1) groovy; urgency=medium

  * Intel Tiger Lake support (LP: #1876066)

 -- Alex Tu <email address hidden> Thu, 30 Apr 2020 18:16:16 +0800

Changed in thermald (Ubuntu Groovy):
status: In Progress → Fix Released
Revision history for this message
Alex Tu (alextu) wrote :

@ddstreet I appreciate your quick response and detailed guidance. The description is updated. Thanks.

description: updated
description: updated
description: updated
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Alex, or anyone else affected,

Accepted thermald into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/thermald/1.9.1-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in thermald (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Alex Tu (alextu) wrote :

verified on focal in machine bios ID 09FB thermald actived well.
kernel: 5.6.0-1010-oem
BIOS: 0.1.11

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thermald - 1.9.1-1ubuntu0.1

---------------
thermald (1.9.1-1ubuntu0.1) focal; urgency=medium

  * Intel Tiger Lake support (LP: #1876066)

 -- Alex Tu <email address hidden> Thu, 30 Apr 2020 18:16:16 +0800

Changed in thermald (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for thermald has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Rex Tsai (chihchun)
tags: added: oem-priority
Changed in oem-priority:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.