Don't modify /run/run.vupdate unnecessarily

[bugproxy]

This section is for Focal SRU purpose

[Impact]

A udev script is getting triggered whenever there is a change in sysfs. All is does is "/bin/touch /run/run.vpdupdate".

Script was generic and used to trigger whenever there is any change in /sys/devices/ node.
On large system it resulted in calling udev script number of times during boot and impacted on boot time performance.

[Test Case]
It is unfortunately difficult to reproduce this problem with the proper hardware setup so IBM will very that the new udev script is in place and acting as expected and that /run/run.vupdate isn't modified unnecessarily.

[Regression Potential]
Even if unlikely a regression potential would be to prevent the system to boot.

--

Initial Bug Description below:

== Comment: #0 - Shivaprasad G. Bhat <email address hidden> - 2020-04-24 02:51:41 ==
---Problem Description---
Update libvpd package to v2.2.7

Contact Information = <email address hidden>

---Additional Hardware Info---
ppc64le

---uname output---
ppc64le

Machine Type = IBM Power

---Debugger---
A debugger is not configured

---Steps to Reproduce---
 Sources are moved to github at

https://github.com/power-ras/libvpd.git

Update both libvpd and libvpd-dev

Userspace tool common name: libvpd

The userspace tool has the following bit modes: 64-bit

Userspace rpm: libvpd

Userspace tool obtained from project website: na

*Additional Instructions for <email address hidden>:
-Post a private note with access information to the machine that the bug is occuring on.
-Attach ltrace and strace of userspace application.

[Frank Heimes (fheimes)]

Well, packages of Ubuntu releases that are already rolled out usually don't get version upgrades (release date of 20.04 was yesterday - April 23rd).
Are you interested in particular fixes that come with this new release? And if so can you specify their commit IDs so that they might be cherry-picked instead?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-04-24 05:45 EDT-------
Can you cherry pick these ?

9376ee6 udev rules: don't generate multiple vpdupdate events for SCSI/NVMe
e82ee3b udev rules: more software devices to ignore
1ed44e6 udev rules: don't touch run.vpdupdate for ignored devices

[Frank Heimes (fheimes)]

This was requested (after consulting) for 20.10 and 20.04 - I added now the nominations.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-05-28 03:12 EDT-------
(In reply to comment #8)
> This was requested (after consulting) for 20.10 and 20.04 - I added now the
> nominations.

Thanks!
-Vasant

[Matthieu Clemenceau (mclemenceau)]

Hey Frank,

I have cherry picked commits discussed in comment #2.
uploaded to my ppa, successfully built and installed.

I will get this package sponsored and uploaded and start looking into the SRU process for focal.

Matt

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-06-10 12:48 EDT-------
(In reply to comment #10)
> Hey Frank,
>
> I have cherry picked commits discussed in comment #2.
> uploaded to my ppa, successfully built and installed.
>
> I will get this package sponsored and uploaded and start looking into the
> SRU process for focal.
>
> Matt

For Groovy, its better if we can rebase to v2.2.7.

Also note that upstream repo is moved to github.

New upstream location https://github.com/power-ras/libvpd/

-Vasant

[Launchpad Janitor (janitor)]

This bug was fixed in the package libvpd - 2.2.6-1ubuntu1

---------------
libvpd (2.2.6-1ubuntu1) groovy; urgency=medium

  * Cherry pick commits from 2.2.7 (LP: #1874646)
    - 9376ee6 udev rules: don't generate multiple vpdupdate events for SCSI/NVMe
    - e82ee3b udev rules: more software devices to ignore
    - 1ed44e6 udev rules: don't touch run.vpdupdate for ignored devices
    -

 -- Matthieu Clemenceau <email address hidden> Tue, 09 Jun 2020 19:01:18 -0500

[Matthieu Clemenceau (mclemenceau)]

Ok I guess I can rebase 2.2.7 for groovy and cherry pick for Focal Noted.

[Matthieu Clemenceau (mclemenceau)]

In order to SRU these cherry picked commits into Focal,
would you mind providing me some simple instructions allowing me to reproduce a problem and confirm it is resolved with the updated package?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-06-11 02:41 EDT-------
(In reply to comment #14)
> In order to SRU these cherry picked commits into Focal,
> would you mind providing me some simple instructions allowing me to
> reproduce a problem and confirm it is resolved with the updated package?

Its bit tricky to test these cherry picked patches.

Basically we have udev script.. which gets triggered whenever there is a change in sysfs. All is does is "/bin/touch /run/run.vpdupdate".

Script was generic and used to trigger wheenever there is any change in /sys/devices/ node.

On large system it resulted in calling udev script number of times during boot and impacted on boot time performance. Hence we have fine tuned this script.

So you may not see much difference on smaller system. As long as system boots fine with updated libvpd we are good.

-Vasant

[Matthieu Clemenceau (mclemenceau)]

Hey Vasant,

I will prepare the SRU for 20.04 but in the meanwhile, it would help if you could confirm
that the groovy version of libvpd 2.2.6-1ubuntu1 works properly for you.

Thanks in Advance
Matthieu

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-06-12 00:41 EDT-------
(In reply to comment #16)
> Hey Vasant,
>
> I will prepare the SRU for 20.04 but in the meanwhile, it would help if you
> could confirm
> that the groovy version of libvpd 2.2.6-1ubuntu1 works properly for you.

Yes. I confirm that its working as expected.

-Vasant

[Matthieu Clemenceau (mclemenceau)]

Here is the debdiff for focal SRU

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-06-13 00:37 EDT-------
(In reply to comment #19)
> Created attachment 143472 [details]
> libvpd-2.2.6-1ubuntu1-focal.diff
>
> default comment

Looks good.

-Vasant

[Dimitri John Ledkov (xnox)]

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading libvpd_2.2.6-1ubuntu1~20.04.1.dsc: done.
  Uploading libvpd_2.2.6-1ubuntu1~20.04.1.debian.tar.xz: done.
  Uploading libvpd_2.2.6-1ubuntu1~20.04.1_source.buildinfo: done.
  Uploading libvpd_2.2.6-1ubuntu1~20.04.1_source.changes: done.
Successfully uploaded packages.

[Brian Murray (brian-murray)]

Hello bugproxy, or anyone else affected,

Accepted libvpd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/libvpd/2.2.6-1ubuntu1~20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-06-17 01:22 EDT-------
(In reply to comment #22)
> Hello bugproxy, or anyone else affected,
>
> Accepted libvpd into focal-proposed. The package will build now and be
> available at
> https://launchpad.net/ubuntu/+source/libvpd/2.2.6-1ubuntu1~20.04.1 in a few
> hours, and then in the -proposed repository.
>
> Please help us by testing this new package. See
> https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to
> enable and use -proposed. Your feedback will aid us getting this update out
> to other Ubuntu users.
>
> If this package fixes the bug for you, please add a comment to this bug,
> mentioning the version of the package you tested, what testing has been
> performed on the package and change the tag from verification-needed-focal
> to verification-done-focal. If it does not fix the bug for you, please add a
> comment stating that, and change the tag to verification-failed-focal. In
> either case, without details of your testing we will not be able to proceed.
>
> Further information regarding the verification process can be found at
> https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in
> advance for helping!
>
> N.B. The updated package will be released to -updates after the bug(s) fixed
> by this package have been verified and the package has been in -proposed for
> a minimum of 7 days.

I have verified and it fixes the reported issue.

Thanks
-Vasant

[Frank Heimes (fheimes)]

Thx for the quick verification, Vasant!

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for libvpd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package libvpd - 2.2.6-1ubuntu1~20.04.1

---------------
libvpd (2.2.6-1ubuntu1~20.04.1) focal; urgency=medium

  * Cherry pick commits from 2.2.7 (LP: #1874646)
    - 9376ee6 udev rules: don't generate multiple vpdupdate events for SCSI/NVMe
    - e82ee3b udev rules: more software devices to ignore
    - 1ed44e6 udev rules: don't touch run.vpdupdate for ignored devices
    -

 -- Matthieu Clemenceau <email address hidden> Tue, 09 Jun 2020 19:01:18 -0500

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2020-06-24 01:46 EDT-------
(In reply to comment #26)
> This bug was fixed in the package libvpd - 2.2.6-1ubuntu1~20.04.1
>
> ---------------
> libvpd (2.2.6-1ubuntu1~20.04.1) focal; urgency=medium
>
> * Cherry pick commits from 2.2.7 (LP: #1874646)
> - 9376ee6 udev rules: don't generate multiple vpdupdate events for SCSI/NVMe
> - e82ee3b udev rules: more software devices to ignore
> - 1ed44e6 udev rules: don't touch run.vpdupdate for ignored devices
> -
>
> -- Matthieu Clemenceau <email address hidden> Tue, 09 Jun 2020
> 19:01:18 -0500

Thanks! We can close this defect.

-Vasant