Page settings form not behaving as expected

[Robert Lyon]

Now that we have the cover image chooser on the form when I go to make a new page and press enter when focus is on page title field the form doesn't save

Instead there is an 'quotaUpdate( undefined undefined ) called but no id="quota_fill" on page' warning in the console log.

And if I open the Advanced section and go into the 'Add a file' I see the error message 'The file / folder name is required.'

Also if I select a cover image and save the form with the 'save' button and then come back to edit settings and update the page title and hit save - again the form doesn't save but now the selected cover image is now unselected - which will be confusing as the advanced section is still hidden.

So somehow, the 'enter' keystroke is being captured by the file chooser even when we are not focussed on it.

If we are not focusssed on the 'add a file' button or the 'remove' button for the selected cover image then they should not capture the enter keystroke

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10932

[Cecilia Vela Gurovic (ceciliavg)]

This is happening when the image folder 'Cover Images' doesn't exist yet.

This is also happening in the resume section of forms with a filechooser.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10943

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10944

[Rangi Daymond (rangid)]

As posted by Cecilia - To reproduce in Resume section

    go to Create-> Resume-> Education and employment
    add one Education history
    set all required fields and then click on the 'Save' button
    edit the same Education history
    when the focus is on one of the fields, press 'Enter'

You should see the 'The file / folder name is required.' error message at the top of the form

[Rangi Daymond (rangid)]

Catalyst QA Retested - PASSED

Gerrit: https://reviews.mahara.org/#/c/10943 patch 2
Browser: Chrome
Theme: Raw

Above steps repeated and the error message was no longer displayed.

Note: suspected related bug '1875484 Create page using tag value displays error messages' also retested and PASSED.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10943
Committed: https://git.mahara.org/mahara/mahara/commit/64695ae0ee0d6ae2dca898212391a46d9bda5648
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 64695ae0ee0d6ae2dca898212391a46d9bda5648
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 29 10:12:25 2020 +1200

Bug 1874540: stop adding the edit file details if there is no button to edit file allowed

when we list files in filechooser, we can allow to edit
the file details (tag, title, description)
these fields are hidden until we click the button to edit, including the
save button of this form

This save button gets triggered by pressing enter key within
the bigger form.

We don't need to have those hidden fields if we don't allow
the file details to be edited

Change-Id: Iee75f89b281bb5f15127f2b30f6846e20c6782b4

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10944
Committed: https://git.mahara.org/mahara/mahara/commit/3b963a092638878d5777c87c18bf7e9aab3a3741
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3b963a092638878d5777c87c18bf7e9aab3a3741
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 29 12:06:53 2020 +1200

Bug 1874540: preventing filelist buttons to catch events from the form that contains them

To reproduce in Resume section

- go to Create-> Resume-> Education and employment
- add one Education history
- set all required fields and then click on the 'Save' button
- edit the same Education history
- add a file with the filechooser
- click on any other field and press 'Enter'

result: the form is not submitted but one of the files is removed
from the filelist

behatnotneeded

Change-Id: Ib2361b62b20bfc1beb80709aafa95684b1b2ce36

[Mahara Bot (dev-mahara)]

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10948

[Mahara Bot (dev-mahara)]

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10949

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10949
Committed: https://git.mahara.org/mahara/mahara/commit/935cdca3f18e139332cd7e7d200a2bec4e1335e6
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 935cdca3f18e139332cd7e7d200a2bec4e1335e6
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 29 12:06:53 2020 +1200

Bug 1874540: preventing filelist buttons to catch events from the form that contains them

To reproduce in Resume section

- go to Create-> Resume-> Education and employment
- add one Education history
- set all required fields and then click on the 'Save' button
- edit the same Education history
- add a file with the filechooser
- click on any other field and press 'Enter'

result: the form is not submitted but one of the files is removed
from the filelist

behatnotneeded

Change-Id: Ib2361b62b20bfc1beb80709aafa95684b1b2ce36
(cherry picked from commit 3b963a092638878d5777c87c18bf7e9aab3a3741)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10948
Committed: https://git.mahara.org/mahara/mahara/commit/1738f74c9d32afcd257e732d5cf2fd83c7ee6c4b
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 1738f74c9d32afcd257e732d5cf2fd83c7ee6c4b
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 29 10:12:25 2020 +1200

Bug 1874540: stop adding the edit file details if there is no button to edit file allowed

when we list files in filechooser, we can allow to edit
the file details (tag, title, description)
these fields are hidden until we click the button to edit, including the
save button of this form

This save button gets triggered by pressing enter key within
the bigger form.

We don't need to have those hidden fields if we don't allow
the file details to be edited

Change-Id: Iee75f89b281bb5f15127f2b30f6846e20c6782b4
(cherry picked from commit 64695ae0ee0d6ae2dca898212391a46d9bda5648)