extracting a zipped file's contents not working correctly

[Robert Lyon]

This page needs some fixing up, the current problems are:

1) The process bar is in the old css style and should be using the new colours and not have a scroll bar in it

2) The general layout of the page could use some tidying up as well

3) The extraction of files looks to work but there is no redirect back to files page (either automatically or via a button)

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11065

[Robert Lyon (robertl-9)]

Also noticed a problem

4) a user guessing file IDs can initiate a zip file extraction for another user, eg hitting the page artefact/file/extract.php?file= with a valid ID for a zip file

luckily the files get extracted to the zip file owner and not the hacker but we need to fix that up as well as they can see a list of filenames in the zip file

[Cecilia Vela Gurovic (ceciliavg)]

Note for testing:

- Check the attached images to see how the old a new style look like
- The progress bar is only displayed when the file to decompress has more than 10 files in it

[Rangi Daymond (rangid)]

Catalyst QA Tested - PASSED

Please see attached execution results spreadsheet for further detail and sample screenshot.

Gerrit: https://reviews.mahara.org/#/c/11065/ Patch set 9
Browser/s: Win10 Chrome only
Theme: all six

A) Preconditions:
The developer (Robert) has performed testing with a zip file containing
more than 100 files so this testing will use:
a) singlefile.zip: containing a single file
b) 10files.zip: containing 10 files
c) 11files.zip: containing 11 files
d) 1folder11file.zip: containing 1 folder and 11 files
e) 5folder11file.zip: containing 5 folders and 11 files.
Note: exploratory testing has shown that a folder is counted as a file
for decompression purposes.

A) Repeat the test scenario 1 & 2 test steps for each of the six Mahara
themes: Raw, Default, Primary school, Ocean, Modern, and Maroon. In each
test scenario, use the zip files as shown below in 'A) Expected results'.

Test scenario 1: Verify that the decompress progress bar is not
displayed when the file to decompress has 10 or fewer files in it.
Test steps:
1.1 Log in as site admin (and set the theme if necessary).
1.2 Navigate to 'Main menu' > 'Create' > 'Files', then select to
decompress the zip file
    Expected results:
    - the 'Decompress' page is displayed, select the 'Decompress' button
    - the 'Files' page is displayed, showing the content of the newly
created 'Home/<file name>' folder
    - the correct files are displayed, each with their pre-zipped
properties unchanged.
1.3 Select the 'Parent folder' link
    Expected results:
    - the 'Files' page is displayed showing the content of the 'Home' folder
    - the newly created subfolder has:
      - the same name as the selected zip file
      - the description 'Files extracted from archive'
      - today's date in the format dd/mm/yyyy
      - edit and delete folder icons are available
      - selecting the folder name redisplays the 'Files' page for
the folder
      - selecting the up-arrow returns the user to the 'Home' folder.

Test scenario 2: Verify that the decompress progress bar is displayed
when the file to decompress has more than 10 files in it.
Test steps:
2.1 Select to decompress the zip file (see 'A) Expected results' below for
filename)
    Expected results:
    - the 'Decompress' page will display, select the 'Decompress' button
    - the text "Please wait while your files are being unzipped." will
display
    - the progress bar will display incrementally to indicate progress
    - the progress text will appear underneath the progress bar
    - the progress text will reflect incremental progress
    - on task completion the correct version of text 'Created <x
folder/s and> <y> files.' will display
    - the 'Continue' button will be positioned to the right underneath
the progress bar
    - page styling will be correct for the theme:
      - page element choice and placement are in theme
      - font and colour choices are in theme
      - progress bar and background colour have a contrast ratio of at least 4.5:1
      - progress text and background colour have a contrast ratio of at least 4.5:1.
2.2 Select the Continue button
    Expected results:
    - the 'Files' page will display ...

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11065
Committed: https://git.mahara.org/mahara/mahara/commit/8387eca2e127bc1ba51a7a48b4a08b8d40bf22b0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 8387eca2e127bc1ba51a7a48b4a08b8d40bf22b0
Author: Robert Lyon <email address hidden>
Date: Thu Jul 9 15:56:13 2020 +1200

Bug 1874530: Adjusting the artefact extract to use modern colours

And display a button once completed

Change-Id: Ife98ed3de2e10d8861e75911ecdd7f7cc659b2a9
Signed-off-by: Robert Lyon <email address hidden>