[landscape] Substitute oidc conf in service file
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
sosreport (Ubuntu) |
Fix Released
|
High
|
Eric Desrochers | ||
Xenial |
Won't Fix
|
High
|
Eric Desrochers | ||
Bionic |
Fix Released
|
High
|
Eric Desrochers | ||
Eoan |
Fix Released
|
High
|
Eric Desrochers | ||
Focal |
Fix Released
|
High
|
Eric Desrochers | ||
Groovy |
Fix Released
|
High
|
Eric Desrochers |
Bug Description
[Impact]
Landscape has added the ability to connect to OIDC.
The plugin should be updated to obfuscate the sensitive information.
https:/
[Test Case]
* Install sosreport
* Install landscape-client and/or landscape-server (to make sure sosreport's landscape plugin will be triggered) from the Landscape PPA -> https:/
* Manually append or create files: "/etc/landscape
* Add the following in both "/etc/landscape
oidc-client-secret = secret-test
oidc-client-id = id-test
* Execute sosreport "sosreport -a"
* Make sure landscape plugin was exercise.
* Extract archive and make sure both "oidc-client-id" & "oidc-client-
Expected result (path_to_
oidc-client-secret = [********]
oidc-client-id = [********]
Extra testing (sanity check):
* Look under "sos_reports" for full report.
* Look under "sos_logs" for warnings/errors.
$ grep -v "INFO:" sos_logs/sos.log
* Run "simple.sh": A quick port of the travis tests to bash. Generating various type of sosreports collection.
https:/
[Regression]
No regression expected, we don't change/impact core functionnalities nor affect other plugins. If something happens it will be isolate to the landscape plugin itself only.
Worse case the OID substitution won't work as expected (corner case) and will reveal OID sensible information, but it is very unlikely to happen as it will be intensively tested during the testing phase, and the substitute mechanism in place has been proven to work for the same configuration files in the landscape plugin already.
[Other Informations]
Upstream bug:
https:/
Upstream PR:
https:/
Upstream commit:
https:/
tags: | added: sts |
Changed in sosreport (Ubuntu Focal): | |
status: | New → In Progress |
assignee: | nobody → Eric Desrochers (slashd) |
Changed in sosreport (Ubuntu Eoan): | |
status: | New → In Progress |
Changed in sosreport (Ubuntu Bionic): | |
status: | New → In Progress |
Changed in sosreport (Ubuntu Xenial): | |
status: | New → In Progress |
assignee: | nobody → Eric Desrochers (slashd) |
Changed in sosreport (Ubuntu Bionic): | |
assignee: | nobody → Eric Desrochers (slashd) |
Changed in sosreport (Ubuntu Eoan): | |
assignee: | nobody → Eric Desrochers (slashd) |
description: | updated |
description: | updated |
tags: | added: sts-sponsor-slashd |
Changed in sosreport (Ubuntu Focal): | |
importance: | Undecided → High |
Changed in sosreport (Ubuntu Eoan): | |
importance: | Undecided → High |
Changed in sosreport (Ubuntu Bionic): | |
importance: | Undecided → High |
Changed in sosreport (Ubuntu Xenial): | |
importance: | Undecided → High |
Changed in sosreport (Ubuntu): | |
importance: | Undecided → High |
description: | updated |
description: | updated |
Changed in sosreport (Ubuntu Xenial): | |
assignee: | nobody → Eric Desrochers (slashd) |
Uploaded in groovy.