gpsd needs to ship packaging/deb/etc_default_gpsd as default instead of debian/gpsd.default
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gpsd (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Won't Fix
|
High
|
Unassigned |
Bug Description
[Impact]
* gpsdctl@.service uses a variable that isn't defined
* backport changes to define this
* >=Groovy set default to true, but we will set false for Focal to not
change behavior on SRU (adding the variable still is useful as people
can modify it much more easily than adding - or knowing about - it)
* Currently users in Focal have no indicator to know about this tunable.
Adding it to the default conffile but in the mode that matches current
focal behavior will help.
[Test Case]
* After install check if /etc/default/gpsd contains any definition for
USBAUTO
$ grep USBAUTO /etc/default/gpsd
[Regression Potential]
* This particular change replaces a non existent variable with the
default. In future releases this is set to true, but for the backport
we will set false to match and not change the behavior focal was
released with. Due to that no change/regression should occur as behavior
isn't changed.
[Other Info]
* This is accepted in Debians packaging git, if not in Groovy in time I'll
need to put an 3.20-8ubuntu1 there, but I can preparing the SRU
independent to that.
---
gpsd needs to ship packaging/
Newer options are only added here:
$ cat packaging/
# Default settings for gpsd.
# Please do not edit this file directly - use `dpkg-reconfigure gpsd' to
# change the options.
START_DAEMON="true"
GPSD_OPTIONS=""
DEVICES=""
USBAUTO="true"
GPSD_SOCKET=
But
# Devices gpsd should collect to at boot time.
# They need to be read/writeable, either by user gpsd or the group dialout.
DEVICES=""
# Other options you want to pass to gpsd
GPSD_OPTIONS=""
Some scripts depend on that e.g.
ubuntu@ubuntu:~$ cat /lib/systemd/
...
ExecStart=/bin/sh -c "[ \"$USBAUTO\" = true ] && /usr/sbin/gpsdctl add /dev/%I || :"
ExecStop=/bin/sh -c "[ \"$USBAUTO\" = true ] && /usr/sbin/gpsdctl remove /dev/%I || :
Related branches
- Christian Ehrhardt (community): Approve
- Lucas Kanashiro (community): Needs Fixing
- Canonical Server: Pending requested
-
Diff: 115 lines (+56/-0) (has conflicts)5 files modifieddebian/changelog (+11/-0)
debian/control (+5/-0)
debian/control.in (+5/-0)
debian/gpsd.default (+6/-0)
debian/usr.sbin.gpsd (+29/-0)
Well, yes and no.
I'd not ship the upstream version - dpkg-reconfigure just doesn't do anything.
But its true, that the USBAUTO option is missing in the default file. Seems that was added to the service at some point and went missing.