missing hardware/runtime info when reporing linux-firmware bugs via apport

[You-Sheng Yang]

Updated Description to match SRU requirements for bionic

[Impact]
linux-firmware doesn't install any package hooks for apport, so it will only carry some default items leaving hardware list, kernel messages unattached. Suggest symlink /usr/share/apport/package-hooks/source_linux-firmware.py to source_linux.py as other linux image debs do in bug 1847967.

[Test Case]
1) On an Ubuntu 18.04 LTS system run 'apport-cli linux-firmware'.
2) Choose 'View report'
3) Observe that 'ProcFB' is not collected

With the version of apport from -proposed 'ProcFB' will be in the report.

[Regression Potential]
Very limited, as we are just adding a symlink from linux-firmware to the linux source package hook. this change has been available in Focal and Groovy without problem

Original Description
--------------------
ProblemType: BugDistroRelease: Ubuntu 20.04
Package: linux-firmware 1.187
ProcVersionSignature: Ubuntu 5.4.0-21.25-generic 5.4.27
Uname: Linux 5.4.0-21-generic x86_64
NonfreeKernelModules: wl
ApportVersion: 2.20.11-0ubuntu26
Architecture: amd64
CasperMD5CheckResult: skip
Date: Fri Apr 10 19:15:15 2020
Dependencies:

InstallationDate: Installed on 2019-09-28 (194 days ago)
InstallationMedia: Ubuntu 19.10 "Eoan Ermine" - Alpha amd64 (20190923)
PackageArchitecture: allSourcePackage: linux-firmware
UpgradeStatus: No upgrade log present (probably fresh install)
---
ProblemType: Bug
ApportVersion: 2.20.11-0ubuntu26
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: KDE
Dependencies:

DistroRelease: Ubuntu 20.04
InstallationDate: Installed on 2019-09-28 (194 days ago)
InstallationMedia: Ubuntu 19.10 "Eoan Ermine" - Alpha amd64 (20190923)
MachineType: Apple Inc. MacBookPro11,1
NonfreeKernelModules: wl
Package: linux-firmware
PackageArchitecture: all
ProcFB: 0 i915drmfb
ProcKernelCmdLine: BOOT_IMAGE=/@/boot/vmlinuz-5.4.0-21-generic root=UUID=38c16714-8883-4c88-baae-df71ffa89972 ro rootflags=subvol=@ quiet splash acpi_enforce_resources=lax crashkernel=512M-:192M vt.handoff=7
ProcVersionSignature: Ubuntu 5.4.0-21.25-generic 5.4.27
RelatedPackageVersions:
 linux-restricted-modules-5.4.0-21-generic N/A
 linux-backports-modules-5.4.0-21-generic N/A
 linux-firmware 1.187
Tags: focal
Uname: Linux 5.4.0-21-generic x86_64
UpgradeStatus: No upgrade log present (probably fresh install)
UserGroups: adm audio cdrom dip docker lpadmin lxd microk8s plugdev sambashare sudo video
_MarkForUpload: True
dmi.bios.date: 06/13/2019
dmi.bios.vendor: Apple Inc.
dmi.bios.version: 156.0.0.0.0
dmi.board.asset.tag: Base Board Asset Tag#
dmi.board.name: Mac-189A3D4F975D5FFC
dmi.board.vendor: Apple Inc.
dmi.board.version: MacBookPro11,1
dmi.chassis.type: 10
dmi.chassis.vendor: Apple Inc.
dmi.chassis.version: Mac-189A3D4F975D5FFC
dmi.modalias: dmi:bvnAppleInc.:bvr156.0.0.0.0:bd06/13/2019:svnAppleInc.:pnMacBookPro11,1:pvr1.0:rvnAppleInc.:rnMac-189A3D4F975D5FFC:rvrMacBookPro11,1:cvnAppleInc.:ct10:cvrMac-189A3D4F975D5FFC:
dmi.product.family: Mac
dmi.product.name: MacBookPro11,1
dmi.product.sku: System SKU#
dmi.product.version: 1.0
dmi.sys.vendor: Apple Inc.

[You-Sheng Yang (vicamo)]

https://lists.ubuntu.com/archives/kernel-team/2020-April/108960.html

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

apport information

[You-Sheng Yang (vicamo)]

Triggered `apport-collect 1872059` when source_linux-firmware.py symlink was manually created.

[Brian Murray (brian-murray)]

Given that all the other linux package hook symlinks are made in apport I think it would make sense to include the linux-firmware symlink there.

[ 8:47AM 10484 ] [ bdmurray@impulse:~/source-trees/apport/focal ]
 $ head -n15 debian/apport.links
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-meta-oem-osp1.py
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-meta-oem.py
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-meta.py
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-oem-osp1.py
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-oem.py
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-signed-oem-osp1.py
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-signed-oem.py
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-signed.py
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-signed-5.4.py
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-signed-oem-5.4.py
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-5.4.py
/usr/share/apport/package-hooks/source_linux.py /usr/share/apport/package-hooks/source_linux-oem-5.4.py
/usr/bin/apport-bug /usr/bin/ubuntu-bug
/usr/share/man/man1/apport-bug.1.gz /usr/share/man/man1/ubuntu-bug.1.gz
/usr/share/man/man1/apport-bug.1.gz /usr/share/man/man1/apport-collect.1.gz

[You-Sheng Yang (vicamo)]

Resent as https://lists.ubuntu.com/archives/kernel-team/2020-April/108993.html

[You-Sheng Yang (vicamo)]

Resubmit to apport as https://code.launchpad.net/~vicamo/ubuntu/+source/apport/+git/apport/+merge/382559 instead per comment #11.

[Brian Murray (brian-murray)]

I've uploaded this to focal queue for review by the Ubuntu Release team who will decide if this should be an SRU or included in any respins.

[Chris Halse Rogers (raof)]

An upload of apport to focal-proposed has been rejected from the upload queue for the following reason: "Groovy already has an apport verson 2.20.11-0ubuntu28 uploaded, withThis will need a new upload with a new version.".

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.20.11-0ubuntu32

---------------
apport (2.20.11-0ubuntu32) groovy; urgency=medium

  * debian/apport.install: Add in a source package hook for linux-meta-raspi
    which provides linux-raspi and linux-raspi2. (LP: #1876952)

 -- Brian Murray <email address hidden> Tue, 05 May 2020 09:29:28 -0700

[Łukasz Zemczak (sil2100)]

Hello You-Sheng, or anyone else affected,

Accepted apport into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.20.11-0ubuntu27.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

This fix has been verified.

bdmurray@clean-focal-amd64:~$ apt-cache policy apport
apport:
  Installed: 2.20.11-0ubuntu27.2
  Candidate: 2.20.11-0ubuntu27.2
  Version table:
 *** 2.20.11-0ubuntu27.2 500
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     2.20.11-0ubuntu27 500
        500 http://192.168.10.7/ubuntu focal/main amd64 Packages
        500 http://192.168.10.7/ubuntu focal/main i386 Packages
bdmurray@clean-focal-amd64:~$ grep "ProcFB" /tmp/apport.linux-firmware._h6whqad.apport
ProcFB: 0 qxldrmfb

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.20.11-0ubuntu27.2

---------------
apport (2.20.11-0ubuntu27.2) focal; urgency=medium

  * gtk/apport-gtk: upgrade regular expression used to match URLs in free text
    (LP: #1871185)

apport (2.20.11-0ubuntu27.1) focal; urgency=medium

  * debian/apport.install: Add in a source package hook for linux-meta-raspi
    which provides linux-raspi and linux-raspi2. (LP: #1876952)
  * data/general-hooks/ubuntu.py: collect ImageMediaBuild information which
    exists on preinstalled RPi images. (LP: #1876945)
  * Add in a source package hook symlink for linux-firmware. (LP: #1872059)
  * debian/tests/control: Depend on python3-twisted, not python-twisted-core

 -- Brian Murray <email address hidden> Tue, 12 May 2020 15:34:22 -0700

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for apport has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[You-Sheng Yang (vicamo)]

@Brian, can we have this backport to Bionic as well? Bionic is to end extended desktop/server support on 2023 and extended security support on 2028, so it's still likely to receive bug reports in the future on Bionic.

[Matthieu Clemenceau (mclemenceau)]

The attached deb diff will fix issue this on bionic as of today with latest apport on bionic being 2.20.9-0ubuntu7.16

[Brian Murray (brian-murray)]

I've uploaded this to the SRU queue for Bionic.

[Robie Basak (racb)]

Hello You-Sheng, or anyone else affected,

Accepted apport into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/apport/2.20.9-0ubuntu7.17 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted apport (2.20.9-0ubuntu7.17) for bionic have finished running.
The following regressions have been reported in tests triggered by the package:

apport/2.20.9-0ubuntu7.17 (amd64, i386)
ubuntu-release-upgrader/1:18.04.38 (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/bionic/update_excuses.html#apport

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[You-Sheng Yang (vicamo)]

That should be a regression introduced in bug 1861451, which is to allow gathering information as root under non-gui env.

[Matthieu Clemenceau (mclemenceau)]

Verified that the report from apport-2.20.9-0ubuntu7.17 from bionic-proposed includes the ProcFB details. Verification-done

[Launchpad Janitor (janitor)]

This bug was fixed in the package apport - 2.20.9-0ubuntu7.17

---------------
apport (2.20.9-0ubuntu7.17) bionic; urgency=medium

  [ Brian Murray ]
  * apport/hookutils.py: workaround the fact that pkexec does not work in
    non-graphical environments yet (LP #1821415) by skipping the gathering of
    information as root because it isn't strictly necessary for a bug report.
    (LP: #1861451)

  [ Matthieu Clemenceau ]
  * Add in a source package hook symlink for linux-firmware. (LP: #1872059)

 -- Brian Murray <email address hidden> Wed, 05 Aug 2020 18:08:39 -0700